From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm, scmi: Do not use clocks for SCMI performance domains
Date: Thu, 22 Oct 2020 19:22:33 +0100 [thread overview]
Message-ID: <20201022182233.hklq6j5n5kkqg4yv@bogus> (raw)
In-Reply-To: <20201021183104.27949-1-sudeep.holla@arm.com>
On Wed, Oct 21, 2020 at 07:31:03PM +0100, Sudeep Holla wrote:
> Commit dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return
> -EPROBE_DEFER") handles -EPROBE_DEFER for the clock/interconnects within
> _allocate_opp_table() which is called from dev_pm_opp_add and it
> now propagates the error back to the caller.
>
> SCMI performance domain re-used clock bindings to keep it simple. However
> with the above mentioned change, if clock property is present in a device
> node, opps can't be added until clk_get succeeds. So in order to fix the
> issue, we can register dummy clocks which is completely ugly.
>
> Since there are no upstream users for the SCMI performance domain clock
> bindings, let us introduce separate performance domain bindings for the
> same.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> .../devicetree/bindings/arm/arm,scmi.txt | 19 ++++++++++++++++---
> 1 file changed, 16 insertions(+), 3 deletions(-)
>
> v1[1]->v2:
> - Changed the generic #perf-domain-cells to more SCMI specific
> property #arm,scmi-perf-domain-cells
>
Is more specific #arm,scmi-perf-domain-cells acceptable ?
Sorry for the rush, but this fixes SCMI cpufreq which is broken after
commit dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return
-EPROBE_DEFER")
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-22 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 18:31 [PATCH v2 1/2] dt-bindings: arm, scmi: Do not use clocks for SCMI performance domains Sudeep Holla
2020-10-21 18:31 ` [PATCH v2 2/2] firmware: arm_scmi: Move away from clock devicetree bindings Sudeep Holla
2020-10-22 18:22 ` Sudeep Holla [this message]
2020-10-23 13:24 ` [PATCH v2 1/2] dt-bindings: arm, scmi: Do not use clocks for SCMI performance domains Rob Herring
2020-10-23 13:59 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022182233.hklq6j5n5kkqg4yv@bogus \
--to=sudeep.holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox