From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07E1EC388F7 for ; Thu, 22 Oct 2020 21:20:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FBA024630 for ; Thu, 22 Oct 2020 21:20:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Oj/uOhJf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="17kwLpFu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FBA024630 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=/cxdfan3WX/JHHZcubi1q1NuvStVPu9Pnkd6UN7VXks=; b=Oj/uOhJfW7o/+IKJ+fmbZ2VSPL ezF5+S5O/RvHKhxO2m3OIOQoWXZPLLOOSScgHwPX2/3jZyVHXVQg4Zisb+JgUyUg0/BAkOisXfcZL 4mlYu5pyJtebMF8KAiyE2e6MlEvINZf652+2oqL/pG3+e8Kg8NCyxkP+YqThayX98iOgaSkHi2dcZ w3qxpaxGfb8WURxKXofTulTVobZceXeqqXHiyAZX0HxwxX2jdf5a6mQzv6qVz8QLEBYQ/xhNaLhGh pdPCVGjQCvRHVov5hrNK+Vj2S5MQttJjHh9TvV4GVnXK4MaNdc66s94Ks+wswNavkXfmTlOrDIyC2 FyF+AQng==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVhyi-0007Y2-Hm; Thu, 22 Oct 2020 21:18:32 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVhyg-0007Wh-Fx for linux-arm-kernel@lists.infradead.org; Thu, 22 Oct 2020 21:18:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5cBekD3bplpW1a2zZ3pgYTutgTj4JBNLHTV3OzaHuJU=; b=17kwLpFuYiVPZJbGK3yWSFeXO PmVqOwdFblibk4EatVN2ugDKsrOLe46oQ+6xhT9THep6pw9lTHPzL/JGX+05ymI3aQ7PIZ+D0jtGx 7Dxxy/8N4WG+Jyj7S2G0dAdc/qkjBx9QlHKX3+AjW/xW2Ot1qz1BwDDGUOOLRmbJK11TCx8+5vu8d 2OuNenrgksUXr1Y0V/xZcFcnaLYXSBm4UjBDwfU4VHWt9MGr47fuk5uiOfytcMWQYUP0Dx7xCPgC8 QqaERMEdM9pBLRRXLk5e0QVxpP3r6A8vdQU4YkKOiE9tlLiWXzeMKCZiFIZf7QpGKhIyBzgBkN8wp CUXYy96AQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49674) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVhyZ-0002aB-4Q; Thu, 22 Oct 2020 22:18:23 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kVhyX-0007k4-TW; Thu, 22 Oct 2020 22:18:21 +0100 Date: Thu, 22 Oct 2020 22:18:21 +0100 From: Russell King - ARM Linux admin To: Rob Herring , Lorenzo Pieralisi , Thomas Petazzoni , Jason Cooper Subject: [BUG] PCIe on Armada 388 broken since 5.9 Message-ID: <20201022211821.GU1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201022_171830_595785_0C3100F8 X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, It appears that PCIe on Armada 388 has been broken in 5.9. Here are the boot messages: mvebu-pcie soc:pcie: host bridge /soc/pcie ranges: mvebu-pcie soc:pcie: MEM 0x00f1080000..0x00f1081fff -> 0x0000080000 mvebu-pcie soc:pcie: MEM 0x00f1040000..0x00f1041fff -> 0x0000040000 mvebu-pcie soc:pcie: MEM 0x00f1044000..0x00f1045fff -> 0x0000044000 mvebu-pcie soc:pcie: MEM 0x00f1048000..0x00f1049fff -> 0x0000048000 mvebu-pcie soc:pcie: MEM 0xffffffffffffffff..0x00fffffffe -> 0x0100000000 mvebu-pcie soc:pcie: IO 0xffffffffffffffff..0x00fffffffe -> 0x0100000000 mvebu-pcie soc:pcie: MEM 0xffffffffffffffff..0x00fffffffe -> 0x0200000000 mvebu-pcie soc:pcie: IO 0xffffffffffffffff..0x00fffffffe -> 0x0200000000 mvebu-pcie soc:pcie: MEM 0xffffffffffffffff..0x00fffffffe -> 0x0300000000 mvebu-pcie soc:pcie: IO 0xffffffffffffffff..0x00fffffffe -> 0x0300000000 mvebu-pcie soc:pcie: MEM 0xffffffffffffffff..0x00fffffffe -> 0x0400000000 mvebu-pcie soc:pcie: IO 0xffffffffffffffff..0x00fffffffe -> 0x0400000000 mvebu-pcie soc:pcie: resource collision: [mem 0xf1080000-0xf1081fff] conflicts with pcie [mem 0xf1080000-0xf1081fff] mvebu-pcie: probe of soc:pcie failed with error -16 This results in PCIe being entirely non-functional. At a guess, I'd say it's due to: commit c322fa0b3fa948010a278794e60c45ec860e4a1e Author: Rob Herring Date: Fri May 22 17:48:19 2020 -0600 PCI: mvebu: Use struct pci_host_bridge.windows list directly There's no need to create a temporary resource list and then splice it to struct pci_host_bridge.windows list. Just use pci_host_bridge.windows directly. The necessary clean-up is already handled by the PCI core. Link: https://lore.kernel.org/r/20200522234832.954484-3-robh@kernel.org Signed-off-by: Rob Herring Signed-off-by: Lorenzo Pieralisi Cc: Thomas Petazzoni Cc: Jason Cooper Any suggestions? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel