From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F05C55178 for ; Fri, 23 Oct 2020 09:36:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FD372192A for ; Fri, 23 Oct 2020 09:36:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1+0liiIQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FD372192A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P3VMpMIMZ9CqjN6iGnMauvISH+jDTuWop5mJ+bjZDJQ=; b=1+0liiIQGTLFJFyQjwjDb7VJz 3ePkEFIEcc81Rda9O2W0O+v5+huq9Dm1PRoUSj4xNrvHOYv0cH0zWOALDAqUqntR9k1Jrv27z1z6F uedbyG8EoPhPH/yUTd1wncHFmemAU5uj9T8HfdD9hKqmIzq7fngUW5C6tckElf+Lr4GxuESWeGApz 7+YsWDTooC5pSMeyN63r7qq2w3lDhgB7QLNCDHWYcQzE0DXYkOXt9XTPbR4W3d5kNNlBpHCyF4B+U dlQyjAATEarqag8T5VFLbOequ2BfloTLacE/bOrmF2+7GupFHuPcZ1zh8UEWUxg/p5K6/F/MSBXTW ThD6JgUcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVtTL-0003qS-JM; Fri, 23 Oct 2020 09:34:55 +0000 Received: from mail-ej1-f67.google.com ([209.85.218.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVtTI-0003pf-Gi for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2020 09:34:53 +0000 Received: by mail-ej1-f67.google.com with SMTP id a3so1435725ejy.11 for ; Fri, 23 Oct 2020 02:34:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xIVItItN3N7pseJnKSLk982NZI9iT/uzBTeYcyfN29E=; b=EJ/uEGYgDWj8EuiGkFMPJCVCBwdZXfFkPgi399XMyuSGR7yI2Vt4wIhPBq2S3JMpFf YF5mADAbRKg/lW2VlnUr23wR1IldhNivO3F4TqkimyNApgCdsKi/rCvEP4z157LmSkMA z2gU9wr7THZDGvTOESrCJ9ztsEedXOJa+iccN04xq01bGgD5BSRiXQL2C1SmejfBfYwd OuRaTPd21A5ALbqXSo2/Y2r3bR9AOIXViLxkG/7HnEBwWkNriG+cuJiuKFlp562ODiCX mXn8DMPCs6tZtFMsszB1b4bt2LZOyae80x88wm5/I8CsVu3zNF99SBAHaxHM3/sv1ERp tvLQ== X-Gm-Message-State: AOAM530flHRuHZSJaPg0kc1l+5g4yWmX2/ZCm4iu8Ux0zRhEkuVawSux ZOlt8ISuKveA9H5pD+C3Vjs= X-Google-Smtp-Source: ABdhPJywWFJR+C6CVaxj6LAyvrlb/aO/MBxhqBvkTXk7NZnjqRsiBabbSt5uIPlkaEVqN6Tbz2s4HQ== X-Received: by 2002:a17:906:2dc5:: with SMTP id h5mr1035220eji.507.1603445691039; Fri, 23 Oct 2020 02:34:51 -0700 (PDT) Received: from kozik-lap ([194.230.155.171]) by smtp.googlemail.com with ESMTPSA id s12sm498655ejy.25.2020.10.23.02.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 02:34:49 -0700 (PDT) Date: Fri, 23 Oct 2020 11:34:46 +0200 From: Krzysztof Kozlowski To: Adam Ford Subject: Re: [PATCH] arm64: dts: imx8mm: Add GPU node Message-ID: <20201023093446.GA42872@kozik-lap> References: <20201022171639.773702-1-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201022171639.773702-1-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201023_053452_580990_F5EC6EF4 X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marex@denx.de, devicetree@vger.kernel.org, Fabio Estevam , Sascha Hauer , aford@beaconembedded.com, linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 22, 2020 at 12:16:39PM -0500, Adam Ford wrote: > According to the documentation from NXP, the i.MX8M Nano has a > Vivante GC7000 Ultra Lite as its GPU core. > > With this patch, the Etnaviv driver presents the GPU as: > etnaviv-gpu 38000000.gpu: model: GC7000, revision: 6203 > > It uses the GPCV2 controller to enable the power domain for the GPU. > > Signed-off-by: Adam Ford > --- > This patch depends on a series located: > https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=368903 > and > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > index 605e6dbd2c6f..62c8cd3dea7c 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > @@ -4,6 +4,8 @@ > */ > > #include > +#include > +#include > #include > #include > #include > @@ -1019,6 +1021,31 @@ gpmi: nand-controller@33002000 { > status = "disabled"; > }; > > + gpu: gpu@38000000 { > + compatible = "vivante,gc"; > + reg = <0x38000000 0x8000>; > + interrupts = ; > + clocks = <&clk IMX8MN_CLK_GPU_AHB>, > + <&clk IMX8MN_CLK_GPU_BUS_ROOT>, > + <&clk IMX8MN_CLK_GPU_CORE_ROOT>, > + <&clk IMX8MN_CLK_GPU_SHADER_DIV>; > + clock-names = "reg", "bus", "core", "shader"; > + assigned-clocks = <&clk IMX8MN_CLK_GPU_CORE_SRC>, > + <&clk IMX8MN_CLK_GPU_SHADER_SRC>, > + <&clk IMX8MN_CLK_GPU_AXI>, > + <&clk IMX8MN_CLK_GPU_AHB>, > + <&clk IMX8MN_GPU_PLL>, > + <&clk IMX8MN_CLK_GPU_CORE_DIV>, > + <&clk IMX8MN_CLK_GPU_SHADER_DIV>; > + assigned-clock-parents = <&clk IMX8MN_GPU_PLL_OUT>, > + <&clk IMX8MN_GPU_PLL_OUT>, > + <&clk IMX8MN_SYS_PLL1_800M>, > + <&clk IMX8MN_SYS_PLL1_800M>; > + assigned-clock-rates = <0>, <0>, <800000000>, <400000000>, <1200000000>, > + <400000000>, <400000000>; Plaese indent it till '=' and put each entry in new line. This will match other 'assigned-clock' properties. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel