From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB854C388F9 for ; Fri, 23 Oct 2020 09:56:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 320D82168B for ; Fri, 23 Oct 2020 09:56:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yeFNGGOn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 320D82168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ILp+K2VgUenkaVfnuP9j9PINlfnvtg2cx95CS10Kbdc=; b=yeFNGGOnkZeou0Z4T49mjOroA 2eFiU0AAskmLGV0DTvq7MVew+GWfInDP0Bby1s9KUlq5MJiIP+0JJ4FNGm0YN+rikshAhM6q9cS5U HTjiOHrgmTnJh3vjO5/t4ejPsLQ+Ju//zRPk/fqXr9bXoIBw6jcsFBHQvQPTDe0yiBtTfKbe9qUoc K/hdSJbRphG6p6E7ygg7kytUYgedQKb4M4sKlVoZh/1ijUK78NafJmEdPPeTgYXavXgBLo48cHY4T 6rtOcuSXDBpaTmAVJ03VFud8Jo7jGBQsMBxxDNhIoB3wvnoLSvzeyKcz3oTVPg2MUtWzJtynnaXP9 Ho4aGTP+w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVtnC-0008Ml-Gq; Fri, 23 Oct 2020 09:55:26 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVtn9-0008M8-VK for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2020 09:55:24 +0000 Received: by mail-ej1-f65.google.com with SMTP id t25so1500508ejd.13 for ; Fri, 23 Oct 2020 02:55:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ICcLjBaaZNrzw4RPAfBJmgQhH+Q612qy3XI9y9+bUfI=; b=UeWdY+vgl3E/ESzKNiDaIxdgPTz5ggz03Zv4M44P1XuF+Y9rkSFPmlPwVBHwr9J/T6 cBF7XOsuI+Vze10VC1ylC/8o//NvFnkYVJG1kusMa2IggMJIPX0QGDDfROZf8YRiJDRf kwk+21jSGwvUKI19B4bOBt3U/PSj0fClfV75bwAFRkaemwWcUBHRVmOb1r41sTKrZhwt Sid1DwAxusW1ZIb06nuUzlmjyiwpieXM4wEc1OXvwzvEj6EIyvVCHyoZReCCG3565Cz0 2Fm8xTHOkwZ9f99p6CxCgGdpCa/N7MmKU3KxV0s47UDa0PSyycfULnCo0QgCpRuInqim Un4A== X-Gm-Message-State: AOAM533FugMx/cEQ8UDbDNm+9vZZzhWJeGvz98LtPENHGOu/pZu8npP0 fUGd4zKPclcmzkPAyi8v4Rg= X-Google-Smtp-Source: ABdhPJw3q2Nkzuq76xfLHtJmgVPKBaXvvka62mUYASOerJeHFiUWZbbgxMgWzqU275sIbgATDb7C2w== X-Received: by 2002:a17:907:435b:: with SMTP id oc19mr1065718ejb.311.1603446922526; Fri, 23 Oct 2020 02:55:22 -0700 (PDT) Received: from kozik-lap ([194.230.155.171]) by smtp.googlemail.com with ESMTPSA id h4sm531741ejk.71.2020.10.23.02.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 02:55:21 -0700 (PDT) Date: Fri, 23 Oct 2020 11:55:18 +0200 From: Krzysztof Kozlowski To: Adam Ford Subject: Re: [PATCH 4/4] arm64: dts: imx8mn: Add power-domain reference in USB controller Message-ID: <20201023095518.GF42872@kozik-lap> References: <20201022150808.763082-1-aford173@gmail.com> <20201022150808.763082-5-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201022150808.763082-5-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201023_055524_028901_0A2E8F99 X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marex@denx.de, devicetree@vger.kernel.org, Andrey Smirnov , Fabio Estevam , Sascha Hauer , aford@beaconembedded.com, linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 22, 2020 at 10:08:07AM -0500, Adam Ford wrote: > The USB OTG controller cannot be used until the power-domain is enabled > unless it was started in the bootloader. > > Adding the power-domain reference to the OTG node allows the OTG > controller to operate. > > Signed-off-by: Adam Ford > I wonder, why your patches do not have usual Git trailer with summary of changes (after '---')? > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > index 27733fbe87e9..605e6dbd2c6f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > @@ -979,6 +979,7 @@ usbotg1: usb@32e40000 { > assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_500M>; > fsl,usbphy = <&usbphynop1>; > fsl,usbmisc = <&usbmisc1 0>; > + power-domains = <&pgc_otg1>; I guess you need it also for the usbphynop1 and usbmisc1. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel