From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2460C388F9 for ; Fri, 23 Oct 2020 11:10:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BAB92192A for ; Fri, 23 Oct 2020 11:10:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eLZjRBLo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BAB92192A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zk245QxQL4J/OwtgcGOm7LkMbHRALaVC1ZRFoTPB1Qc=; b=eLZjRBLoHWq00dqOud3nDGwD3 y7VMya8XTF+PO8G4WyBdwiMG4rn9UbJBDheM7OcYXbTmdhg40JrBbn9agGNpHZeJk6J22hgwmH9xS fV5gGWM91yshxsXBJ83X/is1+qHGB8S47T3OoWqdWHOzbDJjNtcxNHNa0J35CHsWXfrF80tL2JxyV HCxzd64eVo7a9EhbT0vjgBDqsS8qx5kqERdiCXILtj52+tp72GRuBkCFy40poleqDIYAvhXClCRqI iE3K4OdK6EtnHqcmEuI/HQVbLjHSA+c6XZ3ES5ZT5UUl743BoO4hOgbL4TlrrVsxqTVGXYkxbQRW2 U8j7DuzgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVuvu-0007e4-JM; Fri, 23 Oct 2020 11:08:30 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVuvs-0007dO-8W for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2020 11:08:28 +0000 Received: by mail-ed1-f67.google.com with SMTP id o18so1144874edq.4 for ; Fri, 23 Oct 2020 04:08:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y2vpKPxhmwelF3MsVDfZZeRPwKr78dCwggVY3DuvCGU=; b=pWdXRmx6E4Freh0avuyBSdG6oP9t5FpbzlU82WywdrNjMlbGkUjveb+hY4lqrWgmke WBINtRuSbGRJmDhOehdObfP8IOvM3JHdJDgQbhRaXpRmt+rDdSIWFRpezVtMJoHv2IKl NFD56XM9ls2ZQOA0KJ+Kfjyv+2p+rhcfYFbLJLT2VNV89A+sU4zC/lNnKiYqSLd71YUo tAa1pACAfd8nBrtINQdaFGqJRIS6TqZbgPTQcS5ujoWMNRVbte5D7Iqgc8WgU0rR6GRs d6XkbdYs1VMq2xWWLzFmP/rsWnmqrfmD0HiqkPFXXJ5jhNwIc0TBeArn3zZ75/UCuVMg jGig== X-Gm-Message-State: AOAM533A8Sun731RIXA8AM9bsW1qooY6URcX1fhpObKtU6gP6iRRrPIz KQ/Zh0KCcgEfvDSJDLLFLUE= X-Google-Smtp-Source: ABdhPJz2CPrp1rxXN84/WklOzCcpaQV91ekIZAOzbOGw3tsPlRawVKASz4NbbpELicciI3QZgD9IlA== X-Received: by 2002:a05:6402:1d2c:: with SMTP id dh12mr1552246edb.256.1603451306893; Fri, 23 Oct 2020 04:08:26 -0700 (PDT) Received: from kozik-lap ([194.230.155.171]) by smtp.googlemail.com with ESMTPSA id h26sm587188edr.71.2020.10.23.04.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 04:08:25 -0700 (PDT) Date: Fri, 23 Oct 2020 13:08:23 +0200 From: Krzysztof Kozlowski To: Adam Ford Subject: Re: [PATCH 4/4] arm64: dts: imx8mn: Add power-domain reference in USB controller Message-ID: <20201023110823.GA48162@kozik-lap> References: <20201022150808.763082-1-aford173@gmail.com> <20201022150808.763082-5-aford173@gmail.com> <20201023095518.GF42872@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201023_070828_340110_CBEFDB41 X-CRM114-Status: GOOD ( 28.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree , Andrey Smirnov , Fabio Estevam , Sascha Hauer , Adam Ford-BE , Linux Kernel Mailing List , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , arm-soc , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 23, 2020 at 06:03:32AM -0500, Adam Ford wrote: > On Fri, Oct 23, 2020 at 4:55 AM Krzysztof Kozlowski wrote: > > > > On Thu, Oct 22, 2020 at 10:08:07AM -0500, Adam Ford wrote: > > > The USB OTG controller cannot be used until the power-domain is enabled > > > unless it was started in the bootloader. > > > > > > Adding the power-domain reference to the OTG node allows the OTG > > > controller to operate. > > > > > > Signed-off-by: Adam Ford > > > > > > > I wonder, why your patches do not have usual Git trailer with summary of > > changes (after '---')? > > I historically have just done 'git format-patch -pX' but I haven't > seen complaints that the summary was missing. I can add them going > forward. Most of these individual patches have only touched single > files or created new files all together. The patch stat is useful, especially if it touches multiple files/subsystems. However it's not needed, so I was just wondering :) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > index 27733fbe87e9..605e6dbd2c6f 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > > > @@ -979,6 +979,7 @@ usbotg1: usb@32e40000 { > > > assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_500M>; > > > fsl,usbphy = <&usbphynop1>; > > > fsl,usbmisc = <&usbmisc1 0>; > > > + power-domains = <&pgc_otg1>; > > > > I guess you need it also for the usbphynop1 and usbmisc1. > > From what I can see looking at the IP blocks and the vendor's code > repo, only the usbotg IP block needs the power-domain to enable the > clocking going to it. AFAICT, neither the usbphynop nor the usbmisc > are using clocks gated by the power-domain. > Thanks again for all your reviews. Mhm, ok then. Thanks for checking. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel