From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83BBCC388F9 for ; Fri, 23 Oct 2020 11:18:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3184B207BB for ; Fri, 23 Oct 2020 11:18:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bxtvunHW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3184B207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fAqH2nzeCJYozf8J17mhY2l9n/zLtKoysec0uxD7nWY=; b=bxtvunHWIGIJ1iBb2Y1E0168y cEYS5/jaQpGmduW7JvKbjNtNqdagcUIqhcgHMEyz7hR1SKXOGw/BeWw6+BLsgxbRmFgCqxqkHckgb BpwTWJZk94u+VGQYnWzXQZqQQF1ZlZq9tUhqG3C01oyGe3BoOBm7gR5fpz3shihPvYOAAlyM5LNUj Lyc/HAPIbd247XuFAA31yXDADQU80TU7uhXkMEg8Nfnsau/30RI7WejcNjsSGcCKV2HcrazJD1OpK wO4Y7s4WXuGV+TNCB6PtjbgPgHqf40W8s3jSYL9nqgSPPetjkh5OEA+DOSqD755zvN55g/mBG0kwB pB8U9NUzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVv3n-0008WV-IL; Fri, 23 Oct 2020 11:16:39 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVv3k-0008W5-Ry for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2020 11:16:37 +0000 Received: by mail-ej1-f65.google.com with SMTP id p5so1860071ejj.2 for ; Fri, 23 Oct 2020 04:16:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I7tXxZpGoreg85HA0VUxkudPh8npM8uC5nLxLgLNurw=; b=sne93ytPirLvkZzQO0Cs3wEHHVksSkOVXoy9m3642XZ8vDfkuAf4zbwK3bKQlUQHSf VrZLId138bWJNY8Y3NhRgexQC3t7ZJIlCsXmX7vkfnCmliXNYzarKjw+U1hpPpxkNcdY XvClLg1vmbsSnvVzBLqUry5IXY4s4D+r3/wUd+eKvjW3ZeeHFZxEQ5NjlKGvu//pjudy gSo+aahC4pXIALWU6+on81HXwYnWg8+0wFO1OwpBtcUKbCNxYyg+lqP+3d3+RdLwCcOG oee909xRNrqfblyp3bax/m4cgWSObi4VpwZJEu8RNr3KyfgvH2nhKe4EbdUChW8JjdUy Pukg== X-Gm-Message-State: AOAM532PlrAT5sM5vRvuJ7I43QQ7H5ZUP3M4qU1iyLo8gm8sZjCGZGav 7362DwPIOX8CsJAVR2NC5wY= X-Google-Smtp-Source: ABdhPJzoA3+2dyw0HIdiALYHcsoNfM039rsAqi/Wc+Hi2TMGcbUlUhwbDTGeU1VWf0IsmpGbG0mD6Q== X-Received: by 2002:a17:906:a04c:: with SMTP id bg12mr1373658ejb.317.1603451795423; Fri, 23 Oct 2020 04:16:35 -0700 (PDT) Received: from kozik-lap ([194.230.155.171]) by smtp.googlemail.com with ESMTPSA id ao17sm666245ejc.18.2020.10.23.04.16.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 04:16:34 -0700 (PDT) Date: Fri, 23 Oct 2020 13:16:32 +0200 From: Krzysztof Kozlowski To: Adam Ford Subject: Re: [PATCH] arm64: dts: imx: Add Beacon i.MX8M Nano development kit Message-ID: <20201023111632.GB48162@kozik-lap> References: <20201022165751.771695-1-aford173@gmail.com> <20201023094437.GB42872@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201023_071636_935313_64D78BDE X-CRM114-Status: GOOD ( 28.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Fabio Estevam , Sascha Hauer , Adam Ford-BE , Linux Kernel Mailing List , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 23, 2020 at 05:51:56AM -0500, Adam Ford wrote: > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts > > > new file mode 100644 > > > index 000000000000..faa55d888065 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts > > > @@ -0,0 +1,19 @@ > > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > > +/* > > > + * Copyright 2020 Compass Electronics Group, LLC > > > + */ > > > + > > > +/dts-v1/; > > > + > > > +#include "imx8mn.dtsi" > > > +#include "imx8mn-beacon-som.dtsi" > > > +#include "imx8mn-beacon-baseboard.dtsi" > > > > Why do you need baseboard as DTSI? Is is separate than kit? Judging by > > contents look like just empty/fake DTS and the baseboard should be the > > DTS. > > > > Another hint: Baseboard also does not have its compatible, so it cannot > > exist in real life separate from the development kit... > > The baseboard can handle two separate, mutually exclusive video > outputs. It has a LVDS bridge chip and an HDMI bridge chip, but > without the DSI and LCDIF support, neither can function. > Right now, that LVDS chip doesn't have an upstream driver, but I plan > to introduce it once the LCDIF, and DSI interfaces are available and > functional. > > Once there is video support, the kit-level DTS file will get support > for one of the video outputs, and a second DTS file will get created > to support the other. Both of these kit-level files would include the > baseboard and SOM DTSI files since they would be common to both kits. Sounds good. > > > > + > > > +/ { > > > + model = "Beacon EmbeddedWorks i.MX8M Mini Development Kit"; > > > + compatible = "beacon,imx8mn-beacon-kit", "fsl,imx8mn"; > > > > Undocumented compatible. > > I am still trying to learn the YAML rules. Do I just add it to the > fsl.yaml? 'beacon' is in the vendor-prefixes, but I looked and the > 'imx8mm-beacon-kit' which is already in the kernel doesn't have a > compatible either and they are virtually identical. Enough will be adding it to the fsl.yaml. There is no strict need for separate compatible for baseboard, although that's quite common practice since you want to reuse it. The beacon,imx8mm-beacon-kit is in fsl.yaml, so you can just duplicate for imx8mn. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel