From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0582C4363A for ; Fri, 23 Oct 2020 14:00:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D561208C3 for ; Fri, 23 Oct 2020 14:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PUuJM7td" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D561208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ztl5HcbNKKarDERhNvGSBx3RSlYXHLuhlVnsGIrw2Mg=; b=PUuJM7tdUjfYmg1H5cKRhgrsK /Gnk0pkpc41pBhrRNGCsrNFl0rdcr+taWOSmRk6tJW8iL1hmO/VEvvEUkmMuFY9KwSJvgxetuDy4Z AdsLZeKMrnK/hKBD96gdUMiO35jB5k9b3Gynu6tzybFq7JVS0DPJL7fSvbX0rQdysBTjJYQy4bNv5 tu8w8T4bwtUx68HEn8VRi51nu2W/6o+rE4WeomeoiLwVGAPqHNtZrO0knOHi0VgPva/VGSD7QJ5Cc 3bnpVdaJ8Pqu6lw21KuF9kyL1uk3YFpw5VO81Zo6P68JavqBCZQ4dXgZKQiufuyRc5STA/FIGKBOf DusAdn05g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVxb6-0000iw-Hb; Fri, 23 Oct 2020 13:59:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVxb4-0000iM-72 for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2020 13:59:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BFE69113E; Fri, 23 Oct 2020 06:59:08 -0700 (PDT) Received: from bogus (unknown [10.57.15.80]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 20BEA3F66B; Fri, 23 Oct 2020 06:59:06 -0700 (PDT) Date: Fri, 23 Oct 2020 14:59:04 +0100 From: Sudeep Holla To: Rob Herring Subject: Re: [PATCH v2 1/2] dt-bindings: arm, scmi: Do not use clocks for SCMI performance domains Message-ID: <20201023135904.ayqznoxocxsvwl6v@bogus> References: <20201021183104.27949-1-sudeep.holla@arm.com> <20201022182233.hklq6j5n5kkqg4yv@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201023_095910_322736_AEB4CEC5 X-CRM114-Status: GOOD ( 25.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Viresh Kumar , "linux-kernel@vger.kernel.org" , linux-arm-kernel , Sudeep Holla Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 23, 2020 at 08:24:06AM -0500, Rob Herring wrote: > On Thu, Oct 22, 2020 at 1:22 PM Sudeep Holla wrote: > > > > On Wed, Oct 21, 2020 at 07:31:03PM +0100, Sudeep Holla wrote: > > > Commit dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return > > > -EPROBE_DEFER") handles -EPROBE_DEFER for the clock/interconnects within > > > _allocate_opp_table() which is called from dev_pm_opp_add and it > > > now propagates the error back to the caller. > > > > > > SCMI performance domain re-used clock bindings to keep it simple. However > > > with the above mentioned change, if clock property is present in a device > > > node, opps can't be added until clk_get succeeds. So in order to fix the > > > issue, we can register dummy clocks which is completely ugly. > > > > > > Since there are no upstream users for the SCMI performance domain clock > > > bindings, let us introduce separate performance domain bindings for the > > > same. > > > > > > Signed-off-by: Sudeep Holla > > > --- > > > .../devicetree/bindings/arm/arm,scmi.txt | 19 ++++++++++++++++--- > > > 1 file changed, 16 insertions(+), 3 deletions(-) > > > > > > v1[1]->v2: > > > - Changed the generic #perf-domain-cells to more SCMI specific > > > property #arm,scmi-perf-domain-cells > > > > > > > Is more specific #arm,scmi-perf-domain-cells acceptable ? > > Sorry for the rush, but this fixes SCMI cpufreq which is broken after > > commit dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return > > -EPROBE_DEFER") > > If you are in a rush, you'd better go the dummy clock route. We should > get this binding right and I think that means something common, not > SCMI specific. > Ah OK, I assumed you wanted to make it SCMI specific. It makes sense to have something generic like clocks for OPP domains. There was discussion on the other thread to use empty OPP list for firmware discoverable OPP list. Random thought here is to add domain ID to OPP binding and use that ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel