From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC1BBC388F9 for ; Fri, 23 Oct 2020 20:39:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BA4920878 for ; Fri, 23 Oct 2020 20:39:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rdhf1cGx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YQ+zi25/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BA4920878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jSnv6eInTv/9k69ZRaqbxbC3S841dis/6/J6iU+WUBs=; b=rdhf1cGxaT8Tu6dQdDAynpXlk 4PgzDJBt7zg8itAHu55sR0vFy7eUA8p1I9f4DUlghPpJctAl5tLdw+vvem7kWlEyqqsggK15dh1V6 xvt48K/zqTuv8Dkm9dT8Gq7UVZ8us73GXJ0/DDDTdUrfi/e804pzDBLPRCeHF9EXXqQGSwAOtzmzg E/F1uT+Mcm7UsGYUeElNOwnGLfxXa3dptJ+gXPhYY1KiOZxOIMQWHXF7VVK1xwowfrosMy8ZYybb3 7LLyHRNvRbGcU8UDCJDMhCdAnPo7mhx62IUOcy2vOWxEtEhPF6Ts3kOEq5LRdsJZr9GHCNoCLYvO6 rLI596uRQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kW3og-0007MT-MG; Fri, 23 Oct 2020 20:37:38 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kW3od-0007LX-Cp for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2020 20:37:37 +0000 Received: by mail-pl1-x641.google.com with SMTP id t22so1588541plr.9 for ; Fri, 23 Oct 2020 13:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CGGzYJFzvaAClgoRLNesvAoSeLjys7jFkN1Zjf9m1Mg=; b=YQ+zi25/jTA5S0YJD+eHWDE4qmiYDzQKrABHi4pdtuJsUIeyaRHwjp5l1TrhwJQyGt CJ8iMpPENPDlPNsAjIFBhS2wa0pK9Dt30CifMlddAjdoNOAV8OZQfFG4ZMY47Tb+3XyJ pR9Zz6mLi39wlcO/FSWM6qT9eXxzZ6DuF/gMqua1qjRi9reky7ZHkW+KM3VXy5oZwcX5 gdKkthNHczliC1MZKI/uUSkP6QHBsxMVHjQIFHEZNGsr8bXI3tgxMh8LzgGvX6j1PgDq PDsr5cSlaJDlSDwwodCMYo5RTHEgYjzOt91miZwg02NAQKkkEQc1Xb92LjFOpiUF2O2a OPDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CGGzYJFzvaAClgoRLNesvAoSeLjys7jFkN1Zjf9m1Mg=; b=c9pa8qjtG11TEHf9UOnsktS7sWL7WKne2kb+qGpOw2bI71txZGYGAJMmaGFT5NLZBc YWVXrTDcJmsZySPrvLwE3bhukHh6/8PEfrtqJjLVEWUEBBK8KO8WxF1191g2q3bUOMvJ 6g+3aipxEe9OoG7/siNyHfPPtLk3ULtHFkmnr5PsQR3Uu8Gsj9c25lDPSYonKSiPStz2 x+A+0u/aUBS8KhKpsCvoNGcH65Lc7uv/NTGo17IjXnNL6X1ay1n4eLQ3zJ6ll7Mq2oqf iYLU3hgoPLDbtInmwIg+L7WQxkdAZbIhIH11MyfQbo757F9N/As08At2auSJ6cbXNOm+ NIVA== X-Gm-Message-State: AOAM532SArUHm061QpOAGj7pvAfM04lJl2Jl5y2sLFAHZ29luig1LrAf AbgmbtVT0Dz6gnbHoJIfjKU0Og== X-Google-Smtp-Source: ABdhPJwuZEiGe28KTMKDAU/MsHgXJUs+YHE+Shscfvekf1Trif4cZAlWPZevIE9oKRHF7mHoEUnvEw== X-Received: by 2002:a17:902:ba96:b029:d5:f36b:44af with SMTP id k22-20020a170902ba96b02900d5f36b44afmr654523pls.51.1603485453114; Fri, 23 Oct 2020 13:37:33 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id q4sm2874788pgj.44.2020.10.23.13.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 13:37:31 -0700 (PDT) Date: Fri, 23 Oct 2020 14:37:29 -0600 From: Mathieu Poirier To: Peter Zijlstra Subject: Re: [PATCHv2 2/4] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf() Message-ID: <20201023203729.GA819775@xps15> References: <20201022212033.GA646497@xps15> <20201023073905.GM2611@hirez.programming.kicks-ass.net> <174e6461-4d46-cb65-c094-c06ee3b21568@arm.com> <20201023094115.GR2611@hirez.programming.kicks-ass.net> <20201023105431.GM2594@hirez.programming.kicks-ass.net> <2457de8f-8bc3-b350-fdc7-61276da31ce6@arm.com> <20201023131628.GY2628@hirez.programming.kicks-ass.net> <728fd89c-78f2-0c5c-0443-c91c62b02f0e@arm.com> <20201023134416.GA2628@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201023134416.GA2628@hirez.programming.kicks-ass.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201023_163735_858281_C0E6FBF9 X-CRM114-Status: GOOD ( 26.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Sai Prakash Ranjan , Suzuki Poulose , Alexander Shishkin , linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Stephen Boyd , Ingo Molnar , Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 23, 2020 at 03:44:16PM +0200, Peter Zijlstra wrote: > On Fri, Oct 23, 2020 at 02:29:54PM +0100, Suzuki Poulose wrote: > > On 10/23/20 2:16 PM, Peter Zijlstra wrote: > > > On Fri, Oct 23, 2020 at 01:56:47PM +0100, Suzuki Poulose wrote: > > > > > That way another session could use the same sink if it is free. i.e > > > > > > > > perf record -e cs_etm/@sink0/u --per-thread app1 > > > > > > > > and > > > > > > > > perf record -e cs_etm/@sink0/u --per-thread app2 > > > > > > > > both can work as long as the sink is not used by the other session. > > > > > > Like said above, if sink is shared between CPUs, that's going to be a > > > trainwreck :/ Why do you want that? > > > > That ship has sailed. That is how the current generation of systems are, > > unfortunately. But as I said, this is changing and there are guidelines > > in place to avoid these kind of topologies. With the future > > technologies, this will be completely gone. > > I understand that the hardware is like that, but why do you want to > support this insanity in software? > > If you only allow a single sink user (group) at the same time, your > problem goes away. Simply disallow the above scenario, do not allow > concurrent sink users if sinks are shared like this. > > Have the perf-record of app2 above fail because the sink is in-user > already. I agree with you that --per-thread scenarios are easy to deal with, but to support cpu-wide scenarios events must share a sink (because there is one event per CPU). CPU-wide support can't be removed because it has been around for close to a couple of years and heavily used. I also think using the pid of the process that created the events, i.e perf, is a good idea. We just need to agree on how to gain access to it. In Sai's patch you objected to the following: > + struct task_struct *task = READ_ONCE(event->owner); > + > + if (!task || is_kernel_event(event)) Would it be better to use task_nr_pid(current) instead of event->owner? The end result will be exactly the same. There is also no need to check the validity of @current since it is a user process. Thanks, Mathieu [1]. https://elixir.bootlin.com/linux/latest/source/kernel/events/core.c#L6170 > > Only if the hardware has per-CPU sinks can you allow this. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel