From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D76C4363A for ; Sat, 24 Oct 2020 19:29:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BE4F22276 for ; Sat, 24 Oct 2020 19:29:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AUwqUyoX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BE4F22276 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y/iYbK1MU4lFNHgh1bhpM7E8K+npFqCbsphTwfA91Rk=; b=AUwqUyoXESfLmmi9UummHvV4r 7Gbk8u4khdEFKSl+ZONN1vxzpoubcdO4D5UKU1bK9mXmJpZOYIKZqzujOsBIV5cUS9W7rZSksHtZr iRKesws+4HTO3jHCrAnioK6RRK+aVsV1z2jbSUEIbWagAadF5ZRlgPqrpHrprEihZkV3gs+mAVH5I uSdiduVUDUn9NH6GYpQB36Y7xdN6Pe1Dt3mstLH4MDTM196AAhoGv8veKvLXxRTsCmiGJzQ/r8y0C uSTtx1B21VqBg8mKYuoH+zEip1+nku2KkrKOPMYE5BMAXHUpss1UlvH1bLWYo0DHgA7XJKXtX1qhn Eayspn7rQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWPDZ-0000oh-3k; Sat, 24 Oct 2020 19:28:45 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWPDX-0000oG-CV for linux-arm-kernel@lists.infradead.org; Sat, 24 Oct 2020 19:28:44 +0000 Received: by mail-ed1-f68.google.com with SMTP id p13so5068478edi.7 for ; Sat, 24 Oct 2020 12:28:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e4VBZrIVbXA5K5+1xS8Vj2wOcFTF1ErdEn+41O+kAnI=; b=RgQMMeBJNThJVnYB5lg21RbYxUw+T2+gHMBc+d2DBntxeCBc8kFTSvgMTwF/JA9CYb /lwZ2qkGjGiHXSdOZaSsbKTCmVhitfxvOl66uXFoyAD82hB4s+w8kZXrB/ACQxl0sC6w DokRxhHC31MzNsb/DLCnkjqdXkp0UrOAnGWk4TwdXqda8dQ3cpqnoQ3kJpyaVFaKexWQ KBlJJkZmERWRa9VEzfRveRCp+dvC85wMlQjMsV3umXx6ChfeSN4Dt74XlobufnBdDf/5 FwKkD2wcJkA1ih6UmaBERXKXUvIx/yOrolU/ey0a6uYVg4RmJpzK8wQ5xksbblwnPdUW CP/Q== X-Gm-Message-State: AOAM5334OEx6Ip7ZyUWIXywP5/8UULrcFoMOxIwCAItJ6Ek/lmgZW9aN UF9pp5L3RPORBXPA83ic30Y= X-Google-Smtp-Source: ABdhPJyRoEAbypDQg0qtaAsbMF+T7hVlpTz9RCVWfQQu8jR7NTFcNbptSFnllzrrpdcbVbtXrbx9Sg== X-Received: by 2002:a50:9e82:: with SMTP id a2mr8219658edf.117.1603567722004; Sat, 24 Oct 2020 12:28:42 -0700 (PDT) Received: from kozik-lap ([194.230.155.174]) by smtp.googlemail.com with ESMTPSA id 22sm2746047ejw.27.2020.10.24.12.28.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Oct 2020 12:28:40 -0700 (PDT) Date: Sat, 24 Oct 2020 21:28:38 +0200 From: Krzysztof Kozlowski To: Peng Fan Subject: Re: [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify code Message-ID: <20201024192838.GB4638@kozik-lap> References: <1603441103-17735-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201024_152843_462084_BFA6FA84 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 24, 2020 at 07:39:47AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH 1/2] i2c: imx: use devm_request_threaded_irq to simplify > > code > > > > On Fri, 23 Oct 2020 at 10:27, wrote: > > > > > > From: Peng Fan > > > > > > Use devm_request_threaded_irq to simplify code > > > > > > Signed-off-by: Peng Fan > > > --- > > > drivers/i2c/busses/i2c-imx.c | 10 +++------- > > > 1 file changed, 3 insertions(+), 7 deletions(-) > > > > > > diff --git a/drivers/i2c/busses/i2c-imx.c > > > b/drivers/i2c/busses/i2c-imx.c index e6f8d6e45a15..ba9d639223ec 100644 > > > --- a/drivers/i2c/busses/i2c-imx.c > > > +++ b/drivers/i2c/busses/i2c-imx.c > > > @@ -1216,8 +1216,8 @@ static int i2c_imx_probe(struct platform_device > > *pdev) > > > goto rpm_disable; > > > > > > /* Request IRQ */ > > > - ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED, > > > - pdev->name, i2c_imx); > > > + ret = devm_request_threaded_irq(&pdev->dev, irq, i2c_imx_isr, > > NULL, IRQF_SHARED, > > > + pdev->name, i2c_imx); > > > > Really? You silently revert commit e50e4f0b85be ("i2c: imx: Fix external abort > > on interrupt in exit paths"). This is not a simplification but serious change. NAK. > > At least without proper reasoning of why this is suddenly safe. > > Oh, I need look at git history before. But > Is it because i2c interrupt enabled too early? I'll try your case on i.MX8M platform. Shortly, it is because shared interrupts do not go well or at all with devm-managed interrupt handlers. Probably they could be made working with additional code, e.g. devm_free_irq() call or some additional checks in interrupt handlers. But in that case there won't be much of simplification. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel