From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11075C2D0A3 for ; Sat, 24 Oct 2020 19:59:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E0EF21D41 for ; Sat, 24 Oct 2020 19:59:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dNna65tY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kfs3KwQI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E0EF21D41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V/4zkWf3GtkQ0ry+rsclw1VYpI2hHIqdSCYlRq8pPSw=; b=dNna65tYVtGDsBrtDKaSbLaJ8 7gqEJN0+36wuCHtPIjPomtl5qmlcpRz/3tYhHuj3GwgGI4MKMfwIC1CntK4EOreuYDtPQkQE5o5pH n+vIeoAYP92TbzkNgiLcHsO3gOD8jjKs8Xn+1e578ZWrSvwWqP9eKfyUV0IL+le7ti39snohcWUta wN0w+AA0sFBwcvU6D+izyK5h7ZYqlpg4Hd//3X9fSl0pZ7qy+04gzJYKjhvLqOYjxEJfsSVmlYycu Cx9SIQrNtWe74SH6kFqL1dOnuPYToDZAAZFSzXJryjrjYjJN5APDDYqaFbrEITuqFARX46Z0SCg6U r9UB0lvDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWPg3-0002cI-UQ; Sat, 24 Oct 2020 19:58:12 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWPg0-0002bi-KV for linux-arm-kernel@lists.infradead.org; Sat, 24 Oct 2020 19:58:09 +0000 Received: by mail-wm1-x343.google.com with SMTP id w23so5083274wmi.4 for ; Sat, 24 Oct 2020 12:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yI7DQlIbMqrUzjgEWDyjjKv7eTTNrYda8KbimVLIc34=; b=Kfs3KwQIv5oHHLZBxh0f7hx0NVJopMhp1MJXOke5qWjomNYbc9aCSK+m+heDKCf/mg s4L5wdwcIZB0V9GsKDNm50n5XVHN81Hs+//PqrXlr3B3Gnv0Ai3IlD9ToxhbOB7NRuUV xhl7oYwnhEvF4PoHPPyQ1ihzVCFt+gUeJ7zeosJrTlP8nD2YMJiEROoSd958jXIKu/xR EKluP+G5tCGD2efi+WbX2Uw2D2JmbaAqThRVEtWqiH32AQ6bFzyiE26Y6c1hY0ex8u8V IMVN8PDVjUaJS1gYUp/12+dw69NiVAgJacs+pVPNAGSrr2Fiyt6KYR1BxBEqb5UN7YOv eyew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yI7DQlIbMqrUzjgEWDyjjKv7eTTNrYda8KbimVLIc34=; b=LdcKzJH+Yn8MOSeAc/PgHQhCfsOpegxK15MafcOqbFdoWrFtdIUS9A4bFQJaNQRTAF sde14b6D1b/EAdAkURlQjCOjICecl0kILjNzwdu5mMe0jRSXCmpyRDCAhUkaP1+LT799 hEz3wCNdNyH9rZnZ24Gty8CHwNIQ2QAgFPcGLmSbrdNBeDwuajz34KnfqsD1Fal/7j2+ KvST2eTYOmPWflo9BbM8r5zkQbT01zLOYFIr6/0cmgKWBLp3ACaRQIf1Sbtw8VtJhH+R N3mgo7NRYcmvfXodlQLqbcaT5yoXJygMTvX5UfFkMGbbNLhK5S4DZLTERiv/9+LcQEUX 5QvQ== X-Gm-Message-State: AOAM531XF2ZKe8FRIAwdwGIXbyqof9YUZyxxntriWzZv7wp5ERQzWcfk S+/UgH4k7QUZStU5bmgFNxw= X-Google-Smtp-Source: ABdhPJyrPbPLmcv1UVjJniX/1N6rypikoOlIc4kvJZnYMxhNeDIecThfOdFEaXW5slBdlVe1YUw00w== X-Received: by 2002:a1c:a3c2:: with SMTP id m185mr8189575wme.161.1603569485953; Sat, 24 Oct 2020 12:58:05 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id v6sm11564319wmj.6.2020.10.24.12.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Oct 2020 12:58:05 -0700 (PDT) Date: Sat, 24 Oct 2020 21:58:03 +0200 From: Corentin Labbe To: Chen-Yu Tsai Subject: Re: [linux-sunxi] [PATCH 10/10] arm64: dts: allwinner: a64: bananapi-m64: Enable RGMII RX/TX delay on PHY Message-ID: <20201024195803.GA30672@Red> References: <20201024162515.30032-1-wens@kernel.org> <20201024162515.30032-10-wens@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201024162515.30032-10-wens@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201024_155808_794579_D0527FA4 X-CRM114-Status: GOOD ( 19.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , linux-sunxi@googlegroups.com, Maxime Ripard , linux-kernel@vger.kernel.org, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 25, 2020 at 12:25:15AM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > The Ethernet PHY on the Bananapi M64 has the RX and TX delays > enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins. > > Fix the phy-mode description to correct reflect this so that the > implementation doesn't reconfigure the delays incorrectly. This > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > rx/tx delay config"). > > Fixes: e7295499903d ("arm64: allwinner: bananapi-m64: Enable dwmac-sun8i") > Fixes: 94f442886711 ("arm64: dts: allwinner: A64: Restore EMAC changes") > Signed-off-by: Chen-Yu Tsai > --- > arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > index 3ea5182ca489..e5e840b9fbb4 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > @@ -105,7 +105,7 @@ &ehci1 { > &emac { > pinctrl-names = "default"; > pinctrl-0 = <&rgmii_pins>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-id"; > phy-handle = <&ext_rgmii_phy>; > phy-supply = <®_dc1sw>; > status = "okay"; > -- > 2.28.0 Tested-by: Corentin Labbe Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel