From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8135FC388F7 for ; Sun, 25 Oct 2020 16:36:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28B6420878 for ; Sun, 25 Oct 2020 16:36:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XPhsxjuP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28B6420878 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TtfE3lj4sVDjIGLSir1qPx1amxZ83lWgwtaKc1waMbg=; b=XPhsxjuPQ7OW6YMwixoHu9Voz vHqmWPx+4+Y1Xy/Gx4ms2N7fc6BhED6WOqEDrLhkmpEt0lAjRq0ZrtKuJpR0812ZDv1GEcK0pAN2l lORErUMvfUCg11FMqu5dpshFb1dgtHqJKGYaGS1mxSNYyP8Y9J7JC+pg62Qem0GO/cG0eKehxE5b1 x/OwfNInWTNIilASHBIcHDgUntFKDd+ymFafxgGXDGEWAWIlh+CKO/SoJPO1Db9z/NZASKw1qfXLi zPScHr/6Fa4MLw0sdFjfvx3CDcONebL807M8/GYPhX1Aj7YblKGOvbVCEruzUZt2uHhJyqQ5bpmub mgiLh/rEA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWiye-0005pj-Fj; Sun, 25 Oct 2020 16:34:41 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWiyc-0005pN-6I for linux-arm-kernel@lists.infradead.org; Sun, 25 Oct 2020 16:34:39 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kWiyT-003Rel-U3; Sun, 25 Oct 2020 17:34:29 +0100 Date: Sun, 25 Oct 2020 17:34:29 +0100 From: Andrew Lunn To: Adam Sampson Subject: Re: [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY Message-ID: <20201025163429.GH792004@lunn.ch> References: <20201025140144.28693-1-ats@offog.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201025140144.28693-1-ats@offog.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201025_123438_313089_C3613292 X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 25, 2020 at 02:01:44PM +0000, Adam Sampson wrote: > The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano > are configured in hardware, using resistors that are populated to pull > the RTL8211E's RXDLY/TXDLY pins low or high as needed. > > phy-mode should be set to rgmii-id to reflect this. Previously it was > set to rgmii, which used to work but now results in the delays being > disabled again as a result of the bugfix in commit bbc4d71d6354 ("net: > phy: realtek: fix rtl8211e rx/tx delay config"). > > Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix, > Ethernet works unreliably on one board and doesn't work at all on the > other. > > Fixes: 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board") > Signed-off-by: Adam Sampson Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel