From: Shawn Guo <shawnguo@kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marek Vasut <marex@denx.de>,
Arulpandiyan Vadivel <arulpandiyan_vadivel@mentor.com>,
Anson Huang <b20788@freescale.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH] [RFC] ARM: imx: add smp support for imx7d
Date: Mon, 26 Oct 2020 17:18:17 +0800 [thread overview]
Message-ID: <20201026091816.GI9880@dragon> (raw)
In-Reply-To: <d0fed022-b0c0-d804-8a9c-ea17cc58e821@siemens.com>
On Tue, Sep 22, 2020 at 04:59:44PM +0200, Jan Kiszka wrote:
> On 22.09.20 13:34, Marek Vasut wrote:
> > On 9/22/20 8:27 AM, Shawn Guo wrote:
> > > On Tue, Sep 22, 2020 at 2:22 PM Shawn Guo <shawnguo@kernel.org> wrote:
> > > >
> > > > On Thu, Sep 17, 2020 at 06:08:14PM +0200, Marek Vasut wrote:
> > > > > From: Anson Huang <b20788@freescale.com>
> > > > >
> > > > > Add SMP support for i.MX7D, including CPU hotplug support, for
> > > > > systems where TFA is not present.
> > > >
> > > > These systems are not supported by upstream kernel. Sorry.
> > >
> > > I meant for systems without PSCI support actually.
> >
> > Is there any specific reason for that ?
> >
> > The SoC works fully well with mainline U-Boot and without TFA, except
> > the code for bringing up the second core is missing from mainline and
> > that is all that is missing. PSCI is unnecessary extra complexity here.
> >
>
> We are coming from vendor kernels and would like to base our products on
> mainline for $countless-good-reasons. With the vendor kernels, this
> "classic" way of booting worked fine, with historic bootloaders and also
> with current mainline U-Boot.
>
> If PSCI support is mandated, we would now be unable to migrate devices in
> the field that should not or cannot receive a bootloader update because
> existing deployments generally do not ship TF-A or any other PSCI
> implementation on ARMv7 - there was mostly no use for it (and there will
> likely be none, except for CPU onlining). Would be a shame.
Thanks for sharing such user story that we would love to hear. We like
such transition from vendor kernel to upstream for sure. I would hope
my upstream maintainers would also agree this is a worthy compromise.
I will try to help get this in.
> So I'd also like to understand what speaks against a merge, provided this
> patch does not break other cases or make the code significantly more complex
> and harder to maintain.
The patch itself is indeed not a maintenance burden. What scares me is
the suspend and idle code in vendor kernel, which we hope that PSCI can
take care of for upstream kernel. For record, I reserve the right to
say NO to those code even if we get this patch in :)
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-26 9:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 16:08 [PATCH] [RFC] ARM: imx: add smp support for imx7d Marek Vasut
2020-09-22 6:22 ` Shawn Guo
2020-09-22 6:27 ` Shawn Guo
2020-09-22 11:34 ` Marek Vasut
2020-09-22 14:59 ` Jan Kiszka
2020-10-10 0:28 ` Laurent Pinchart
2020-10-12 12:42 ` Fabio Estevam
2020-11-16 9:10 ` Laurent Pinchart
2020-11-16 19:52 ` Fabio Estevam
2020-11-17 5:48 ` Anson Huang
2020-11-17 7:19 ` Jan Kiszka
2020-10-26 9:18 ` Shawn Guo [this message]
2020-10-10 0:26 ` Laurent Pinchart
2020-10-26 14:40 ` Shawn Guo
2021-01-07 12:09 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026091816.GI9880@dragon \
--to=shawnguo@kernel.org \
--cc=arulpandiyan_vadivel@mentor.com \
--cc=b20788@freescale.com \
--cc=festevam@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).