From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 624C5C4363A for ; Mon, 26 Oct 2020 09:55:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCB142087C for ; Mon, 26 Oct 2020 09:55:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q7CyBpGa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="u1FtUd1n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCB142087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v0Kcx/McDyruhpxMgl9ISWCxSM3tw3B7wgggCuwh7sI=; b=Q7CyBpGak/HwInPw3jYYfOky6 h258NULyy329fmBKDUFO+GRsHQUc8/bJ6RAEXqQBDdZV7bDtVfYz68iPX8R2A3ZM7xJUUpAuaZaCZ PyxJWIV2crnN+R81Zk1tHofakbbortEtwoxsldicinBydE71iKlP162umImMqNwUKVTg5vHM6aD5l 0r+4OdBhVZYJif2P081GU3iFCFyJSiViah66pMf/Z9Fzb2auGStn4nXkiNMls+Wypk2XXBIHjmjWz yxhwDu3jL0/SHpnpiFftX4PxBC58mhjoB4kvN26p2LgoF51YltIRY+KiSsk/xYsIpFH0mqyfWD2tK DQbHnGCuQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWzCj-00047N-6X; Mon, 26 Oct 2020 09:54:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWzCc-000455-RU for linux-arm-kernel@lists.infradead.org; Mon, 26 Oct 2020 09:54:12 +0000 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E4FD52087C; Mon, 26 Oct 2020 09:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603706049; bh=hreaVvnt+U1PFCi0QIABXsOnQuEkNKqJ/KyzQCAUOC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u1FtUd1n+AU2L3TQTvBJZIWjGH2bkz8tsfhrFJ1onw+kQRapnDmKC+E8/fEOcBjIm d2bqirQ10oYSRUr0g0y21B/Hh53BFyUKygj5LO+++91yG7G/ZxExoiYvkX1iHwECpJ rniitZDFeh5SJhYB07OmP4W4mfzhftUWl8hfzUuc= Received: by pali.im (Postfix) id 5163DA4B; Mon, 26 Oct 2020 10:54:06 +0100 (CET) Date: Mon, 26 Oct 2020 10:54:06 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Vladimir Vid Subject: Re: [PATCH v2] arm64: dts: marvell: add DT for ESPRESSObin-Ultra Message-ID: <20201026095406.2ulhjsvg7he2xuoq@pali> References: <20201023162110.265857-1-vladimir.vid@sartura.hr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201023162110.265857-1-vladimir.vid@sartura.hr> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_055411_145840_47C4699F X-CRM114-Status: GOOD ( 24.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tmn505@gmail.com, devicetree@vger.kernel.org, jason@lakedaemon.net, andrew@lunn.ch, gregory.clement@bootlin.com, a.heider@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello! On Friday 23 October 2020 18:21:11 Vladimir Vid wrote: > This adds support for ESPRESSObin-Ultra from Globalscale. > > Specifications are similar to the base ESPRESSObin board, with main > difference being being WAN port with PoE capability and 2 additional ethernet ports. > > Full specifications: > > 1x Marvell 64 bit Dual Core ARM A53 Armada 3700 SOC clocked up to 1.2Ghz > 1x Topaz 6341 Networking Switch > 1GB DDR4 > 8GB eMMC > 1x WAN with 30W POE > 4x Gb LAN > 1x RTC Clock and battery > 1x DC Jack > 1x USB 3.0 Type A > 1x USB 2.0 Type A > 1x SIM NanoSIM card Slot > 1x Power Button > 4x LED > 1x Reset button > 1x microUSB for UART > 1x M.2 2280 slot for memory > 1x 2x2 802.11ac Wi-Fi > 1x MiniPCIE slot for Wi-Fi (PCIe interface) > > Signed-off-by: Vladimir Vid > --- > > v2 changes: > > - added armada-3720-espressobin.dtsi include and updated dts > - updated model name > - renamed first partition from 'u-boot' to 'firmware' > - disabled usb3 node for the moment as it include usb2 references > > --- > arch/arm64/boot/dts/marvell/Makefile | 1 + > .../marvell/armada-3720-espressobin-ultra.dts | 161 ++++++++++++++++++ > 2 files changed, 162 insertions(+) > create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > > diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile > index 3e5f2e7a040c..094f451fdd1d 100644 > --- a/arch/arm64/boot/dts/marvell/Makefile > +++ b/arch/arm64/boot/dts/marvell/Makefile > @@ -3,6 +3,7 @@ > dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb > dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb > dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb > +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb > dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-v7.dtb > dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-v7-emmc.dtb > dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-turris-mox.dtb > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > new file mode 100644 > index 000000000000..87aaf620a171 > --- /dev/null > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts > @@ -0,0 +1,161 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Device Tree file for ESPRESSObin-Ultra board. > + * Copyright (C) 2019 Globalscale technologies, Inc. > + * > + * Jason Hung > + */ > + > +/dts-v1/; > + > +#include "armada-3720-espressobin.dtsi" > + > +/ { > + model = "Globalscale Marvell ESPRESSOBin Ultra Board"; > + compatible = "globalscale,espressobin-ultra", "marvell,armada3720", > + "marvell,armada3710"; > + You are missing there aliases section for correct MAC address assignment from bootloader. See: https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi?h=for-next https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts?h=for-next > + reg_usb3_vbus: usb3-vbus { > + compatible = "regulator-fixed"; > + regulator-name = "usb3-vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + enable-active-high; > + gpio = <&gpionb 19 GPIO_ACTIVE_HIGH>; > + }; > + > + usb3_phy: usb3-phy { > + compatible = "usb-nop-xceiv"; > + vcc-supply = <®_usb3_vbus>; > + }; > + > + gpio-leds { > + pinctrl-names = "default"; > + compatible = "gpio-leds"; > + /* No assigned functions to the LEDs by default */ > + led1 { > + label = "ebin-ultra:blue:led1"; > + gpios = <&gpionb 11 GPIO_ACTIVE_LOW>; > + }; > + led2 { > + label = "ebin-ultra:green:led2"; > + gpios = <&gpionb 12 GPIO_ACTIVE_LOW>; > + }; > + led3 { > + label = "ebin-ultra:red:led3"; > + gpios = <&gpionb 13 GPIO_ACTIVE_LOW>; > + }; > + led4 { > + label = "ebin-ultra:yellow:led4"; > + gpios = <&gpionb 14 GPIO_ACTIVE_LOW>; > + }; > + }; > +}; > + > +&sdhci0 { > + status = "okay"; > + non-removable; > + bus-width = <8>; > + mmc-ddr-1_8v; > + mmc-hs400-1_8v; > + marvell,pad-type = "fixed-1-8v"; > +}; This sdhci0 node looks like duplication of what is in include DTS file armada-3720-espressobin.dtsi. So it is really needed to specify it also again in armada-3720-espressobin-ultra.dts? > + > +&sdhci1 { > + status = "disabled"; > +}; > + > +&spi0 { > + flash@0 { > + spi-max-frequency = <108000000>; > + spi-rx-bus-width = <4>; > + spi-tx-bus-width = <4>; > + > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + partition@0 { > + label = "firmware"; > + reg = <0x0 0x3e0000>; > + }; > + partition@3e0000 { > + label = "hw-info"; > + reg = <0x3e0000 0x10000>; > + read-only; > + }; > + partition@3f0000 { > + label = "u-boot-env"; > + reg = <0x3f0000 0x10000>; > + }; > + }; > + }; > +}; > + > +&i2c0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + > + clock-frequency = <100000>; > + > + rtc@51 { > + compatible = "nxp,pcf8563"; > + reg = <0x51>; > + }; > +}; > + > +&usb3 { > + usb-phy = <&usb3_phy>; > + status = "disabled"; > +}; > + > +&mdio { > + extphy: ethernet-phy@0 { > + reg = <1>; > + }; > +}; > + > +&switch0 { > + reg = <3>; > + > + ports { > + port@1 { > + reg = <1>; > + label = "lan0"; > + phy-handle = <&switch0phy0>; > + }; > + > + port@2 { > + reg = <2>; > + label = "lan1"; > + phy-handle = <&switch0phy1>; > + }; > + > + port@3 { > + reg = <3>; > + label = "lan2"; > + phy-handle = <&switch0phy2>; > + }; > + > + port@4 { > + reg = <4>; > + label = "lan3"; > + phy-handle = <&switch0phy3>; > + }; > + > + port@5 { > + reg = <5>; > + label = "wan"; > + phy-handle = <&extphy>; > + phy-mode = "sgmii"; > + }; > + }; > + > + mdio { > + switch0phy3: switch0phy3@14 { > + reg = <0x14>; > + }; > + }; > +}; > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel