From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A28C4363A for ; Mon, 26 Oct 2020 13:04:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CF8920790 for ; Mon, 26 Oct 2020 13:04:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ksgSkho8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CF8920790 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AS7Le5o0cle91XwqvfVqohsE3Hs5DbQb67UoU4EPXk8=; b=ksgSkho8bRwKjrI6fOD8h6Pql pDfaEWEoecK0/QP9TErfqOkutE/nPeFSjOrQMH7GbxcWOOCEJ4SJgb7pMcBc1kzlHxzi2aBvJzWDz OGQozIQUtVwWXg0i5b2XUx5YDY8kcmYezmgFkeg5nf5rP0uY3fsWxClPAAVbnlbuXIH41FXD9ddfj vwC2pMoBCnV6Jiuv9IzBAXIAc9UV7+4+j55+rwnUfmYs/4+5NaR4YypXGzZJl2xA9W1/Byxlvr5/3 116yF/ytqoe5tLYHheNb/fdE7jv0Htuydl20WrTrGEjRxR8ZuyvnhzVXyKLwQ+28mEGPUGTId2XRS g3h1kwXmw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kX29F-0001yd-TI; Mon, 26 Oct 2020 13:02:53 +0000 Received: from muru.com ([72.249.23.125]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kX29D-0001y8-Iy for linux-arm-kernel@lists.infradead.org; Mon, 26 Oct 2020 13:02:52 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A69D980AA; Mon, 26 Oct 2020 13:02:50 +0000 (UTC) Date: Mon, 26 Oct 2020 15:02:38 +0200 From: Tony Lindgren To: Philipp Zabel Subject: Re: [PATCH 9/9] remoteproc/wkup_m3: Use reset control driver if available Message-ID: <20201026130238.GA5639@atomide.com> References: <20201026111049.54835-1-tony@atomide.com> <20201026111049.54835-10-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_090251_699336_CE74AEA2 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Tero Kristo , Grygorii Strashko , Dave Gerlach , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , Santosh Shilimkar , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, "Andrew F . Davis" , Peter Ujfalusi , Faiz Abbas , Bjorn Andersson , Keerthy , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Philipp Zabel [201026 11:35]: > On Mon, 2020-10-26 at 13:10 +0200, Tony Lindgren wrote: > > @@ -57,6 +60,9 @@ static int wkup_m3_rproc_start(struct rproc *rproc) > > struct device *dev = &pdev->dev; > > struct wkup_m3_platform_data *pdata = dev_get_platdata(dev); > > > > + if (wkupm3->rsts) > > No need for this check, reset_control_deassert() just returns 0 if the > rstc parameter is NULL. > > > + return reset_control_deassert(wkupm3->rsts); > > + > > if (pdata->deassert_reset(pdev, pdata->reset_name)) { > > dev_err(dev, "Unable to reset wkup_m3!\n"); > > return -ENODEV; > > @@ -72,6 +78,9 @@ static int wkup_m3_rproc_stop(struct rproc *rproc) > > struct device *dev = &pdev->dev; > > struct wkup_m3_platform_data *pdata = dev_get_platdata(dev); > > > > + if (wkupm3->rsts) > > Same as above. OK great. > > + return reset_control_assert(wkupm3->rsts); > > + > > if (pdata->assert_reset(pdev, pdata->reset_name)) { > > dev_err(dev, "Unable to assert reset of wkup_m3!\n"); > > return -ENODEV; > > @@ -132,12 +141,6 @@ static int wkup_m3_rproc_probe(struct platform_device *pdev) > > int ret; > > int i; > > > > - if (!(pdata && pdata->deassert_reset && pdata->assert_reset && > > - pdata->reset_name)) { > > - dev_err(dev, "Platform data missing!\n"); > > - return -ENODEV; > > - } > > - > > ret = of_property_read_string(dev->of_node, "ti,pm-firmware", > > &fw_name); > > if (ret) { > > @@ -165,6 +168,17 @@ static int wkup_m3_rproc_probe(struct platform_device *pdev) > > wkupm3->rproc = rproc; > > wkupm3->pdev = pdev; > > > > + wkupm3->rsts = devm_reset_control_get_optional_shared(dev, "rstctrl"); > > + if (PTR_ERR_OR_ZERO(wkupm3->rsts)) { > > Please properly return errors. rsts will be NULL if the optional rstctrl > reset is not specified: > > if (IS_ERR(wkump3->rsts)) > return PTR_ERR(wkump3->rsts); OK thanks will do. > if (!wkump3->rsts) { > > + if (!(pdata && pdata->deassert_reset && pdata->assert_reset && > > + pdata->reset_name)) { > > + dev_err(dev, "Platform data missing!\n"); > > + ret = -ENODEV; > > + goto err_put_rproc; > > + } > > + wkupm3->rsts = NULL; > > I assume this will later be dropped with the platform data support? Yes once also am437x has been updated to probe with dts data only we can drop the custom callbacks. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel