From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F0FAC55178 for ; Mon, 26 Oct 2020 13:28:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4AB0C22281 for ; Mon, 26 Oct 2020 13:28:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MDPFbbFy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AB0C22281 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1qNGGSuVY0ivS32kNXn6XiM6izg/97ixBkvFdg3vQTg=; b=MDPFbbFyh0+CRkDnjBAcpONCe AARqfXARQxHS74gaOJW+qfyxyIVMmrPip9gXIteeRu7chwG/LgIO9R5HfDu9lE/fLtIrW9F/UevUX 8DXDaE62zgxfQ6KRSwKbzo7KuvLJpSoyIqHy/TFDHx8Eh4QH4CVBC5rYwRan4i1583ibSt/bnOrgy WHaYtwRxDSeyzfrSZDZ31yC5H91YG8d/PUezhVgQs+M4bL8YG7aznZpEGCR9SWuADCDyqtqgH4S+i +q2ICqkiOgl/e839q7F+7MaGvA47AV0vT8PAfhZiXUe0tgyF3I6+nNIC6GZ9YJimR4BZ+oas0Caww 9e04FnPNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kX2Wm-0005Cf-22; Mon, 26 Oct 2020 13:27:12 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kX2Wi-0005Bd-OB; Mon, 26 Oct 2020 13:27:09 +0000 Received: by mail-oi1-f194.google.com with SMTP id w191so10472948oif.2; Mon, 26 Oct 2020 06:27:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I00XBAnJ7WylgkzAn5TxWF3njmn5zBWWNtxL/K5mgoc=; b=XnCjxNo/KevZYkHyzLhEVV5j4I2h72jQjcWUY1wlKeQfwEUxYkv6xN+SVZ+LpKsIy2 jnwKjgDqA3dExjBu6iJrXCyLI1kaOR6vKsT1epz9ggoQnTUzcnwormb8m2IrdtzR4Tgo UEUABDIzJr5JjX+kFaAS9k4YMFj3jyAmK2pSLW6UQGJXJhb40Av0M33pnG5fwmbd0uhm 5qJWnbyWRkSYUgS7r3obKSTjFcIy80hRshYgkIUQs3yfIuhqsOjceIAQ017FJGrBJHz8 +8657HkaM8uZ5WWzo9D85oTcFJ2URqE/5vI3P9UKiLqdTMIpgz3/E3nOYXZcSlT1BBPK 2Ddg== X-Gm-Message-State: AOAM533UACoubTYqvKh5pwrX9kiwhRdiUvcwWESvh3ry9VLoEAd9148P EM6eTR9GRdH4dr/MqR1wAw== X-Google-Smtp-Source: ABdhPJw/URyM2Olc0l0cnR5M+IOaA7dfiOz7xYxgvGes09V25+mkFzvABkINEQh/Wu5rg0R4pOiViw== X-Received: by 2002:aca:6206:: with SMTP id w6mr14216985oib.121.1603718826869; Mon, 26 Oct 2020 06:27:06 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id d22sm3855955oij.53.2020.10.26.06.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 06:27:05 -0700 (PDT) Received: (nullmailer pid 28455 invoked by uid 1000); Mon, 26 Oct 2020 13:27:04 -0000 Date: Mon, 26 Oct 2020 08:27:04 -0500 From: Rob Herring To: Richard Fitzgerald Subject: Re: [PATCH v2 2/7] ASoC: audio-graph-card: Add plls and sysclks DT bindings Message-ID: <20201026132704.GA19204@bogus> References: <20201016173541.21180-1-rf@opensource.cirrus.com> <20201016173541.21180-3-rf@opensource.cirrus.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201016173541.21180-3-rf@opensource.cirrus.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_092708_821679_E1CBC4AD X-CRM114-Status: GOOD ( 23.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 16, 2020 at 06:35:36PM +0100, Richard Fitzgerald wrote: > This adds the two new properties 'plls' and 'sysclks' to the dt bindings. > These add the ability to set values that will be > passed to snd_soc_component_set_sysclk() and snd_soc_component_set_pll(). I worry this looks like Linux implementation details leaking into the binding. > > Signed-off-by: Richard Fitzgerald > --- > .../bindings/sound/audio-graph-card.txt | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card.txt b/Documentation/devicetree/bindings/sound/audio-graph-card.txt > index d5f6919a2d69..59bbd5b55b59 100644 > --- a/Documentation/devicetree/bindings/sound/audio-graph-card.txt > +++ b/Documentation/devicetree/bindings/sound/audio-graph-card.txt > @@ -32,6 +32,19 @@ Required properties: > Optional properties: > - pa-gpios: GPIO used to control external amplifier. > > +- plls: A list of component pll settings that will be applied with > + snd_soc_component_set_pll. Each entry is a phandle to the node of the > + codec or cpu component, followed by the four arguments id, source, > + frequency_in, frequency_out. Multiple entries can have the same phandle > + so that several plls can be set in the same component. Where do the values of id and source come from? > + > +- sysclks: A list of component sysclk settings that will be applied with > + snd_soc_component_set_sysclk. Each entry is a phandle to the node of > + the codec or cpu component, followed by the four arguments id, source, > + frequency, direction. Direction is 0 if the clock is an input, 1 if it > + is an output. Multiple entries can have the same phandle so that several > + clocks can be set in the same component. Are these really common properties? They seem kind of Cirrus specific and perhaps should be located in the codec node(s). > + > ----------------------- > Example: Single DAI case > ----------------------- > @@ -335,3 +348,34 @@ Example: Multi DAI with DPCM > }; > }; > }; > + > +----------------------- > +Example: Set component sysclks and PLLs > +----------------------- > + > + sound { > + compatible = "audio-graph-card"; > + > + sysclks = < > + &cs47l15 1 4 98304000 0 > + &cs47l15 8 4 147456000 0 > + >; > + plls = < > + &cs47l15 1 0 24576000 98304000 > + >; > + > + dais = <&cpu_i2s_port>; > + }; > + > + cs47l15: codec@0 { > + ... > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + cs47l15_aif1_port: port@0 { > + reg = <0>; > + cs47l15_aif1: endpoint { > + remote-endpoint = <&cpu_i2s_endpoint>; > + }; > + }; > + }; > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel