From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
Richard Fitzgerald <rf@opensource.cirrus.com>,
linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/7] ASoC: audio-graph-card: Add plls and sysclks DT bindings
Date: Mon, 26 Oct 2020 13:38:39 +0000 [thread overview]
Message-ID: <20201026133839.GE7402@sirena.org.uk> (raw)
In-Reply-To: <20201026132704.GA19204@bogus>
[-- Attachment #1.1: Type: text/plain, Size: 1473 bytes --]
On Mon, Oct 26, 2020 at 08:27:04AM -0500, Rob Herring wrote:
> On Fri, Oct 16, 2020 at 06:35:36PM +0100, Richard Fitzgerald wrote:
> > +- plls: A list of component pll settings that will be applied with
> > + snd_soc_component_set_pll. Each entry is a phandle to the node of the
> > + codec or cpu component, followed by the four arguments id, source,
> > + frequency_in, frequency_out. Multiple entries can have the same phandle
> > + so that several plls can be set in the same component.
> Where do the values of id and source come from?
The device bindings will need to define them.
> > +- sysclks: A list of component sysclk settings that will be applied with
> > + snd_soc_component_set_sysclk. Each entry is a phandle to the node of
> > + the codec or cpu component, followed by the four arguments id, source,
> > + frequency, direction. Direction is 0 if the clock is an input, 1 if it
> > + is an output. Multiple entries can have the same phandle so that several
> > + clocks can be set in the same component.
> Are these really common properties? They seem kind of Cirrus specific
> and perhaps should be located in the codec node(s).
It's very common for audio devices to have very flexible clocking, to
the exetent this is Linux specific it's issues with the clock API not
being able to handle clock controllers on buses that need clock control
to access rather than conceptually.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-26 13:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 17:35 [PATCH v2 0/7] Add support for Rpi4b + Cirrus Lochnagar2 and CS47L15 Richard Fitzgerald
2020-10-16 17:35 ` [PATCH v2 1/7] of: base: Add of_count_phandle_with_fixed_args() Richard Fitzgerald
2020-10-26 13:19 ` Rob Herring
2020-10-16 17:35 ` [PATCH v2 2/7] ASoC: audio-graph-card: Add plls and sysclks DT bindings Richard Fitzgerald
2020-10-26 13:27 ` Rob Herring
2020-10-26 13:38 ` Mark Brown [this message]
2020-11-02 11:48 ` Richard Fitzgerald
2020-10-16 17:35 ` [PATCH v2 3/7] ASoC: audio-graph-card: Support setting component plls and sysclks Richard Fitzgerald
2020-10-16 17:35 ` [PATCH v2 4/7] ASoC: arizona: Allow codecs to be selected from kernel config Richard Fitzgerald
2020-10-16 17:35 ` [PATCH v2 5/7] ASoC: madera: " Richard Fitzgerald
2020-10-16 17:35 ` [PATCH v2 6/7] ARM: dts: Add dts for RPi4b + Cirrus Logic Lochnagar2 + CS47L15 Richard Fitzgerald
2020-10-16 17:35 ` [PATCH v2 7/7] MAINTAINERS: Add dts for Cirrus Logic Lochnagar on RPi4 Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026133839.GE7402@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).