* [PATCH 2/3] mmc: s3cmci: enable compile testing
2020-10-26 15:38 [PATCH 1/3] mmc: s3cmci: include GPIO descriptor consumer header Krzysztof Kozlowski
@ 2020-10-26 15:38 ` Krzysztof Kozlowski
2020-10-27 13:41 ` Ulf Hansson
2020-10-26 15:38 ` [PATCH 3/3] mmc: sunxi: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-10-27 13:41 ` [PATCH 1/3] mmc: s3cmci: include GPIO descriptor consumer header Ulf Hansson
2 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-26 15:38 UTC (permalink / raw)
To: Ulf Hansson, Ben Dooks, Maxime Ripard, Chen-Yu Tsai,
Adrian Hunter, linux-mmc, linux-kernel, linux-arm-kernel
Cc: Krzysztof Kozlowski
The driver can be compile tested to increase build coverage.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mmc/host/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 31481c9fcc2e..310e546e5898 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -631,8 +631,8 @@ config MMC_SPI
config MMC_S3C
tristate "Samsung S3C SD/MMC Card Interface support"
- depends on ARCH_S3C24XX
- depends on S3C24XX_DMAC
+ depends on ARCH_S3C24XX || COMPILE_TEST
+ depends on S3C24XX_DMAC || COMPILE_TEST
help
This selects a driver for the MCI interface found in
Samsung's S3C2410, S3C2412, S3C2440, S3C2442 CPUs.
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] mmc: s3cmci: enable compile testing
2020-10-26 15:38 ` [PATCH 2/3] mmc: s3cmci: enable compile testing Krzysztof Kozlowski
@ 2020-10-27 13:41 ` Ulf Hansson
0 siblings, 0 replies; 7+ messages in thread
From: Ulf Hansson @ 2020-10-27 13:41 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-mmc@vger.kernel.org, Linux Kernel Mailing List,
Maxime Ripard, Adrian Hunter, Chen-Yu Tsai, Ben Dooks, Linux ARM
On Mon, 26 Oct 2020 at 16:40, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The driver can be compile tested to increase build coverage.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 31481c9fcc2e..310e546e5898 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -631,8 +631,8 @@ config MMC_SPI
>
> config MMC_S3C
> tristate "Samsung S3C SD/MMC Card Interface support"
> - depends on ARCH_S3C24XX
> - depends on S3C24XX_DMAC
> + depends on ARCH_S3C24XX || COMPILE_TEST
> + depends on S3C24XX_DMAC || COMPILE_TEST
> help
> This selects a driver for the MCI interface found in
> Samsung's S3C2410, S3C2412, S3C2440, S3C2442 CPUs.
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] mmc: sunxi: drop of_match_ptr from of_device_id table
2020-10-26 15:38 [PATCH 1/3] mmc: s3cmci: include GPIO descriptor consumer header Krzysztof Kozlowski
2020-10-26 15:38 ` [PATCH 2/3] mmc: s3cmci: enable compile testing Krzysztof Kozlowski
@ 2020-10-26 15:38 ` Krzysztof Kozlowski
2020-10-26 17:20 ` Maxime Ripard
2020-10-27 13:41 ` Ulf Hansson
2020-10-27 13:41 ` [PATCH 1/3] mmc: s3cmci: include GPIO descriptor consumer header Ulf Hansson
2 siblings, 2 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-26 15:38 UTC (permalink / raw)
To: Ulf Hansson, Ben Dooks, Maxime Ripard, Chen-Yu Tsai,
Adrian Hunter, linux-mmc, linux-kernel, linux-arm-kernel
Cc: kernel test robot, Krzysztof Kozlowski
The driver can match only via DT table so it should be always used and
the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it is not relevant for sunxi). This
fixes compile warning:
drivers/mmc/host/sunxi-mmc.c:1181:34: warning: ‘sunxi_mmc_of_match’ defined but not used [-Wunused-const-variable=]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mmc/host/sunxi-mmc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index fc62773602ec..6310693f2ac0 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -26,6 +26,7 @@
#include <linux/mmc/sdio.h>
#include <linux/mmc/slot-gpio.h>
#include <linux/module.h>
+#include <linux/mod_devicetable.h>
#include <linux/of_address.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
@@ -1515,7 +1516,7 @@ static struct platform_driver sunxi_mmc_driver = {
.driver = {
.name = "sunxi-mmc",
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
- .of_match_table = of_match_ptr(sunxi_mmc_of_match),
+ .of_match_table = sunxi_mmc_of_match,
.pm = &sunxi_mmc_pm_ops,
},
.probe = sunxi_mmc_probe,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/3] mmc: sunxi: drop of_match_ptr from of_device_id table
2020-10-26 15:38 ` [PATCH 3/3] mmc: sunxi: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
@ 2020-10-26 17:20 ` Maxime Ripard
2020-10-27 13:41 ` Ulf Hansson
1 sibling, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2020-10-26 17:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ulf Hansson, kernel test robot, linux-mmc, linux-kernel,
Adrian Hunter, Chen-Yu Tsai, Ben Dooks, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 610 bytes --]
On Mon, Oct 26, 2020 at 04:38:10PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via DT table so it should be always used and
> the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant for sunxi). This
> fixes compile warning:
>
> drivers/mmc/host/sunxi-mmc.c:1181:34: warning: ‘sunxi_mmc_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] mmc: sunxi: drop of_match_ptr from of_device_id table
2020-10-26 15:38 ` [PATCH 3/3] mmc: sunxi: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
2020-10-26 17:20 ` Maxime Ripard
@ 2020-10-27 13:41 ` Ulf Hansson
1 sibling, 0 replies; 7+ messages in thread
From: Ulf Hansson @ 2020-10-27 13:41 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: kernel test robot, linux-mmc@vger.kernel.org,
Linux Kernel Mailing List, Maxime Ripard, Adrian Hunter,
Chen-Yu Tsai, Ben Dooks, Linux ARM
On Mon, 26 Oct 2020 at 16:40, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The driver can match only via DT table so it should be always used and
> the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant for sunxi). This
> fixes compile warning:
>
> drivers/mmc/host/sunxi-mmc.c:1181:34: warning: ‘sunxi_mmc_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sunxi-mmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index fc62773602ec..6310693f2ac0 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -26,6 +26,7 @@
> #include <linux/mmc/sdio.h>
> #include <linux/mmc/slot-gpio.h>
> #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/of_address.h>
> #include <linux/of_platform.h>
> #include <linux/platform_device.h>
> @@ -1515,7 +1516,7 @@ static struct platform_driver sunxi_mmc_driver = {
> .driver = {
> .name = "sunxi-mmc",
> .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> - .of_match_table = of_match_ptr(sunxi_mmc_of_match),
> + .of_match_table = sunxi_mmc_of_match,
> .pm = &sunxi_mmc_pm_ops,
> },
> .probe = sunxi_mmc_probe,
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] mmc: s3cmci: include GPIO descriptor consumer header
2020-10-26 15:38 [PATCH 1/3] mmc: s3cmci: include GPIO descriptor consumer header Krzysztof Kozlowski
2020-10-26 15:38 ` [PATCH 2/3] mmc: s3cmci: enable compile testing Krzysztof Kozlowski
2020-10-26 15:38 ` [PATCH 3/3] mmc: sunxi: drop of_match_ptr from of_device_id table Krzysztof Kozlowski
@ 2020-10-27 13:41 ` Ulf Hansson
2 siblings, 0 replies; 7+ messages in thread
From: Ulf Hansson @ 2020-10-27 13:41 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-mmc@vger.kernel.org, Linux Kernel Mailing List,
Maxime Ripard, Adrian Hunter, Chen-Yu Tsai, Ben Dooks, Linux ARM
On Mon, 26 Oct 2020 at 16:40, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The driver uses GPIO Descriptor Consumer Interface so include proper
> header to fix compile test errors like:
>
> drivers/mmc/host/s3cmci.c: In function ‘s3cmci_check_sdio_irq’:
> drivers/mmc/host/s3cmci.c:304:7: error:
> implicit declaration of function ‘gpiod_get_value’; did you mean ‘gpio_get_value’? [-Werror=implicit-function-declaration]
>
> drivers/mmc/host/s3cmci.c: In function ‘s3cmci_probe_pdata’:
> drivers/mmc/host/s3cmci.c:1451:19: error:
> implicit declaration of function ‘devm_gpiod_get_index’ [-Werror=implicit-function-declaration]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/s3cmci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
> index 643d54eceef6..a33a7823c265 100644
> --- a/drivers/mmc/host/s3cmci.c
> +++ b/drivers/mmc/host/s3cmci.c
> @@ -17,7 +17,7 @@
> #include <linux/cpufreq.h>
> #include <linux/debugfs.h>
> #include <linux/seq_file.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> #include <linux/io.h>
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread