From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BA9C4363A for ; Tue, 27 Oct 2020 08:17:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5252D206D4 for ; Tue, 27 Oct 2020 08:17:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Im8DN0bM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5252D206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hqLfh0uxTQnei2Y99Qz7rPhhwF5hTN3Uv6YZcnopijE=; b=Im8DN0bMh8StG/8GLdhSVgFrW mjut/xOJM5dIoMrR6VJd/3m5t4fbZA52rn2onJTYiFuTwmxUf+cUlQDG/Ze/Mq/BvEgHNciHmv5IW N1lmvm21Lyor3EYGoFWzKhDtv7xHTFshJGPNHHtjpmRFUgTCXo6AZTWC/ywtIzJlQFCZrye42dGff AHVYDIschdzze8zvO5Xb64I4HBMFx6xMF3v1Yg35NQUP/oiveNomwUaYAs/0nA2T2yI83WiCbmhb6 jY7ngy8nf8lMxF9TXbkl8nKPM+A5ZbXC4jW45lMgpbgSLrFId1O1xnqgNpU2HZzzpftMPAUSofYEZ rpu/ae34A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXKA4-0000gi-Cw; Tue, 27 Oct 2020 08:16:56 +0000 Received: from mail-lj1-f196.google.com ([209.85.208.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXKA1-0000fn-4N for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 08:16:53 +0000 Received: by mail-lj1-f196.google.com with SMTP id a5so707849ljj.11 for ; Tue, 27 Oct 2020 01:16:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4X/i6x/+78+fLH0lPper9S35q82PCcSbtWfUqlievPc=; b=DJXpEKwOtCj7UTBGxKsUoeV1cicuv8ZuWEDtd98+OETdn1P2R/TZ4wvktcE2b/01cx kcgtrQ+laEAsWwEFPbkTJqBilElGT4u1iI0VEseI9nqGqzgIklgFCMCXtK37xSmFToXP 0IZOkq8s2PDQoabYbypMjmmbYg5sHY7U3hWvQcpQCh6qV7wl8Y08FIqfeksfA9l7xHGB HzLxX8j3EV36rdyC0e2DcFciVhL1Oj7HW9WmtUKWc9/kJWdORJmI1WNmt+yYdJez02mX k8LTvM6Utv3LimPjfx8Fqy3o3VqmTKh5oKaN3u22yryf3t5KurFJJQBdolZ1hSELGH2J 0CUw== X-Gm-Message-State: AOAM531EbcsU2znENZc8Bc35rnAPtIg9BVi+0L94XMJEbf5l3M7I2wsx 3Gqlhoww0wblPCdRr/1KutM= X-Google-Smtp-Source: ABdhPJyiRzqsfEO4O7r5IIRQvb3+7LSAdAe3jrDZoAuW1ZpukGOup5MjnYT7Lif1P6AYdNpMCqJQUQ== X-Received: by 2002:a2e:8103:: with SMTP id d3mr545991ljg.384.1603786610328; Tue, 27 Oct 2020 01:16:50 -0700 (PDT) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id v16sm92687lfq.68.2020.10.27.01.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 01:16:49 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.93.0.4) (envelope-from ) id 1kXK9v-0001H7-Vf; Tue, 27 Oct 2020 09:16:48 +0100 Date: Tue, 27 Oct 2020 09:16:47 +0100 From: Johan Hovold To: Sebastian Andrzej Siewior Subject: Re: [patch V2 02/13] USB: serial: keyspan_pda: Replace in_interrupt() usage Message-ID: <20201027081647.GC4085@localhost> References: <20201019100629.419020859@linutronix.de> <20201019101109.753597069@linutronix.de> <20201025165647.GR26280@localhost> <20201026124753.btmdh3iwbwnff5dg@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201026124753.btmdh3iwbwnff5dg@linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_041653_186720_021BE987 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Thomas Winischhofer , Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Johan Hovold , Krzysztof Kozlowski , LKML , linux-samsung-soc@vger.kernel.org, Kukjin Kim , Valentina Manea , Duncan Sands , "Ahmed S. Darwish" , Alan Stern , Thomas Gleixner , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 26, 2020 at 01:47:53PM +0100, Sebastian Andrzej Siewior wrote: > On 2020-10-25 17:56:47 [+0100], Johan Hovold wrote: > > There's a ton of issues with this driver, but this is arguably making > > things worse. A line discipline may call write() from just about any > > context so we cannot rely on tty being non-NULL here (e.g. PPP). > > I wasn't aware of that. I've been looking at the callers each time a > `tty' was passed it looked like a preemptible context (due to mutex / > GFP_KERNEL) and so on. Yeah, the default line discipline only calls in preemptible context (these days), but others do not (e.g. see ppp_async_push()). Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel