From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 177C2C388F9 for ; Tue, 27 Oct 2020 12:22:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F5B522281 for ; Tue, 27 Oct 2020 12:22:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hxtg4tFK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="N8ghTswy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F5B522281 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EJR1+Ch0nahGlUwNVDdc8bXj4QcgEqfaGxwVGV6kHt4=; b=hxtg4tFKRJTadcC2WSD9LdV79 dJBD6a8G9opxjVEQG2RldXYj5wil9gmwqsvzsRoTKuPH00qlfNSJ8SS0fhcI/Gj1PFYo7BTbkTXpa PwLZsJsqvXZ5D9WQjkDf8uyyPxgcEWXEqUm+YZJN+yIuM8+4cuqXifOgnMX6U0DLQ1z//W/HzyRse bv8JjgIQ8Rju0U1diaQkvokd/Yp1kEN0zNmsXVkJnVUgOIk90v7h/e/z32m6piUmS0PrsAxo4VQVl bi3xkXNbDwOUAea6GDMvegteObFEx9W+VMS+Hrxwx3FpMEjjHunNN8mqdOBz7hdAmzBSDY75iE3bW cYBFbUQSw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXNyK-0006ot-Ry; Tue, 27 Oct 2020 12:21:04 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXNyD-0006ls-FI for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 12:21:02 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09RCKsXo042543; Tue, 27 Oct 2020 07:20:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1603801254; bh=Np4PxMjisKBQclEbyL5M6uJIRfVlPSJTccS/tHqo4rk=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=N8ghTswyfU/J8PdvnRUTCzxqOvlpeNV9xYvKHJXeGBub/EOiMNTkKix+j7nILbHSb ZRfPl4n1GSFL00t7DKSfmLBTJWpbFx0M5XPM1nra7glUIan3LSz4wdoQ+Ec/qCWlGD wF4ngBSBoC+gfb1M05a+qzVyGvXgnDAuOPGkbFD8= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09RCKs3G003258 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 27 Oct 2020 07:20:54 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 27 Oct 2020 07:20:54 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 27 Oct 2020 07:20:54 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09RCKs12082338; Tue, 27 Oct 2020 07:20:54 -0500 Date: Tue, 27 Oct 2020 07:20:54 -0500 From: Nishanth Menon To: Tomi Valkeinen Subject: Re: [PATCH 2/4] arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm Message-ID: <20201027122054.zdjbjfpjkhnc7wdr@silenced> References: <20201027104132.105485-1-tomi.valkeinen@ti.com> <20201027104132.105485-3-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201027104132.105485-3-tomi.valkeinen@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_082057_717451_DE7E29D1 X-CRM114-Status: GOOD ( 15.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tero Kristo , devicetree@vger.kernel.org, Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org, Swapnil Jakhade Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12:41-20201027, Tomi Valkeinen wrote: [...] > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > index 52e121155563..5a36d65755ee 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > @@ -83,6 +83,31 @@ sound0: sound@0 { > "cpb-codec-scki", > "cpb-codec-scki-48000", "cpb-codec-scki-44100"; > }; > + > + dp_pwr_3v3: fixedregulator-dp-prw { > + compatible = "regulator-fixed"; > + regulator-name = "dp-pwr"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&exp4 0 0>; /* P0 - DP0_PWR_SW_EN */ > + enable-active-high; > + > + /* Always on for now, until dp-connector driver can handle this */ > + regulator-always-on; > + }; > + > + dp0: connector { > + compatible = "dp-connector"; This is not documented? I see the following on checkpatch: +WARNING: DT compatible string "dp-connector" appears un-documented -- check ./Documentation/devicetree/bindings/ +#42: FILE: arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:100: ++ compatible = "dp-connector"; + mechanically convert to the typical style using --fix or --fix-inplace. + them to the maintainer, see CHECKPATCH in MAINTAINERS. > + label = "DP0"; > + type = "full-size"; > + dp-pwr-supply = <&dp_pwr_3v3>; > + > + port { > + dp_connector_in: endpoint { > + remote-endpoint = <&dp0_out>; > + }; > + }; > + }; > }; > > &main_pmx0 { > @@ -119,6 +144,12 @@ J721E_IOPAD(0x214, PIN_OUTPUT, 4) /* (V4) MCAN1_TX.USB1_DRVVBUS */ > >; > }; > > + dp0_pins_default: dp0_pins_default { please don't use _ in node names dp0-pins-default perhaps? [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel