From: Viresh Kumar <viresh.kumar@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Nishanth Menon <nm@ti.com>, Len Brown <len.brown@intel.com>,
ulf.hansson@linaro.org, linux-samsung-soc@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>,
Kevin Hilman <khilman@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
nks@flawful.org, Kukjin Kim <kgene@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Viresh Kumar <vireshk@kernel.org>,
georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER
Date: Wed, 28 Oct 2020 09:36:37 +0530 [thread overview]
Message-ID: <20201028040637.26kw2qk7digel6yb@vireshk-i7> (raw)
In-Reply-To: <20201027222428.GA125472@roeck-us.net>
On 27-10-20, 15:24, Guenter Roeck wrote:
> Trying again through different e-mail provider. My previous e-mail
> got stuck in spam filters. Apologies if this is received multiple
> times.
I received only once :)
> On Mon, Aug 24, 2020 at 02:39:32PM +0530, Viresh Kumar wrote:
> > From: Stephan Gerhold <stephan@gerhold.net>
> >
> [ ... ]
You removed way too much and this lost the context. Keeping the
routine's prototype line would have been useful.
> >
> > opp_table = dev_pm_opp_get_opp_table(dev);
> > - if (!opp_table)
> > - return ERR_PTR(-ENOMEM);
> > + if (!IS_ERR(opp_table))
> > + return opp_table;
>
> This should have been
>
> if (IS_ERR(opp_table))
> return opp_table;
I believe this is the delta from dev_pm_opp_register_set_opp_helper()
?
A proper fix is already pushed in linux-next for this yesterday.
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-28 4:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:09 [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Viresh Kumar
2020-08-24 9:17 ` Krzysztof Kozlowski
2020-08-24 11:08 ` Ulf Hansson
2020-08-24 11:39 ` Stephan Gerhold
2020-10-15 18:05 ` Sudeep Holla
2020-10-16 4:24 ` Viresh Kumar
2020-10-16 6:00 ` Sudeep Holla
2020-10-16 11:12 ` Sudeep Holla
2020-10-16 15:28 ` Stephan Gerhold
2020-10-19 4:58 ` Viresh Kumar
2020-10-19 9:17 ` Sudeep Holla
2020-10-19 9:24 ` Viresh Kumar
2020-10-19 10:12 ` Sudeep Holla
2020-10-19 10:35 ` Viresh Kumar
2020-10-19 14:10 ` Sudeep Holla
2020-10-20 5:05 ` Viresh Kumar
2020-10-20 5:54 ` Viresh Kumar
2020-10-20 9:37 ` Sudeep Holla
2020-10-20 9:41 ` Viresh Kumar
2020-10-20 9:52 ` Sudeep Holla
2020-10-20 9:59 ` Viresh Kumar
2020-10-27 22:24 ` Guenter Roeck
2020-10-28 4:06 ` Viresh Kumar [this message]
2020-10-28 17:29 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028040637.26kw2qk7digel6yb@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=krzk@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nks@flawful.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=stephan@gerhold.net \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox