From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC25BC4363A for ; Wed, 28 Oct 2020 07:41:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 593CB2417E for ; Wed, 28 Oct 2020 07:41:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bCukDQLG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="e6Bd0mT5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 593CB2417E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cR4tPFWyYPtsbMt7um2Yn0xqlQmpEz9AsUldXnxhFDM=; b=bCukDQLGY1/kTbgeq5sfz62y4 QBfxG04QJymdA/8x3znsMBq3nlq32XlPLFwLZntGJPjEYz9pqZ1GEHh4EABVxjaCvhLB/dWzX5uwg Sjmdllm4KfNI6F2nvSs/ywhmw2pYGGap6DELkDEvv0Whblv4GJ2SPV+9TTEh2/5YKasSdlVEZjQw1 ADvnox8o0r9imNIQJ3wPCyqeS+5i8pWFzG5QBY3XOkiSndT3fvTAYAtrmr17izc4POU0G0jfRV+fX f7O4tSUXHFb1nb5d5jgoGBUZdzxBzdr0RpE84CmEwbdIkxHeNZpkbyNyZJI3wbsd+fr5aR9ePe04c jKyePfIfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXg2W-0003GZ-0c; Wed, 28 Oct 2020 07:38:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXg2L-0003FY-OM for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 07:38:31 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E64D2242F; Wed, 28 Oct 2020 07:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603870700; bh=U7zzmaq/mn3S7yoFvyfQMPCSxqUHi0eJSFeubecSZWA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e6Bd0mT5dq9uFWJK+Q4dqSGuad0pbXuy6mGlpnolxYdYZ8cUiokTTskwCLH5ANS0B RAnxr1OUU9h7owncI0Ck8Q2rUcIhVOKXL/nHUg2qJQ1jHNbTq33Z7+jMei5M4wDOzo jqKdKDrKE8lyXDg2VfamE8AN3CQ7HH1+Ab4EBKhk= Date: Wed, 28 Oct 2020 15:38:13 +0800 From: Shawn Guo To: Matthias Schiffer Subject: Re: [PATCH 02/13] ARM: dts: imx7-tqma7: add SPI-NOR flash Message-ID: <20201028073813.GN9880@dragon> References: <20200918112942.1367-1-matthias.schiffer@ew.tq-group.com> <20200918112942.1367-2-matthias.schiffer@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200918112942.1367-2-matthias.schiffer@ew.tq-group.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_033825_902429_E7ECD0A3 X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 18, 2020 at 01:29:31PM +0200, Matthias Schiffer wrote: > The SPI-NOR flash on the SoM was missing from the device tree. > > Signed-off-by: Matthias Schiffer > --- > arch/arm/boot/dts/imx7-tqma7.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch/arm/boot/dts/imx7-tqma7.dtsi > index 8773344b54aa..fd23f764399a 100644 > --- a/arch/arm/boot/dts/imx7-tqma7.dtsi > +++ b/arch/arm/boot/dts/imx7-tqma7.dtsi > @@ -160,6 +160,20 @@ > >; > }; > > + pinctrl_qspi: qspigrp { > + fsl,pins = < > + MX7D_PAD_EPDC_DATA00__QSPI_A_DATA0 0x5A > + MX7D_PAD_EPDC_DATA01__QSPI_A_DATA1 0x5A > + MX7D_PAD_EPDC_DATA02__QSPI_A_DATA2 0x5A > + MX7D_PAD_EPDC_DATA03__QSPI_A_DATA3 0x5A > + MX7D_PAD_EPDC_DATA05__QSPI_A_SCLK 0x11 > + MX7D_PAD_EPDC_DATA06__QSPI_A_SS0_B 0x54 > + MX7D_PAD_EPDC_DATA07__QSPI_A_SS1_B 0x54 > + /* #QSPI_RESET */ > + MX7D_PAD_EPDC_DATA04__GPIO2_IO4 0x40000052 > + >; > + }; > + > pinctrl_usdhc3: usdhc3grp { > fsl,pins = < > MX7D_PAD_SD3_CMD__SD3_CMD 0x59 > @@ -217,6 +231,22 @@ > }; > }; > > +&qspi { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_qspi>; > + status = "okay"; > + > + flash0: spinor@0 { The node name should be as generic as possible. So suggest something like 'flash@0'. Shawn > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "jedec,spi-nor"; > + spi-max-frequency = <29000000>; > + spi-rx-bus-width = <4>; > + spi-tx-bus-width = <4>; > + reg = <0>; > + }; > +}; > + > &sdma { > status = "okay"; > }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel