From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF8BC55178 for ; Wed, 28 Oct 2020 08:30:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3A102464E for ; Wed, 28 Oct 2020 08:30:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZaBz4MwY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S1jZ0tl4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3A102464E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GH9W/UuaL/TpBsTnAO79warOS7XgrxYFSWVpFBlF/6Y=; b=ZaBz4MwYHhvTsLUxJOfDvtOZH 6DkvsAGVXUpux6IsiIZL60Twvyhhi6+AnYoEKdIYiWVlYbysvT9anq/vJy5ECzLb//xMpZC2rIWIF on3Q4s+oSy+NbbkXbtjNT8jkObby3N34fJ7nSs5tF+Hepk/uA9893n01/T9ikX5Yn9y6hqMgfP86b nnmqESM6RKNH2OBDL7mOM9/KVE+his6vPd8mm5DffNA1Cse/sNcsbfxeUS8Zt+CBLOPwblMDOrXa0 rXbxmtwUtqRbzOgVo5JwZdWYNEh7Qdt7R1iXGBBZgeVNhsJH5Eqd6l7AG9x8uayvILepjmBhAc958 hEulYHjrQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXgp4-0000XR-Oe; Wed, 28 Oct 2020 08:28:46 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXgp1-0000Vy-2P for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 08:28:44 +0000 Received: by mail-wm1-x341.google.com with SMTP id c16so3897444wmd.2 for ; Wed, 28 Oct 2020 01:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h7M52GawlGgNQQHoJUxEE/nQObJJ9xGoaSZGGDWnyl4=; b=S1jZ0tl42n9/tUMOGeaf4AgcisJRhJLrwigeX2WCZ66rFh5KGEocisvNLKW8NmSZAJ ME7kpNxbpSNlg0rW5hxamPte6SYwLiYPyZGR7mH7c4MR+zVIP/wkbxPXIr5bpIbeyA8a bkE21zTfxJ+YJXnJMJAdlLqXyPUsaUX9tCC9GoSnAPaCXhQul4O4qPOwlKI69ATghBm1 qZ6z2v1+cWmYtGo10CH6tiuwu1xdEimBos/LfcdsFs4+ejJ24fndVS0bD53dyYICa4LK HhzwWdcrDkCDXS1kQpGcyYqoqYLooTHk3dmjyzvqA/R2ouVsvAu1THu8OKi1/QsRc1zd c4GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h7M52GawlGgNQQHoJUxEE/nQObJJ9xGoaSZGGDWnyl4=; b=dCWuwLKcdyyvpfe4jHqgPL4XgUEe5S0SYrw8p6sUB+Rs4m5gdrLTEPLnvOOXrTC4PY YIKzg40ZGTb/q9r1aVFtYfVaHgz9GIck/2URnjixVdPi27z1Yx6tjrk8jV78eESoZ20y M/KVfLXPGiFEBc//1sYa8BuMVI3C+vhjmZUDN0bphAcxFQyNXi7P/nJc0nyTK7n6ldY1 Jh/hME69iCxyQdmem+jeHsJ0/27fO8fo1cDYylRGxzWE6WoYIQDSHIfPE1ipThAKtl7R Asz8faBBwrATj4vFAY60YY/1RLDviN0NbKtKlRROkgjqOul4LE1gkLaqtv6dpfTjnJuh r+Fw== X-Gm-Message-State: AOAM531fnsVM01o8Y8vr9osIduDlHXa1DAy4a3PzYAgGFHEj4kkBsKUm 00hEcfZIQd0PVqLaqC3+SkPd+pn16hi/4A== X-Google-Smtp-Source: ABdhPJyFBV6DuN5TdIv9YbV9ggoqtZJ3XmGqMvyYOzvELI+5yowBwvVtFdMfY6asASDpobG3B0fdvA== X-Received: by 2002:a1c:2601:: with SMTP id m1mr6481413wmm.12.1603873720573; Wed, 28 Oct 2020 01:28:40 -0700 (PDT) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id a199sm5752221wmd.8.2020.10.28.01.28.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 01:28:39 -0700 (PDT) Date: Wed, 28 Oct 2020 09:28:20 +0100 From: Jean-Philippe Brucker To: Masami Hiramatsu Subject: Re: [PATCH] arm64: Fix early single-stepping Message-ID: <20201028082820.GA2328726@myrica> References: <20201026172907.1468294-1-jean-philippe@linaro.org> <20201027191318.aba935f7ccf00af9acd89388@kernel.org> <20201027194258.43b157ac0bbccd918fc8756a@kernel.org> <20201027115909.GB1514990@myrica> <20201027123317.GA26351@willie-the-truck> <20201027224922.7b032857d53bbfdc4484f768@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201027224922.7b032857d53bbfdc4484f768@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_042843_223447_C05514CC X-CRM114-Status: GOOD ( 31.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, Will Deacon , dianders@chromium.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 27, 2020 at 10:49:22PM +0900, Masami Hiramatsu wrote: > On Tue, 27 Oct 2020 12:33:18 +0000 > Will Deacon wrote: > > > On Tue, Oct 27, 2020 at 12:59:09PM +0100, Jean-Philippe Brucker wrote: > > > On Tue, Oct 27, 2020 at 07:42:58PM +0900, Masami Hiramatsu wrote: > > > > On Tue, 27 Oct 2020 19:13:18 +0900 > > > > Masami Hiramatsu wrote: > > > > > > > > > On Mon, 26 Oct 2020 18:29:09 +0100 > > > > > Jean-Philippe Brucker wrote: > > > > > > > > > > > To use debug features such as single-step, the OS lock must be unlocked > > > > > > in the debug registers. Currently this is done in postcore_initcall > > > > > > which is now too late. > > > > > > > > > > > > Commit 36dadef23fcc ("kprobes: Init kprobes in early_initcall") enabled > > > > > > using kprobes from early_initcall, when OS lock is still locked. So when > > > > > > kprobe attempts to single-step a patched instruction, instead of > > > > > > trapping, execution continues until it throws an undef exception: > > > > > > > > > > > > [ 0.064233] Kprobe smoke test: started > > > > > > [ 0.151133] ------------[ cut here ]------------ > > > > > > [ 0.151458] kernel BUG at arch/arm64/kernel/traps.c:406! > > > > > > [ 0.151812] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP > > > > > > ... > > > > > > [ 0.162689] Call trace: > > > > > > [ 0.163014] do_undefinstr+0x1d4/0x1f4 > > > > > > [ 0.163336] el1_sync_handler+0xbc/0x140 > > > > > > [ 0.163839] el1_sync+0x80/0x100 > > > > > > [ 0.164154] 0xffffffc01001d004 > > > > > > [ 0.164527] init_kprobes+0x13c/0x154 > > > > > > [ 0.164968] do_one_initcall+0x54/0x2e0 > > > > > > [ 0.165322] kernel_init_freeable+0xf4/0x258 > > > > > > [ 0.165783] kernel_init+0x20/0x12c > > > > > > [ 0.166117] ret_from_fork+0x10/0x30 > > > > > > [ 0.166595] Code: 97ffff53 a9425bf5 17ffff9b f9001bf7 (d4210000) > > > > > > [ 0.167084] ---[ end trace 36778fdf576e9a79 ]--- > > > > > > > > > > > > To fix this, unlock the OS lock as early as possible. Do it in > > > > > > traps_init() for CPU0, since KGDB wants to use single-step from that > > > > > > point on according to commit b322c65f8ca3 ("arm64: Call > > > > > > debug_traps_init() from trap_init() to help early kgdb"). > > > > > > For secondary CPUs, setup the CPU hotplug handler at early_initcall. > > > > > > > > > > > > Fixes: 36dadef23fcc ("kprobes: Init kprobes in early_initcall") > > > > > > Signed-off-by: Jean-Philippe Brucker > > > > > > > > > > Hi Jean, > > > > > > > > > > How have you confirmed this fixes the issue? > > > > > On my environment, this doesn't fix the issue. > > > > > > > > Oops, it was my mistake. I missed to boot up with Xen. (so I find another bug...) > > > > Anyway this works for me too. > > > > > > No worries :) Although now I've been wondering whether it would be better > > > to just disable the OS lock lazily, on the first call to > > > enable_debug_monitors(). It might add a tiny performance penalty but would > > > avoid this problem reappearing if one of the debugger needs to start even > > > earlier in the future. > > > > I'm still uneasy about enabling KDE with the watchpoint registers in an > > unknown state, so I think this needs more work. > > Hmm, how we reset it in the early stage? reset watchpoint registers first? Yes, I think so. Same order problem as the OS lock, they need to be reset before enable_debug_monitors(). On CPU0 that would be before early_initcall and for secondaries the hotplug notifier needs to be installed earlier as well. I'll send a v2. Thanks, Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel