From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A198C4363A for ; Wed, 28 Oct 2020 11:30:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE41B246C3 for ; Wed, 28 Oct 2020 11:30:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="olCR3fbn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Oj55s1u+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE41B246C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u4BWn3/dviDeVlKnvuhChh7S73nCAh5ddEJm0Hju+XU=; b=olCR3fbnIGIVhFDdAP6nInYa/ CCpcD3cz3Ksl5D5fPPMDcjDL8GRN2ZDon2cH6IzxVn9qMK2LayuqmX/BQMNdsi6hAsoCXOgUeiIy7 N9Mljd7zDa2x8fiyUEE8gW5tkUvDqXM4086Y9bcGOeMzed2NGGlFUOKKtC6eF4N/K9t22cTI4L+BN Iwvi2vfg6VrGWrc1n0ApViS1B+oczZr3K1NxKhz6IZOhYymhK0gdSmlcx7HiEQK6zJZyQXuTX6liH l0LLj6FsmroAKDmAPONycHH+2jpWaVYAm5i+7G7ZGXu38i6l8/I9m9T82yRsOp684zpFvQFHyELxN DPHhRvreA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXjdv-0000NO-4O; Wed, 28 Oct 2020 11:29:27 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXjdr-0000Lm-Aw for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 11:29:24 +0000 Received: by mail-wm1-x344.google.com with SMTP id k18so4415623wmj.5 for ; Wed, 28 Oct 2020 04:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=WLWDWfUn62HuyKL78MLrBuM1P4gEN0IVPMugnmjyIpc=; b=Oj55s1u+HirbuDDCtgGf2TCwNQs1t7Hb/dfEAbtoX4rp6Vi9YOyYi0ZR6vyFEJnv46 srMzjKdpNzPMuK/b/uwsPoV8xLsInM+031sEoA5Uns+jUhqfFFLnA1zctrfKyId7XHGc IbDB6x5ghe+8hsKenVf6Dwci2fYo3m0yskyWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=WLWDWfUn62HuyKL78MLrBuM1P4gEN0IVPMugnmjyIpc=; b=ifmT2lU8gNDCOo4gVuJTgm+THgK6+OGTlWxDCosuixeFUiXg6JRyTBYHs2fHYPyuE5 161FrQ3otD1T7NKHcKwzspDaclhdJFaWK69DtZt0YsU/YN89rDlbQQPAhi0AFf7LdaJr JZEWfCknQo+Jhsb49qaJe2L61ZdIR8fwX17moEb1n7rMP4RQ9puB7YN3HPlJe8nuV50q CtepWiGGMP5z0weHzccbfR6A58BsFD7AylwMF3gnJvtW+99ELP5sGrW0NxBipIbvLnPO tBHAIo6KOhiKJtK9NpDjLKMJpqvO6WTEWn5WWnVXarzXTSly0yQc3VoJ5DXGPpIZ+JTk JiVg== X-Gm-Message-State: AOAM530/RcLFF3K1fgqtJW6XcXxuvexQ/31CwuSKN7NeY6q+519e7jay 58W5BuV/iTLA0V28/7LnnZYLzg== X-Google-Smtp-Source: ABdhPJz+EU8YlisomHF2zSjkLF+2zPf9qTQiMauCyQazYiNEgL02k8jKGZP/kZkcr+tV3wxSwpQU7g== X-Received: by 2002:a7b:cbc8:: with SMTP id n8mr7567498wmi.186.1603884560710; Wed, 28 Oct 2020 04:29:20 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id g5sm5698229wmi.4.2020.10.28.04.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 04:29:19 -0700 (PDT) Date: Wed, 28 Oct 2020 12:29:17 +0100 From: Daniel Vetter To: Maxime Ripard Subject: Re: [PATCH 1/1] drm/vc4: drv: Add error handding for bind Message-ID: <20201028112917.GW401619@phenom.ffwll.local> Mail-Followup-To: Maxime Ripard , Hoegeun Kwon , eric@anholt.net, airlied@linux.ie, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, dave.stevenson@raspberrypi.com, sungguk.na@samsung.com References: <20201027041442.30352-1-hoegeun.kwon@samsung.com> <20201027041442.30352-2-hoegeun.kwon@samsung.com> <20201027145431.zasv2oiydglz3n63@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201027145431.zasv2oiydglz3n63@gilmour.lan> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_072923_464776_134CF37B X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, sungguk.na@samsung.com, dave.stevenson@raspberrypi.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, eric@anholt.net, robh+dt@kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, daniel@ffwll.ch, Hoegeun Kwon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 27, 2020 at 03:54:31PM +0100, Maxime Ripard wrote: > Hi, > > On Tue, Oct 27, 2020 at 01:14:42PM +0900, Hoegeun Kwon wrote: > > There is a problem that if vc4_drm bind fails, a memory leak occurs on > > the drm_property_create side. Add error handding for drm_mode_config. > > > > Signed-off-by: Hoegeun Kwon > > Applied, thanks! Switching over to drmm_ version of this would also be good I think. Together with the devm_ version for allocating the drm_device you could delete a pile of that fragile cleanup code. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel