From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92AAAC55179 for ; Wed, 28 Oct 2020 14:05:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BF072475F for ; Wed, 28 Oct 2020 14:05:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lktw1fRu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="C7tthfxZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BF072475F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I6lQCT2WReeh47GelI3Hj98jXEGNNoTdvgipw3BJic4=; b=Lktw1fRuifC3Ga+4dbSA0uMfS 07m4RPNz2aIQ61/uXroC9zvJtoqj2dWUZ9t0qka9Ec3RwX306KE2shosScA8GQghbRvFpNgxWyreY ILkimTrdhRlOVZRNqiL/Ojc3AQSJbAtkQ9b/u835J8RUZ7zBnTOj9CjdyKFoLEJPJvTHoSt3szkU0 N3I1UvtPdLBdSjDviiuWeCeaeC2xkSY5GyfZwQDpgiI1csVK2KYT+ubQSsy2yUSGUkihiY2MiupwT ChdxVQBK3cOJDNBJH3sGx5DTXZbMEWMzN5omgWjCHcP/OrM3BaU0DaRSJVYj1Pe65oNEMvOvsdCyq g4h1gTIag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXm3O-0007J7-0k; Wed, 28 Oct 2020 14:03:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXm3L-0007Id-7R for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 14:03:52 +0000 Received: from linux-8ccs (p57a236d4.dip0.t-ipconnect.de [87.162.54.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1B8C2475C; Wed, 28 Oct 2020 14:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603893829; bh=R1GyTChVAmGg+2R9+tBK0PjVhy7YwXzx/I4+ar6G2AQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C7tthfxZkyl/7YNfwNwsVOxUyjePEstWObjwYTAN8tyVfQw5FDJC/k/vhGoTKrNV2 24ANd75f2WhA46GETZ4VHwhra41EFKU+U4n7WELg0XXR1qkT5yPVl+dxddNeDuhIP+ YQH797PbgWGXya9D+qKROz59G51WxwrLiZrKDz5A= Date: Wed, 28 Oct 2020 15:03:44 +0100 From: Jessica Yu To: Will Deacon Subject: Re: [PATCH] module: use hidden visibility for weak symbol references Message-ID: <20201028140344.GB6867@linux-8ccs> References: <20201027151132.14066-1-ardb@kernel.org> <20201028100049.GA27873@willie-the-truck> <20201028132437.GA28251@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201028132437.GA28251@willie-the-truck> X-OS: Linux linux-8ccs 4.12.14-lp150.12.61-default x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_100351_445791_B22BC0EC X-CRM114-Status: GOOD ( 35.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Catalin Marinas , Nick Desaulniers , Linux Kernel Mailing List , Geert Uytterhoeven , Ard Biesheuvel , Linux ARM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +++ Will Deacon [28/10/20 13:24 +0000]: >On Wed, Oct 28, 2020 at 01:27:01PM +0100, Ard Biesheuvel wrote: >> On Wed, 28 Oct 2020 at 11:00, Will Deacon wrote: >> > On Tue, Oct 27, 2020 at 04:11:32PM +0100, Ard Biesheuvel wrote: >> > > Geert reports that commit be2881824ae9eb92 ("arm64/build: Assert for >> > > unwanted sections") results in build errors on arm64 for configurations >> > > that have CONFIG_MODULES disabled. >> > > >> > > The commit in question added ASSERT()s to the arm64 linker script to >> > > ensure that linker generated sections such as .got, .plt etc are empty, >> > > but as it turns out, there are corner cases where the linker does emit >> > > content into those sections. More specifically, weak references to >> > > function symbols (which can remain unsatisfied, and can therefore not >> > > be emitted as relative references) will be emitted as GOT and PLT >> > > entries when linking the kernel in PIE mode (which is the case when >> > > CONFIG_RELOCATABLE is enabled, which is on by default). >> > > >> > > What happens is that code such as >> > > >> > > struct device *(*fn)(struct device *dev); >> > > struct device *iommu_device; >> > > >> > > fn = symbol_get(mdev_get_iommu_device); >> > > if (fn) { >> > > iommu_device = fn(dev); >> > > >> > > essentially gets converted into the following when CONFIG_MODULES is off: >> > > >> > > struct device *iommu_device; >> > > >> > > if (&mdev_get_iommu_device) { >> > > iommu_device = mdev_get_iommu_device(dev); >> > > >> > > where mdev_get_iommu_device is emitted as a weak symbol reference into >> > > the object file. The first reference is decorated with an ordinary >> > > ABS64 data relocation (which yields 0x0 if the reference remains >> > > unsatisfied). However, the indirect call is turned into a direct call >> > > covered by a R_AARCH64_CALL26 relocation, which is converted into a >> > > call via a PLT entry taking the target address from the associated >> > > GOT entry. >> > > >> > > Given that such GOT and PLT entries are unnecessary for fully linked >> > > binaries such as the kernel, let's give these weak symbol references >> > > hidden visibility, so that the linker knows that the weak reference >> > > via R_AARCH64_CALL26 can simply remain unsatisfied. >> > > >> > > Cc: Jessica Yu >> > > Cc: Kees Cook >> > > Cc: Geert Uytterhoeven >> > > Cc: Nick Desaulniers >> > > Signed-off-by: Ard Biesheuvel >> > > --- >> > > include/linux/module.h | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > Cheers. I gave this a spin, but I unfortunately still see the following >> > linker warning with allnoconfig: >> > >> > aarch64-linux-gnu-ld: warning: orphan section `.igot.plt' from `arch/arm64/kernel/head.o' being placed in section `.igot.plt' >> > >> > which looks unrelated to symbol_get(), but maybe it's worth knocking these >> > things on the head (no pun intended) at the same time? >> > >> >> Yeah, that is just one of those spurious sections that turns up empty >> anyway. The head.o is a red herring, it is simply the first file >> appearing in the link. >> >> This should fix it >> >> diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S >> index 6567d80dd15f..48b222f1c700 100644 >> --- a/arch/arm64/kernel/vmlinux.lds.S >> +++ b/arch/arm64/kernel/vmlinux.lds.S >> @@ -278,7 +278,7 @@ SECTIONS >> * explicitly check instead of blindly discarding. >> */ >> .plt : { >> - *(.plt) *(.plt.*) *(.iplt) *(.igot) >> + *(.plt) *(.plt.*) *(.iplt) *(.igot .igot.plt) >> } >> ASSERT(SIZEOF(.plt) == 0, "Unexpected run-time procedure >> linkages detected!") > >Cheers, that fixes the extra warning for me. If you could send a proper >patch, I'm happy to queue as an arm64 fix! (I'm assuming the former is going >via Jessica, but I can also take that with her Ack). Hi! Yes, please feel free to take this patch along with the other fix: Acked-by: Jessica Yu Thanks, Jessica _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel