Re: [PATCH 1/4] dt-bindings: opp: Introduce opp-sustainable bindings

Lukasz Luba
2020-11-02T08:41:38Z

Hi Rob,

On 10/30/20 7:34 PM, Rob Herring wrote:
> On Wed, Oct 28, 2020 at 02:08:44PM +0000, Lukasz Luba wrote:
>> Add opp-sustainable as an additional property in the OPP node to describe
>> the sustainable performance level of the device. This will help to
>> estimate the sustainable performance of the whole system.
>>
>> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
>> ---
>> Documentation/devicetree/bindings/opp/opp.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
>> index 9847dfeeffcb..cd01028de305 100644
>> --- a/Documentation/devicetree/bindings/opp/opp.txt
>> +++ b/Documentation/devicetree/bindings/opp/opp.txt
>> @@ -154,6 +154,10 @@ Optional properties:
>> - opp-suspend: Marks the OPP to be used during device suspend. If multiple OPPs
>> in the table have this, the OPP with highest opp-hz will be used.
>>
>> +- opp-sustainable: Marks the OPP as sustainable. This property can be used for
>> + estimating sustainable performance of the whole system. If multiple OPPs in
>> + the table have this, the OPP with highest opp-hz will be used.
>> +
>
> Isn't this just the inverse of the turbo? or boost? flag we already
> have?

True, it could be possible to use those flags. Then a function which
returns one OPP below, would be 'sustainable'. I've already
suggested to skip binding and only have get/set functions for OPP
framework to mark 'sustainable' level, but Viresh is against.
We have discussed this new opp sustainable with Viresh and since it
would be only used by IPA but the definition is a bit blurry,
we decided to drop this series. Maybe in future when there will be
another user, we will come back to this.
I am going to use Energy Model and mark the em_perf_state as sustained.

>
> Couldn't this be learned? I ran at this frequency and then overheated.
> That could be dependent on ambient temperatures or dust build up on
> fans/heatsink.

Yes it could be learned. IPA tries to do that for different workloads,
but it needs some starting conditions (coefficients and sustainable
power) to converge in short time. Sustainable power is currently
estimated based on lowest OPP. With that new 'sustainable' flag,
it would be much easier for IPA to converge.

Regards,
Lukasz

>
> Rob