From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06905C55179 for ; Thu, 29 Oct 2020 14:31:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 844082151B for ; Thu, 29 Oct 2020 14:31:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="esqiqPzQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L9Ve7M9g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 844082151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+hdl5eLIB1CdIUJQxjd0Fq95Y5fDXzV041ByKC/FZRE=; b=esqiqPzQ8Zk65ZS7NWjr9ba3i gaaqPaiHrT0Nbcsgfp/JcaYUklJRjNgZ5R5qMkVFNYi74GKQWt5PDNFq++I4Myahh4/ZpF59ZLXqu h9sdSBTINPzaDgfGWMvKJTK9Eax63k8jErAhKnCtf5aTApA9lZw3R5apJE6M/jxEm9cmUCEVRhsOM b9Cs6jtGBCikATXk76sx2FYbPbed/Yw/iqFN+7F+meD/xP6jGn/B7y4NjoOuZDs3CdsIQtMGBNz6X EH64mLTQ/ewwb1RbxhIKE21XmtSuDS6TTMOoJmAOO+3MfH2B2JKrJ/xAMTQ7FiiktbTJhfUqGbVzy i+PFKkmPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY8xP-0007Tl-Qy; Thu, 29 Oct 2020 14:31:16 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY8xN-0007Sj-D5 for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 14:31:14 +0000 Received: by mail-pl1-x642.google.com with SMTP id j5so1378392plk.7 for ; Thu, 29 Oct 2020 07:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yGfVt0L4ftOqQYvVzpLAMtyqzm24yEPmmaeuYJHdcF4=; b=L9Ve7M9gsRbGmqPW4y2GbZH/PW9XpRBJKr8bcNLgo2jmnTrKJveNfyczvv9XTx+HUl YLInTPvtZFmjrEtguEph+0OATtBpSK8kwKDRVeByBXdRw0Buz+0hoaCPQT3R16L/79Yo j2u3swusX6/w6211/RM5QFW6qgwWkr0uCufzlloq+m9sBQ6S/+YCJgMjBnxeO8POZKcm GDWaaJnhiw4daofmYDRX9oZ4ehcZgPyqljtuIP8TlUBc9WWSKvz+hBiKPtri9cR0I/EM X0BoWxpLqADftyN/1V/sAG0fokCqb0gmHPn/edQDvwR53UdSASGvA7sXOUjA/L/o9sXm RMqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yGfVt0L4ftOqQYvVzpLAMtyqzm24yEPmmaeuYJHdcF4=; b=uOeTeyxVbSur6DU+RERCFiSe+sqyrj7SF1SKdXNxcePzwe2IZOJRbYUezCvu6uW2hX N4knB//1fM1FIvNvSMs3SJ4m6PYtfAo+LfPNfe+ZOUmA8we1KrcrY/ASTE+0r4r6AzJl kFVk4aviPDHce4Y/kQIW8ytOL9sYAsAIhkznjVEc9NbHpn3XGIiz2gcKB4k7uw++wEpB Pm2lFkMfinDf9veYN2YeY7pyv1HadPCdUxp3jV1j7zIZb5ESbP3h33fvHFxs4zKmZJVa qVHg4OLVDtLTBT+aFTr3/OuCN/sWk/ws/GPDyZ5lEPVHDP8bh6Qcwc2DyAS3hsPH9fMS GnAg== X-Gm-Message-State: AOAM532YpR1R1Va/PpqvJMXu5AWfRgE+p+RWnx7x5KPnlj3veuTI2F89 WKjTGkl5PB2GkPqVPt8TJsY= X-Google-Smtp-Source: ABdhPJx5yXpyzx2qbpNT/+t79uGRA4TnLTSZjBRsP0DnQS9c1W8oAAwcmW263hQYx6j5y/UQ3EDlpA== X-Received: by 2002:a17:902:a50f:b029:d6:da2:aaa7 with SMTP id s15-20020a170902a50fb02900d60da2aaa7mr4686870plq.42.1603981871290; Thu, 29 Oct 2020 07:31:11 -0700 (PDT) Received: from localhost ([2409:8a28:3c42:6840:9efc:e8ff:fef2:1cdc]) by smtp.gmail.com with ESMTPSA id p12sm2776972pgm.29.2020.10.29.07.31.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 07:31:10 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 29 Oct 2020 22:18:57 +0800 To: Fabrice Gasnier Subject: Re: [PATCH 5/5] i2c: stm32: remove unnecessary CONFIG_PM_SLEEP Message-ID: <20201029141857.hts77kneb3j7aa67@Rk> References: <20201029074654.227263-1-coiby.xu@gmail.com> <20201029074654.227263-5-coiby.xu@gmail.com> <699f4908-1ea1-6075-3375-7f1dfc6fb225@st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <699f4908-1ea1-6075-3375-7f1dfc6fb225@st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_103113_483750_C542172A X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , open list , Pierre-Yves MORDRET , Alain VOLMAT , linux-i2c@vger.kernel.org, Maxime Coquelin , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabrice, On Thu, Oct 29, 2020 at 12:31:54PM +0100, Fabrice Gasnier wrote: >On 10/29/20 8:46 AM, Coiby Xu wrote: >> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. >> >> Signed-off-by: Coiby Xu >> --- >> drivers/i2c/busses/i2c-stm32f7.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c >> index f41f51a176a1..95ac9dfdf458 100644 >> --- a/drivers/i2c/busses/i2c-stm32f7.c >> +++ b/drivers/i2c/busses/i2c-stm32f7.c >> @@ -2262,7 +2262,6 @@ static int __maybe_unused stm32f7_i2c_runtime_resume(struct device *dev) >> return 0; >> } >> >> -#ifdef CONFIG_PM_SLEEP > >Hi Coiby, > >This generates warnings when building with W=1 and CONFIG_PM_SLEEP=n. >Could you please add also "__maybe_unused" for relevant routines below ? > >> static int stm32f7_i2c_regs_backup(struct stm32f7_i2c_dev *i2c_dev) > ^ >e.g. insert: __maybe_unused > Thank you for the suggestion. I'll add "__maybe_unused" in v2. >Best regards, >Fabrice >> { >> int ret; >> @@ -2356,7 +2355,6 @@ static int stm32f7_i2c_resume(struct device *dev) >> >> return 0; >> } >> -#endif >> >> static const struct dev_pm_ops stm32f7_i2c_pm_ops = { >> SET_RUNTIME_PM_OPS(stm32f7_i2c_runtime_suspend, >> -- Best regards, Coiby _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel