From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F11BC4363A for ; Thu, 29 Oct 2020 14:31:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DC002151B for ; Thu, 29 Oct 2020 14:31:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1hEWcfeF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EN2kcQVa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DC002151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OxlAD9+jY7WpGbW5iP24+PiaC8EGOrE+z72U//o9jZE=; b=1hEWcfeFPQA5m7BKVd3Vr0NQb PElxFeGSjBtapUptW9q5HycOnwc0FoQI7TzTisDzyiasFPDBk6okd3QIftWWdEARMGS/3XngdA4CQ iAWAD4c3VX3YRp/tqmyhr/AcTcKQii2mIQTSWmbBg33++TTGHJM3xeFimNp7hmiJqQZk9x5eAz+W0 3OFDWLJqcFgd2hL/Pc4Ednj0YU3aU4f4kMXHNoeVcqeAvxtAdLc0rwQ2efyX/qx249fln85Qq76cw CiOWFkL748VZTB9645Wj0UExicEmqnOtpVrWqXt+KOU6Ey5ebadaAlEw3sv32U5L0SdAFK9jUsskO 7FrkzBXHw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY8xV-0007Uf-2q; Thu, 29 Oct 2020 14:31:21 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY8xS-0007Tv-GI; Thu, 29 Oct 2020 14:31:19 +0000 Received: by mail-pf1-x441.google.com with SMTP id w21so2473813pfc.7; Thu, 29 Oct 2020 07:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wLslsAi2G28LH9YJ0zfY79HW10N4bzzwRkzXCVZRDwY=; b=EN2kcQVa32mEd/K4hOG8By0UDzPzo+BftuvRI8L1lXA7v0f6Btzj8FmrVO4rRyiMnK o3v+rD6VTjsm40RtPPixW0a84KVo4k5qIs+5/TpNBLdhvrMF2NiO5KVnWk5rD3hGhxXe 9ehk+yumZOOzJ/acHlyz8JZhgsLBgNAZWIWUjQM6EyEK1eZidelPFpddHofdrvsX7FdI WRam8PpMVC+lBGXVptAk2oQ9PCVTCm74PotHP+/0BDKlsWxwilH2qDcrrhVbY0b+ctBM FktMFpMxgQqIyP7S4uCM3UUfhSv32Yjc6UI+uDTnnivwEAXL8+O4exIuHTxhkRll/cdq 7W9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wLslsAi2G28LH9YJ0zfY79HW10N4bzzwRkzXCVZRDwY=; b=RpIRJ949Ju54Ra1QfI0TvTn2yMFuuS5dvJDzMAOltbAhLhcM4OxXmKjTpkQHHMupQn k6F5qLzfCtBFWxrUYTaS62oX/+EvACEUjkc9DDmWZl93jJW6a4Ld3MgOOgBcVrfeIF6O Ayw6l44GH4K01f4JnC2qZAIjGHoMAU1t3zSqIq0ukIzgkCuPTsl8iaRaR4F9sTC/La2e HHRFiojRf2YESC+eZsk8/ft0XJQlsaC5o2gmIzJ14qgGvuejXddte6Wy/cVPqx24bgFd mpAL2yODDiPGXMXd547S9zJkte2bHECxiKrxlr/e9Ww/2rhUddIOwABZdyueq7VZ6F4I 0Hjg== X-Gm-Message-State: AOAM533MMaTea8yUhlZc+SUnX8xdMYNDBLLq204FZx5shNFcIVyL9XDI sMbIUBKCq4pfhQJugBILON5aOrWrrFabL1+g X-Google-Smtp-Source: ABdhPJy0sr40Jhllz/XQxRR+IEcDDKRuW5TxBqDWR9ZWN1OmyVVdN4IBmHlTPx+KqBxsvCtsYSKtYw== X-Received: by 2002:a65:62ca:: with SMTP id m10mr4245650pgv.407.1603981876521; Thu, 29 Oct 2020 07:31:16 -0700 (PDT) Received: from localhost ([2409:8a28:3c42:6840:9efc:e8ff:fef2:1cdc]) by smtp.gmail.com with ESMTPSA id b3sm3047003pfd.66.2020.10.29.07.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 07:31:16 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 29 Oct 2020 22:23:25 +0800 To: Robin Murphy Subject: Re: [PATCH 04/25] ASoC: rockchip: remove unnecessary CONFIG_PM_SLEEP Message-ID: <20201029142325.mhq6azowlyuurhtl@Rk> References: <20201029074301.226644-1-coiby.xu@gmail.com> <20201029074301.226644-4-coiby.xu@gmail.com> <8589f68f-fa6b-d75e-d7be-fbb354adbde0@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8589f68f-fa6b-d75e-d7be-fbb354adbde0@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_103118_669573_60A12D5E X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Heiko Stuebner , open list , Liam Girdwood , Takashi Iwai , "open list:ARM/Rockchip SoC support" , Mark Brown , Jaroslav Kysela , "moderated list:ARM/Rockchip SoC support" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 29, 2020 at 10:33:52AM +0000, Robin Murphy wrote: >On 2020-10-29 07:42, Coiby Xu wrote: >>SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. > >I don't see anything in the !CONFIG_PM_CONFIG side of >SET_SYSTEM_SLEEP_PM_OPS() that prevents unused function warnings for >the callbacks - does this change depend on some other patch or is it >just wrong? > Thank you for the feedback! I'll add "__maybe_unused" in v2. >Robin. > >>Signed-off-by: Coiby Xu >>--- >> sound/soc/rockchip/rockchip_pdm.c | 2 -- >> 1 file changed, 2 deletions(-) >> >>diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c >>index 5adb293d0435..f3c19310aeeb 100644 >>--- a/sound/soc/rockchip/rockchip_pdm.c >>+++ b/sound/soc/rockchip/rockchip_pdm.c >>@@ -574,7 +574,6 @@ static int rockchip_pdm_remove(struct platform_device *pdev) >> return 0; >> } >>-#ifdef CONFIG_PM_SLEEP >> static int rockchip_pdm_suspend(struct device *dev) >> { >> struct rk_pdm_dev *pdm = dev_get_drvdata(dev); >>@@ -601,7 +600,6 @@ static int rockchip_pdm_resume(struct device *dev) >> return ret; >> } >>-#endif >> static const struct dev_pm_ops rockchip_pdm_pm_ops = { >> SET_RUNTIME_PM_OPS(rockchip_pdm_runtime_suspend, >> -- Best regards, Coiby _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel