From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 002F2C55179 for ; Thu, 29 Oct 2020 19:10:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D37B2075E for ; Thu, 29 Oct 2020 19:10:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zS4LjXjA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Uk6TyvBZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D37B2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=myS27BoFBUOmaCxNjOuKj53KCwRLlsdMN1ms5wzgB50=; b=zS4LjXjAWbS8snffBYlvMp/CR fCKvt6jZAMXQSTFr+FMGNH43ox+sOdP8OFI1kekXpfqt3HFIysUC93fXPTZK4Ob2TWFhq/S4VKcH5 64ppviPGP/kpI67gl9SGomPeXaBX2Eg3hedfeOiFrKp6r3crvIjksPkGDVxBtUpbytGN4PtDTZpP6 B9JIst1KQhlPRMoV2JEugmhDkEr6FzkyrNIxLI0t90f0zDvo48SjSuDdetb8DTqfDOUW/xluEE7ro 5Pfr8LBEw85K7lFXB4vIofJ9XFPXHrQyjM9S48zCal5N+Rdi3loma+KBC5qKkQABhsAvKnOm6IMRU 36loSbWmA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYDId-0004VM-6C; Thu, 29 Oct 2020 19:09:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYDIa-0004Uc-Io for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 19:09:25 +0000 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B730020756; Thu, 29 Oct 2020 19:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603998563; bh=Pt6WFzMLYTX0xhEREmX9YvFBIhL4r4F+3MKqRLIaqbQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uk6TyvBZKB9y7WjP0zclRkEjbT/gg4W0oGC0Me1DwJERMBFa8/UaqvyCm0d2R8LLY 7+NxOIT4l25TEkcWGM9v581sCaVX2tcENARVb3QwLW8ot3qEOfUhC1A1dkY5zjc4UQ 26j1wSDsT5SkfWUi9XlrSzudIcC8wrbRh+EGtj6Q= Date: Thu, 29 Oct 2020 20:10:11 +0100 From: Greg KH To: Mathieu Poirier Subject: Re: [PATCH 1/2] coresight: cti: Initialize dynamic sysfs attributes Message-ID: <20201029191011.GA826513@kroah.com> References: <20201029164559.1268531-1-mathieu.poirier@linaro.org> <20201029164559.1268531-2-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201029164559.1268531-2-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_150924_814684_4EF0F43C X-CRM114-Status: GOOD ( 22.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 29, 2020 at 10:45:58AM -0600, Mathieu Poirier wrote: > From: Suzuki K Poulose > > With LOCKDEP enabled, CTI driver triggers the following splat due > to uninitialized lock class for dynamically allocated attribute > objects. > > [ 5.372901] coresight etm0: CPU0: ETM v4.0 initialized > [ 5.376694] coresight etm1: CPU1: ETM v4.0 initialized > [ 5.380785] coresight etm2: CPU2: ETM v4.0 initialized > [ 5.385851] coresight etm3: CPU3: ETM v4.0 initialized > [ 5.389808] BUG: key ffff00000564a798 has not been registered! > [ 5.392456] ------------[ cut here ]------------ > [ 5.398195] DEBUG_LOCKS_WARN_ON(1) > [ 5.398233] WARNING: CPU: 1 PID: 32 at kernel/locking/lockdep.c:4623 lockdep_init_map_waits+0x14c/0x260 > [ 5.406149] Modules linked in: > [ 5.415411] CPU: 1 PID: 32 Comm: kworker/1:1 Not tainted 5.9.0-12034-gbbe85027ce80 #51 > [ 5.418553] Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) > [ 5.426453] Workqueue: events amba_deferred_retry_func > [ 5.433299] pstate: 40000005 (nZcv daif -PAN -UAO -TCO BTYPE=--) > [ 5.438252] pc : lockdep_init_map_waits+0x14c/0x260 > [ 5.444410] lr : lockdep_init_map_waits+0x14c/0x260 > [ 5.449007] sp : ffff800012bbb720 > ... > > [ 5.531561] Call trace: > [ 5.536847] lockdep_init_map_waits+0x14c/0x260 > [ 5.539027] __kernfs_create_file+0xa8/0x1c8 > [ 5.543539] sysfs_add_file_mode_ns+0xd0/0x208 > [ 5.548054] internal_create_group+0x118/0x3c8 > [ 5.552307] internal_create_groups+0x58/0xb8 > [ 5.556733] sysfs_create_groups+0x2c/0x38 > [ 5.561160] device_add+0x2d8/0x768 > [ 5.565148] device_register+0x28/0x38 > [ 5.568537] coresight_register+0xf8/0x320 > [ 5.572358] cti_probe+0x1b0/0x3f0 > > ... > > Fix this by initializing the attributes when they are allocated. > > Fixes: 3c5597e39812 ("coresight: cti: Add connection information to sysfs") > Reported-by: Leo Yan > Tested-by: Leo Yan > Cc: Mike Leach > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > Signed-off-by: Mathieu Poirier > --- > drivers/hwtracing/coresight/coresight-cti-sysfs.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > index 392757f3a019..7ff7e7780bbf 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > @@ -1065,6 +1065,13 @@ static int cti_create_con_sysfs_attr(struct device *dev, > } > eattr->var = con; > con->con_attrs[attr_idx] = &eattr->attr.attr; > + /* > + * Initialize the dynamically allocated attribute > + * to avoid LOCKDEP splat. See include/linux/sysfs.h > + * for more details. > + */ > + sysfs_attr_init(con->con_attrs[attr_idx]); > + > return 0; > } Should go to stable kernels too, as the patch this fixes is in 5.7. I'll add the stable tag here, but feel free to do it yourself next time :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel