From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E534C4363A for ; Thu, 29 Oct 2020 19:17:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 962E82075E for ; Thu, 29 Oct 2020 19:17:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J9p68BlL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 962E82075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OsYh5hsRiYP9hzXnLFmRYHhkAkXXJ1O85mnFSMKz2H8=; b=J9p68BlL3peFF1z1C+Mqp0/5y KwGafGnGpHoYpSufw6d4dej6XJIePQgSD1OyNY6pgvsx+4M6ij5ekppHbGNoC540iLu294hkVD8eJ LGOlX4nKMFdXM1AemqbPQthKHRdi9THGTP3NxkoJzPE7wfBMNxU+U3X3CUhOzdfhbJbet4RKUllIw oF6g1iXBUxk3qYEgUm47/qFwNW/exVeXknr6izASmOvmsI7p8zDZ8p7+LyAjfkukdYcPKZuYSsJ2n e9+u0jNO3ZO79+/qY9EdumS1rbbQ5XRXGqfOOY+Q+LdGGNrREhsbH6+Patks9Xw57n4u0yXs1HGMI w8DOf5fNQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYDPn-0005LY-RW; Thu, 29 Oct 2020 19:16:51 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYDPl-0005KW-HL for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 19:16:50 +0000 Received: by mail-ed1-f66.google.com with SMTP id k9so4212193edo.5 for ; Thu, 29 Oct 2020 12:16:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mmqY+Yeiy9nDKcqsSPAuyb++V3pyCtvEqsSBbBln3ps=; b=DDc/1CmOOrNduQRd5LLLiMdhGFRazhrUJtws+8tpi9jrIARoc/ac5l80p0U8oZ+DT7 cOJyBqOiCXRrKewGd2cb9FyKefw3bMvYGqGTPPyWvfRSlNlbYCpM9FkQOvtOQglgzKwh +HK3zv22PLd+pRLJftSMCf/zhcX5gH2/2Fxlk4odOqDiuC3TVTuhXwcq5/+PndVlntOe c4UdsHRLJh6YDnx2UC1ERoJpNwzwC1UrdrggReZjiKKWu+tjAlefcW1RXRlLYBeHJyuV wes+csXyM7wz/zmzRtlYluxXMv9/Xr0Ah1g8lJROpduPfexY9OuwEt/yqts0EXdrOJOt 5HFA== X-Gm-Message-State: AOAM5317FBQmxrrQjbbqSFxIjxVHGz+HnzaeTdYRzQKwqry9G3EOIati AcbtzL6guncISVT1VEXZpvw= X-Google-Smtp-Source: ABdhPJwrfkpQ2JuPFKdrfXz62k6W9divKfUT133kCeLPI66bfIuJh41eOM+GKvaMJw7/hRbB+e24/Q== X-Received: by 2002:aa7:c98f:: with SMTP id c15mr5804762edt.200.1603999007865; Thu, 29 Oct 2020 12:16:47 -0700 (PDT) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id n3sm2033380edq.24.2020.10.29.12.16.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 12:16:46 -0700 (PDT) Date: Thu, 29 Oct 2020 20:16:45 +0100 From: Krzysztof Kozlowski To: Shengjiu Wang Subject: Re: [PATCH 2/2] arm64: dts: imx8mq-evk: Add spdif sound card support Message-ID: <20201029191645.GA308501@kozik-lap> References: <1603964844-832-1-git-send-email-shengjiu.wang@nxp.com> <1603964844-832-2-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1603964844-832-2-git-send-email-shengjiu.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_151649_613368_6E69073F X-CRM114-Status: GOOD ( 18.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 29, 2020 at 05:47:24PM +0800, Shengjiu Wang wrote: > There are two spdif IP on imx8mq, spdif1 is for normal > spdif device, spdif2 is for HDMI ARC interface. > > Enable these spdif sound card in this patch. > > Signed-off-by: Shengjiu Wang > --- > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 38 ++++++++++++++++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 48 ++++++++++++++++++++ > 2 files changed, 86 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > index 2418cca00bc5..e4250812586b 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > @@ -87,6 +87,21 @@ link_codec: simple-audio-card,codec { > clocks = <&clk IMX8MQ_CLK_SAI2_ROOT>; > }; > }; > + > + sound-spdif { > + compatible = "fsl,imx-audio-spdif"; > + model = "imx-spdif"; > + spdif-controller = <&spdif1>; > + spdif-out; > + spdif-in; > + }; > + > + sound-hdmi-arc { > + compatible = "fsl,imx-audio-spdif"; > + model = "imx-hdmi-arc"; > + spdif-controller = <&spdif2>; > + spdif-in; > + }; > }; > > &A53_0 { > @@ -336,6 +351,22 @@ &snvs_pwrkey { > status = "okay"; > }; > > +&spdif1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_spdif1>; > + assigned-clocks = <&clk IMX8MQ_CLK_SPDIF1>; > + assigned-clock-parents = <&clk IMX8MQ_AUDIO_PLL1_OUT>; > + assigned-clock-rates = <24576000>; > + status = "okay"; > +}; > + > +&spdif2 { > + assigned-clocks = <&clk IMX8MQ_CLK_SPDIF2>; > + assigned-clock-parents = <&clk IMX8MQ_AUDIO_PLL1_OUT>; > + assigned-clock-rates = <24576000>; > + status = "okay"; > +}; > + > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart1>; > @@ -467,6 +498,13 @@ MX8MQ_IOMUXC_GPIO1_IO08_GPIO1_IO8 0xd6 > >; > }; > > + pinctrl_spdif1: spdif1grp { > + fsl,pins = < > + MX8MQ_IOMUXC_SPDIF_TX_SPDIF1_OUT 0xd6 > + MX8MQ_IOMUXC_SPDIF_RX_SPDIF1_IN 0xd6 > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX8MQ_IOMUXC_UART1_RXD_UART1_DCE_RX 0x49 > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 49cc79246288..c94b2f80880f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -793,6 +793,30 @@ bus@30800000 { /* AIPS3 */ > ranges = <0x30800000 0x30800000 0x400000>, > <0x08000000 0x08000000 0x10000000>; > > + spdif1: spdif@30810000 { > + compatible = "fsl,imx8mq-spdif", "fsl,imx35-spdif"; This is an undocumented compatible. Checkpatch should point this out. If this patchset depends on others, please describe it in cover letter or after '---' separator. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel