From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3563C4363A for ; Thu, 29 Oct 2020 19:25:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3486120782 for ; Thu, 29 Oct 2020 19:25:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BZqL8mxx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3486120782 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zA2Eh85WdZOFYVAIym+NpgtsNSvUKFMcAoSitXlBmgo=; b=BZqL8mxxXHwJ6KsruysLHOfMw vdoaL2JRV5KzE217cIVp/c4ynb2RXNvWYxo+VT0n8wa7+16zdPhNJkKbSFFlnyBSEAZp1dHO7FWeO Rho7qzE9KAZMGvhLP6BvpNvl4o2gVMkiNYyVaQ8GEoVqNT8gex7+gnWCEilBa04AstWf3iQBuic+u yQkMAutrlc4ZNRz3Td0U+nT8p+YENylDP2qDwUhhPZ2pM3A6IHDpqOeXGgSsst5qQd8YwKUfTn0+z 3Iq1Nmeczg6/rQJTuheWHjkOB+h1XBCqJXa3EgIdM4ZzAoJ625AQDKemXdJPZvjT/mWR7DUTOzSpi WPeIAwZ5g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYDXO-0006OL-BS; Thu, 29 Oct 2020 19:24:42 +0000 Received: from mail-ej1-f67.google.com ([209.85.218.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYDXM-0006Nx-Eb for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 19:24:41 +0000 Received: by mail-ej1-f67.google.com with SMTP id p9so5399886eji.4 for ; Thu, 29 Oct 2020 12:24:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=na9861zvKblYf7ep02+TOiwBVQurVwpRiruVXN88s4s=; b=BrmdpYogAO8ezxLFIz62pGeRLn29rBURB7VDO0y0nQkV39JkaUtMGy+VxkSAcSzC0b DUNow1qa4M6FaP8ZnGv0ZGOs9VorKlLuRIOEthZxGORPKulqtm1Aax9qWi0HLUKCi9jA pWgORvdVCypFllRHoyISKCW/lxOoE2KknliRGTSnDNSky3U4wRBxO/QBEALbRZhX6oNA 3bp5MLmw628d01/8+e/yql8/bZkZRcpU0FsvCZJv/QYy34EnMyv9FxwcM7bFK4Fky8wm wB/4bdKvcBxSPg7euC/5x5Zh7AI5IrRGYt1nHbz5VjI3VD3a4P+6gqr1hjshlWm2sLu7 IM6A== X-Gm-Message-State: AOAM531450coSBYG23URDXHd+BEkFZjME68iyypqrovZZj2iyyL4NCHs dHYgU8KL01CS/yOwQN8ZHf0= X-Google-Smtp-Source: ABdhPJzB9KT5TbeTYxKSFEl6Fns3ceKUsdLvWJoSB5ZkN1ehwSpJWfCN82qTQTPElYeou9wVCwNhqA== X-Received: by 2002:a17:906:1614:: with SMTP id m20mr5528468ejd.258.1603999478926; Thu, 29 Oct 2020 12:24:38 -0700 (PDT) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id dp1sm1965399ejc.74.2020.10.29.12.24.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 12:24:37 -0700 (PDT) Date: Thu, 29 Oct 2020 20:24:36 +0100 From: Krzysztof Kozlowski To: Adam Ford Subject: Re: [PATCH] arm64: dts: imx8mm: Add support for micfil Message-ID: <20201029192436.GB308501@kozik-lap> References: <20200502125949.194032-1-aford173@gmail.com> <20200502125949.194032-2-aford173@gmail.com> <20200520010348.GE11739@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_152440_512978_FC804392 X-CRM114-Status: GOOD ( 26.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Will Deacon , Fabio Estevam , Sascha Hauer , aford@beaconemedded.com, Linux Kernel Mailing List , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Catalin Marinas , Shawn Guo , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 28, 2020 at 07:10:37AM -0500, Adam Ford wrote: > On Tue, May 19, 2020 at 8:03 PM Shawn Guo wrote: > > > > On Sat, May 02, 2020 at 07:59:48AM -0500, Adam Ford wrote: > > > The i.MX8M Mini has supports the MICFIL digital interface. > > > It's a 16-bit audio signal from a PDM microphone bitstream. > > > The driver is already in the kernel, but the node is missing. > > > > > > This patch adds the micfil node. > > > > > > Signed-off-by: Adam Ford > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > index c63685ae80ee..d46e727fc362 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > @@ -339,6 +339,25 @@ sai6: sai@30060000 { > > > status = "disabled"; > > > }; > > > > > > + micfil: micfil@30080000 { > > > > Find a generic node name, audio-controller maybe? > > The SAI's nodes are called SAI@xxxx > > If that's a deal-breaker, I can push a V3. > > I didn't see anyone from the device tree side comment, and the device > tree binding doc states 'micfil@xxxxxx' so I used what was documented > in the fsl,micfil.txt Hi, The example in the binding is not a binding itself. It can be misleading or even incorrect and it is not a reason to use such in DTS. Could be also audio-codec but it is not accurate (as it is only from the microphone to digital). Shawn's proposal is the best, I think. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel