From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 145D8C00A89 for ; Fri, 30 Oct 2020 09:07:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CD7E206DB for ; Fri, 30 Oct 2020 09:07:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="adhmgCkY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KefjnyhY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CD7E206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xHmze7D5+ChXYdjYwNi3aAUkhS4tkSeQQ4Y4feTk50M=; b=adhmgCkYffTeeOuBkE5xZiO3x xKQNI8IQu+XK0i+rwZzYnvFXPsxmVv791Ds7jDM7hXnK2G9CdGREb8/+0Tm1/wWKVDdoohKLmyR1f Tmzpt+l/Jm4E/dN+r9XMN+2BKrcoA/eJq58cDWAjEk/Qreu479Ahp155eQvihdZfCP5nQex5rfasr cw/rb55f7e1zM+UYBVwgO3Nm+bQUwumLOVNgO9XxxEbfle9LDrrMw8PRa09Fsn+3eIxP9bhV4H1Do jAGpo+S5ks76vcvgFzUA7WKID6AVUCYAnLetQamU4pqMu2rHSHSh9elN2L2ijslyupfGDqX3TQYRs t0pBp0irA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYQMg-0003NO-DW; Fri, 30 Oct 2020 09:06:30 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYQMd-0003MI-4Y; Fri, 30 Oct 2020 09:06:27 +0000 Received: by mail-io1-xd43.google.com with SMTP id z5so6778354iob.1; Fri, 30 Oct 2020 02:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ajoTgRnqXmGr4NGz4sDpf2t3leA2CkfA49rjJDDlhoM=; b=KefjnyhYCfoYAm8EPLwzn8mn34N7B1TMaMJeF/wDuWddo58+UlTWBx1rN+Lb6ilbFL R9xoEiBixZKDGgnqOalWsSSdeN9mkKx4jf9JLPBcsK3T2ymLpf5W22DOWn+XkqaystSQ nls507X9al+GqM/2iGLlMTjznJS2kAensbitYckM9I+4aicXw5oCiproVXMfqX1p+btO qn2J1elUsgRgmcJbr9pJkmuwJRYyKX9vXGRjr81ksVNCc6gy9t1ULavQAJq0KyhuUaP9 15mJOWUI3bxFFI2diqj/bBE6Z9WUsq27mWuuPera5ono9nNMxgykCnQ7ry+srf40XFd1 lIjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ajoTgRnqXmGr4NGz4sDpf2t3leA2CkfA49rjJDDlhoM=; b=RhykXw/7v4txM/E+KvRZ+z7bV9IXlMHqfGdZokS72suTsbOLV5+UMj5wwh42qHUmq8 JdkhZcaHoYpLqOVRXVOv1hUo5BuVogTU0vePyNQ9IqtAeWmMH42kYUwHVxFh1ammpXFX 4lpePVaPuQkUr9vtAvPQNOcHIfqY3tbsP8PscL3KTeF9LrVWytRLQZI3ygrKbdN1DdR2 p/7ZB1iVkzIZT2yc5Nj7BIL/hf6VoDB/pHOMPDaDTDSNXfsjNW6CVqkAALN4ZIlXHQjs +PyTdpZHC2wKqiSYvw+miE4a/23IAtfeKIluJ9ZjNqrNvIQVhQunVB0R3DVbGx5YyVFW 12/w== X-Gm-Message-State: AOAM532R1RF2srgJJVk+NfX8D6LRvDW/qCnE4sK8QUn/BKB32kWN3mSS iqbnY5eRB37BvTF/NsiVlO0= X-Google-Smtp-Source: ABdhPJw85sVyP6y5ilqXEh1EvkZzIms/rsekSrV637FLs1tm3tNCCEayMR8NXGizRE+7xH5lc+aNFg== X-Received: by 2002:a6b:fe11:: with SMTP id x17mr1031699ioh.192.1604048784946; Fri, 30 Oct 2020 02:06:24 -0700 (PDT) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id c1sm4878264ile.0.2020.10.30.02.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 02:06:23 -0700 (PDT) Date: Fri, 30 Oct 2020 02:06:21 -0700 From: Nathan Chancellor To: Martin =?iso-8859-1?Q?Hundeb=F8ll?= Subject: Re: [PATCH] spi: bcm2835: fix gpio cs level inversion Message-ID: <20201030090621.GA3594676@ubuntu-m3-large-x86> References: <20201014090230.2706810-1-martin@geanix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201014090230.2706810-1-martin@geanix.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201030_050627_231954_542E20BB X-CRM114-Status: GOOD ( 19.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Florian Fainelli , Scott Branden , Ray Jui , Gregory CLEMENT , stable@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Nicolas Saenz Julienne Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 11:02:30AM +0200, Martin Hundeb=F8ll wrote: > The work on improving gpio chip-select in spi core, and the following > fixes, has caused the bcm2835 spi driver to use wrong levels. Fix this > by simply removing level handling in the bcm2835 driver, and let the > core do its work. > = > Fixes: 3e5ec1db8bfe ("spi: Fix SPI_CS_HIGH setting when using native and = GPIO CS") > Cc: > Signed-off-by: Martin Hundeb=F8ll > --- > drivers/spi/spi-bcm2835.c | 12 ------------ > 1 file changed, 12 deletions(-) > = > diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c > index b87116e9b413..9b6ba94fe878 100644 > --- a/drivers/spi/spi-bcm2835.c > +++ b/drivers/spi/spi-bcm2835.c > @@ -1259,18 +1259,6 @@ static int bcm2835_spi_setup(struct spi_device *sp= i) > if (!chip) > return 0; > = > - /* > - * Retrieve the corresponding GPIO line used for CS. > - * The inversion semantics will be handled by the GPIO core > - * code, so we pass GPIOD_OUT_LOW for "unasserted" and > - * the correct flag for inversion semantics. The SPI_CS_HIGH > - * on spi->mode cannot be checked for polarity in this case > - * as the flag use_gpio_descriptors enforces SPI_CS_HIGH. > - */ > - if (of_property_read_bool(spi->dev.of_node, "spi-cs-high")) > - lflags =3D GPIO_ACTIVE_HIGH; > - else > - lflags =3D GPIO_ACTIVE_LOW; > spi->cs_gpiod =3D gpiochip_request_own_desc(chip, 8 - spi->chip_select, > DRV_NAME, > lflags, > -- = > 2.28.0 > = > = Clang now warns: drivers/spi/spi-bcm2835.c:1264:9: warning: variable 'lflags' is uninitializ= ed when used here [-Wuninitialized] lflags, ^~~~~~ drivers/spi/spi-bcm2835.c:1196:2: note: variable 'lflags' is declared here enum gpio_lookup_flags lflags; ^ 1 warning generated. Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel