From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE1F5C4741F for ; Fri, 30 Oct 2020 18:56:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 778202075E for ; Fri, 30 Oct 2020 18:56:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Otw2ig5c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 778202075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NRSDUpTziHszaZRRl1S45lE71LWl4g0Tt8WyKT4B7iQ=; b=Otw2ig5cvdeIP8bL/DRnn6BkL CbL245edZbohUnhYggQQaWgGb/ONUxboG6pYoi6n5MpJ81ujEM+ttWtcOgbMSIZNNiHkSAtmtREwd /94QxsaEAgTvh6EWblJGodkgDeqWov/scQtjmT3pT83t3LArbKhKdBTIlvhkuyVNj4b9vx9xU+TMi 417osVKAGb5tzt2PQhjNobkyOv5RFdOqiuMTOI/9nOyudaR75louzGDlOqMYZMw4KnEcRM6rKaXnZ 4ArNkR85mr+ZZ6E0pOZph4AfXdWvc195MamVsHun9hP2j1hVeNffxDLm/QItr+yDEhR7+MMw0U/II HWa7g+5yQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYZYV-0007Zg-VJ; Fri, 30 Oct 2020 18:55:19 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYZYT-0007Yu-Do for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2020 18:55:18 +0000 Received: by mail-ot1-f68.google.com with SMTP id m22so6485486ots.4 for ; Fri, 30 Oct 2020 11:55:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VEJSrrlWi4nGgCuwCiPdo92Bvw6wzA2qRIk7ryIipEQ=; b=fN/Dzhks2NhPVrEMoSYitdSb27xBz/ErzbzNEB5gSQgXSaUj0A28oz+six+LKAThGe Oc0VXpKhlV0hyEhPkDT7/dzoZ/WQ+Iw2HxdR9QHpPmMLUC/SsgY3XK0iRy7wBnY0UEup i0aUeKzr0YebSU0xupU+r0SqW10r6Uj4YxJ4dAbHu++sLVsYxdFXDlvcXmEK0jSROfk4 QTZbyLVRjzvOpdxPW4cmmv7AYkDw+bno0GWhF5q/aJpckYA6WlAAIStto+jPYYTHMYS4 Ieb7qecT1Msfj2MwsifFUW34OVW86SETZfgFYiijmiOUy7R0ZzL2rv8qiU10ybNRuxyV bi8g== X-Gm-Message-State: AOAM531PB0Cv0KTrZvioprWmEx1+SH9t6YA5ZyYuOENlxiEk1HgmXtGk yPTC89Wm8si7uMYe4eKbig== X-Google-Smtp-Source: ABdhPJzt5b9EvIvjswnpcPiateFic+Ourf33V0RDiFsTxROsokE5KAZ93O78JglWQuUFJFlYkwo0HQ== X-Received: by 2002:a9d:39e1:: with SMTP id y88mr2834129otb.39.1604084116226; Fri, 30 Oct 2020 11:55:16 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id h15sm1529750ots.31.2020.10.30.11.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 11:55:15 -0700 (PDT) Received: (nullmailer pid 4142058 invoked by uid 1000); Fri, 30 Oct 2020 18:55:14 -0000 Date: Fri, 30 Oct 2020 13:55:14 -0500 From: Rob Herring To: Cristian Marussi Subject: Re: [PATCH v3 4/4] dt-bindings: arm: add support for SCMI Regulators Message-ID: <20201030185514.GA4129214@bogus> References: <20201026203148.47416-1-cristian.marussi@arm.com> <20201026203148.47416-5-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201026203148.47416-5-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201030_145517_485975_957EB5C7 X-CRM114-Status: GOOD ( 24.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, satyakim@qti.qualcomm.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, Jonathan.Cameron@Huawei.com, linux-kernel@vger.kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, sudeep.holla@arm.com, souvik.chakravarty@arm.com, etienne.carriere@linaro.org, lukasz.luba@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 26, 2020 at 08:31:48PM +0000, Cristian Marussi wrote: > Add devicetree bindings to support regulators based on SCMI Voltage > Domain Protocol. > > Signed-off-by: Cristian Marussi > --- > v2 --> v3 > - avoid awkard examples based on _cpu/_gpu regulators > v1 --> v2 > - removed any reference to negative voltages > --- > .../devicetree/bindings/arm/arm,scmi.txt | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt b/Documentation/devicetree/bindings/arm/arm,scmi.txt > index 55deb68230eb..0cef83a60f03 100644 > --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt > +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt > @@ -62,6 +62,28 @@ Required properties: > - #power-domain-cells : Should be 1. Contains the device or the power > domain ID value used by SCMI commands. > > +Regulator bindings for the SCMI Regulator based on SCMI Message Protocol > +------------------------------------------------------------ > + > +An SCMI Regulator is permanently bound to a well defined SCMI Voltage Domain, > +and should be always positioned as a root regulator. > +It does not support any current operation. > + > +This binding uses the common regulator binding[6]. > + > +SCMI Regulators are grouped under a 'regulators' node which in turn is a child > +of the SCMI Voltage protocol node inside the desired SCMI instance node. > + > +Required properties: > + - reg : shall identify an existent SCMI Voltage Domain. > + > +Optional properties: > + - all of the other standard regulator bindings as in [6]: note that, since > + the SCMI Protocol itself aims in fact to hide away many of the operational > + capabilities usually exposed by the properties of a standard regulator, > + most of the usual regulator bindings could have just no effect in the > + context of this SCMI regulator. You can't have it both ways... You should list out which ones apply. I'm a bit worried that now we're changing CPUs (at least?) from clocks to 'performance domains' while at the same time here we're adding low level, virtual regulators. Are we going to end up wanting something more abstract here too? > + > Sensor bindings for the sensors based on SCMI Message Protocol > -------------------------------------------------------------- > SCMI provides an API to access the various sensors on the SoC. > @@ -105,6 +127,7 @@ Required sub-node properties: > [3] Documentation/devicetree/bindings/thermal/thermal*.yaml > [4] Documentation/devicetree/bindings/sram/sram.yaml > [5] Documentation/devicetree/bindings/reset/reset.txt > +[6] Documentation/devicetree/bindings/regulator/regulator.yaml > > Example: > > @@ -169,6 +192,25 @@ firmware { > reg = <0x16>; > #reset-cells = <1>; > }; > + > + scmi_voltage: protocol@17 { > + reg = <0x17>; > + > + regulators { > + regulator_devX: regulator_scmi_devX@0 { Node names should be generic: regulator@0 > + reg = <0x0>; > + regulator-max-microvolt = <3300000>; > + }; > + > + regulator_devY: regulator_scmi_devY@9 { > + reg = <0x9>; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <4200000>; > + }; > + > + ... > + }; > + }; > }; > }; > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel