From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9C0C388F7 for ; Sat, 31 Oct 2020 07:13:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08DCF20791 for ; Sat, 31 Oct 2020 07:13:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Rf5jdTkI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08DCF20791 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p9hmsrGbTKzAoKkOnkiBGrd/OTklw+I599nXhh8jOac=; b=Rf5jdTkIsnnUOqZyxpCqDouzw E+tvZu11XaQBUx/NO0tM2ZyuweUMaRv0BkfJqUIoqKnvOQsWvIV+1QurArJjDcKWwQnaLpvSVm7Ma 6v1fXkKoh/t3L+QO+a3CtfpQLGXb+Pa7cOCgzgR9/uhyUA3OWRYvSkM/IbIQRd3eCcHlM5kD81Evp Xy/4TDUAFTkCxvp3EEgVcgjQs4iekMaccoCWbGjnG2sILpLq59UY76ELzdg94ZnQYJciE33ZogVRd kBDl2pyTMURV5uVum6LHBlcNMGlgOoiyfG6iWfMccBCf4q9PIJE0liJ2kOJewUmjB0qLuATesAMv/ kx2RBOB8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYl3M-0003xb-KO; Sat, 31 Oct 2020 07:11:56 +0000 Received: from muru.com ([72.249.23.125]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYl3J-0003x9-1i for linux-arm-kernel@lists.infradead.org; Sat, 31 Oct 2020 07:11:53 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A9E2680A3; Sat, 31 Oct 2020 07:11:51 +0000 (UTC) Date: Sat, 31 Oct 2020 09:11:43 +0200 From: Tony Lindgren To: Grygorii Strashko Subject: Re: [PATCH 4/4] bus: ti-sysc: Fix bogus resetdone warning for cpsw Message-ID: <20201031071143.GL5639@atomide.com> References: <20201026105812.38418-1-tony@atomide.com> <20201026105812.38418-5-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201031_031153_149172_98C64744 X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Tero Kristo , Dave Gerlach , Keerthy , linux-kernel@vger.kernel.org, Peter Ujfalusi , Faiz Abbas , Greg Kroah-Hartman , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Grygorii Strashko [201030 18:15]: > Hi Tony, > > On 26/10/2020 12:58, Tony Lindgren wrote: > > The cpsw SOFT_RESET register is cleard when out of reset so let's > > add SYSS_QUIRK_RESETDONE_INVERTED flag for cpsw. Otherwise we will > > get bogus "OCP softreset timed out" warnings on boot. > > Not sure if this quirk based approach is right way to move forward here. > > The cpsw/cpgmac is "ti,sysc-omap4-simple" which means sysc_omap4_simple, which, > in turn, has .srst_shift = -ENODEV. > > And above should be enough to avoid both sysc_reset() and sysc_wait_softreset() for such modules. That sounds like a much better fix indeed, I'll take a look. Thanks, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel