From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AC5FC388F9 for ; Sat, 31 Oct 2020 11:04:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27335208B6 for ; Sat, 31 Oct 2020 11:04:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DzuQFdlQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="t410NVk9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27335208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PU4PRNMTpMmes8LFuXq+P3d9YRsEkhzG4fHQoZ6u9wI=; b=DzuQFdlQXs+IPb8s2e3jraO+D VI4Jh0mCGFMu3s+HRTwwZ2GQcrGgR77ln8imFlU9BalGzC50g39iIP4PsMQDuecoZIbf81zr0JcIQ tbF8rySf8u3aLHGfqNhTZp5XQOHCUXwdSVfJ92wqV8dV9/jPTSvhe8zNRJg3vXStpDuBwR4yiy39F 3wrTuIVaPv1yTLHVXOUah86jLzC/uQ4y+HrhJkBXlaQ5UtaW3bCWnTairxXzI1B6wfVzCVdLh+zT2 0qGB6ntSXtH2LjQ1vGf94dm06IqAFhglHlA7PpkByhWDrrxiJcZOIQoBjMeWc2tnu8xr58/cOzcRR 9Q9Dq0Y3A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYog1-0003JG-CO; Sat, 31 Oct 2020 11:04:05 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYofy-0003Iv-Iq for linux-arm-kernel@lists.infradead.org; Sat, 31 Oct 2020 11:04:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qm/dQY1APPXhjSPvUnH3gO6xHjupja3A54rMyQhlKYk=; b=t410NVk9eDFxFp96VJFBgdK3o 5ECw1YSrWf2wveE+xJ0W2cfO+Fnjk/qYXCfQI/WjVZkUs49XnhNgHzZUIWutNvObWQ/Z7/Bx2ZRPW bN3PxBjqtKEMLvbLgI+PtMGiXDkl7DrBDs1yxOZytmk8E4ml3Xtb1kK/SgwkUb7lsgKX66ftc9Nnq qJVlziCdqUSuDYHYYkWYMQ/WtG5dvbc2ZhSRm08l79MS5ZXUWYuhiT2sIsHnxmr5Ce6WqdfD6CquS JbEKKh/hBX115/fOL6Z9uVittAg3p75EVGe94Tnv4mC4xNLhwow8LYEa6LPQmfA/8qk+xGAL9F9W5 CbzqwRJ6g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53284) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYofo-00075q-FC; Sat, 31 Oct 2020 11:03:52 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kYofn-00088r-4v; Sat, 31 Oct 2020 11:03:51 +0000 Date: Sat, 31 Oct 2020 11:03:51 +0000 From: Russell King - ARM Linux admin To: Ard Biesheuvel Subject: Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations Message-ID: <20201031110350.GJ1551@shell.armlinux.org.uk> References: <20201031094345.6984-1-rppt@kernel.org> <20201031103312.GI1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201031_070402_659835_23CBF54D X-CRM114-Status: GOOD ( 30.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xtensa@linux-xtensa.org, Florian Fainelli , Chris Zankel , Linus Walleij , Linux Kernel Mailing List , Mike Rapoport , Max Filippov , Linux ARM , Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 31, 2020 at 11:47:42AM +0100, Ard Biesheuvel wrote: > On Sat, 31 Oct 2020 at 11:33, Russell King - ARM Linux admin > wrote: > > > > On Sat, Oct 31, 2020 at 11:43:45AM +0200, Mike Rapoport wrote: > > > From: Ard Biesheuvel > > > > > > free_highpages() iterates over the free memblock regions in high > > > memory, and marks each page as available for the memory management > > > system. > > > > > > Until commit cddb5ddf2b76 ("arm, xtensa: simplify initialization of > > > high memory pages") it rounded beginning of each region upwards and end of > > > each region downwards. > > > > > > However, after that commit free_highmem() rounds the beginning and end of > > > each region downwards, and we may end up freeing a page that is > > > memblock_reserve()d, resulting in memory corruption. > > > > > > Restore the original rounding of the region boundaries to avoid freeing > > > reserved pages. > > > > > > Fixes: cddb5ddf2b76 ("arm, xtensa: simplify initialization of high memory pages") > > > Link: https://lore.kernel.org/r/20201029110334.4118-1-ardb@kernel.org/ > > > Signed-off-by: Ard Biesheuvel > > > Co-developed-by: Mike Rapoport > > > Signed-off-by: Mike Rapoport > > > --- > > > > > > Max, Russell, > > > > > > Please let me know how do you prefer to take it upstream. > > > If needed this can go via memblock tree. > > > > > > v2: fix words order in the commit message > > > > I really don't understand what is going on here; there seems to be a > > total disconnect of communication between yourself and Ard. Ard has > > already submitted a different patch for this to the patch system > > already, sent yesterday. > > > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9021/1 > > > > Please discuss between yourselves how you want to solve the problem, > > and then submit an agreed and tested patch to those of us upstream; > > please don't make it for those upstream to pick one of your patches > > as you are at present. > > > > Apologies for creating this confusion. I posted a patch and dropped it > into the patch system when I found the bug. > > However, only when Florian asked about a 'fixes' tag, I went back to > the history, and realized that the issue was introduced by Mike during > the most recent merge window, and affects xtensa as well. So why does Mike's patch have: Signed-off-by: Ard Biesheuvel in it? It seems you haven't been directly involved in Mike's patch. There's something /really/ not right with the process behind this patch. > I don't have a preference which patch gets applied, though, so please > indicate your preference, and we will adapt accordingly. I asked for you both to come to a concensus about how you want to proceed, and now you're throwing it back on to me to solve your(pl) mis-communication issue. We haven't heard from Mike yet. Clearly, I wasn't blunt and stroppy enough to be properly understood. Sort it out between yourselves and tell me which patch you want me to apply. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel