From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA360C388F7 for ; Sat, 31 Oct 2020 11:10:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46256206E5 for ; Sat, 31 Oct 2020 11:10:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O1t90s7x"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oMhFeuoi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46256206E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZwJwSrNDYc122VtIZ3rNomz8bhEYzTBNezXp0J9K3Zo=; b=O1t90s7x+GxDnU/JW8IEjEccl vLq0FdzXQ7wWV884yRdjj57kVcpdiWCg91WZP1A41Eha3+1kzxeouoOMHq+RAwuPmzqtAuC+1G1WE AwJ7nb/yFoEgqqvRALr3Nu4QF8RpJCfoWt+jSgnHl66AhkyQdXYVUSXkQZSVnjUai5H9SwLx9JaI5 ZbcnF3Tqi7J6wRL5Ujy1AdLo34hjHtO3ME1RDFHY1PBwkBsf4OMPl/GTL0xZzey/03upGcDMD4MgN R43ZqJg6OZUSXTLuH+TEZkQxDHLz/u/FRR+V1tBl1q6ebc4WfSdFbGSByDfbU2gwTDeUci2npPVzT UwWDw+Cyw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYolv-0003dP-QP; Sat, 31 Oct 2020 11:10:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYolt-0003cc-2l for linux-arm-kernel@lists.infradead.org; Sat, 31 Oct 2020 11:10:09 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 404D2206E5; Sat, 31 Oct 2020 11:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604142607; bh=hkzEJUaBNUIIhzqu5SpbfUySyKicS5nTmpJjPg4g8ys=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oMhFeuoiz6y/py4aJtruc8WUCabyz5uMV3F4wOO8o+FvQKlVS4gHVV/N3mIlaRjBD /cMQ0V+G8RfzpF2f4GtpDkG+6Cn0TsX1F1wRFNwFAdVjAU2B10iVCvrbhQlAujyjE9 7VhZFhjgCW127opGjkZJ63lsYiRaEzErG0zAy8nw= Date: Sat, 31 Oct 2020 11:10:03 +0000 From: Jonathan Cameron To: Bartosz Golaszewski Subject: Re: [PATCH 4/5] iio: adc: xilinx: use devres for irq handling Message-ID: <20201031111003.75a4f6d0@archlinux> In-Reply-To: References: <20201026133609.24262-1-brgl@bgdev.pl> <20201026133609.24262-5-brgl@bgdev.pl> <20201029154118.12fd6c23@archlinux> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201031_071009_249982_79617352 X-CRM114-Status: GOOD ( 26.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars-Peter Clausen , linux-iio , Linux Kernel Mailing List , Michal Simek , Bartosz Golaszewski , Peter Meerwald-Stadler , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 30 Oct 2020 11:52:00 +0100 Bartosz Golaszewski wrote: > On Thu, Oct 29, 2020 at 4:41 PM Jonathan Cameron wrote: > > > > On Mon, 26 Oct 2020 14:36:08 +0100 > > Bartosz Golaszewski wrote: > > > > > From: Bartosz Golaszewski > > > > > > Further simplify the remove() callback and error paths in probe() by > > > using the managed variant of request_irq() as well as using a devm action > > > for cancelling the delayed work at driver detach. > > > > > > Signed-off-by: Bartosz Golaszewski > > > > Again, this is potentially fine but I'd rather you cleaned up the ordering first > > rather than doing things in this order. > > > > The end result of the whole series looks like it will be correct, but that isn't > > so obvious for the intermediate patches on their own. > > > > Also, you end up with a lot of noise renaming gotos that then go away at the > > end. > > > > Jonathan > > > > Hi Jonathan, > > My two priorities for the ordering of this series were: correct > end-result and not breaking anything on the way. The latter > unfortunately gets in the way of cleaner looking intermediate patches. > > I tried to not alter the ordering in which the resources are freed at > any step. As devres release callbacks are called *after* remove() and > in a reverse order to how they were registered, I needed to start from > the bottom of the remove() callback and convert the last operation, > then go upwards from there. > > If I tried to do it from the top - I probably could remove labels > earlier and in a cleaner manner but it wouldn't guarantee > bisectability. > Maybe best plan is to squash last 3 patches into one? I suspect that's going to be easier to review. Jonathan > Bartosz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel