From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51303C388F9 for ; Sat, 31 Oct 2020 15:46:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF4C522282 for ; Sat, 31 Oct 2020 15:46:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q+EeH3k1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="AdCGkUc4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF4C522282 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fnt1Q/ksfsBiB/QYJ1jOo+AbKHhRuQ/PWy2yayTAUIs=; b=Q+EeH3k1Rcehzf6Y98Xcuy0Yo lA8wA8o5KR644+1bVIVgK0rZ2OpvTe3/v5zyuFdXeMcLUG6Pv5wfdo01mB7Hzni8VqpR/6sfSTGP0 2hOkKxlmdqGrq5sORDIfnT5KErCs1Qhf2l5VhVGctegyk9GUeGPUdBqxu7ttmGI6yEQqV+wa7qzAd fjn2IfmNbD0sA1w0BBGo7gU21hx2PY5+OIvhhqRFWj8dN0pvtZtg1E+BJiXvAQkvz2I6eTZLD5Zch x2nlWOCLRBAFsNubR3MsDWvK/9IQnihkqBfh1p0d7J0Hwp6K4FlHW4ssxzUyg4zzmmQnAiD2Hgim7 RsG86mrcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYt4b-0004xt-RR; Sat, 31 Oct 2020 15:45:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYt4Y-0004xK-Ax for linux-arm-kernel@lists.infradead.org; Sat, 31 Oct 2020 15:45:44 +0000 Received: from kernel.org (unknown [87.71.17.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1457822282; Sat, 31 Oct 2020 15:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604159135; bh=zSEGL+am3bbMk1wdOS+gSCvmmmHnMHmLzjZ8W5P06fc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AdCGkUc4oeWLEI9pmJPUJw9z2SVBCzuefgspYbujrsIias14Kn3VY1yJt5/KS/fpW kbjDIaS+y+3pk8mOETE7EIXA0MRno93a202wWqEGKtWLYInt3FZ3WP4KQvCsXBIVP+ 4uBSV10UuEc5DAmIGxSw6WYN1CFApzDaSn5Rnj8A= Date: Sat, 31 Oct 2020 17:45:28 +0200 From: Mike Rapoport To: Ard Biesheuvel Subject: Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations Message-ID: <20201031154528.GA14628@kernel.org> References: <20201031094345.6984-1-rppt@kernel.org> <20201031103312.GI1551@shell.armlinux.org.uk> <20201031110350.GJ1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201031_114542_523059_346C5E5B X-CRM114-Status: GOOD ( 42.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xtensa@linux-xtensa.org, Florian Fainelli , Chris Zankel , Linus Walleij , Russell King - ARM Linux admin , Linux Kernel Mailing List , Max Filippov , Mike Rapoport , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 31, 2020 at 12:21:24PM +0100, Ard Biesheuvel wrote: > On Sat, 31 Oct 2020 at 12:04, Russell King - ARM Linux admin > wrote: > > > > On Sat, Oct 31, 2020 at 11:47:42AM +0100, Ard Biesheuvel wrote: > > > On Sat, 31 Oct 2020 at 11:33, Russell King - ARM Linux admin > > > wrote: > > > > > > > > On Sat, Oct 31, 2020 at 11:43:45AM +0200, Mike Rapoport wrote: > > > > > From: Ard Biesheuvel > > > > > > > > > > free_highpages() iterates over the free memblock regions in high > > > > > memory, and marks each page as available for the memory management > > > > > system. > > > > > > > > > > Until commit cddb5ddf2b76 ("arm, xtensa: simplify initialization of > > > > > high memory pages") it rounded beginning of each region upwards and end of > > > > > each region downwards. > > > > > > > > > > However, after that commit free_highmem() rounds the beginning and end of > > > > > each region downwards, and we may end up freeing a page that is > > > > > memblock_reserve()d, resulting in memory corruption. > > > > > > > > > > Restore the original rounding of the region boundaries to avoid freeing > > > > > reserved pages. > > > > > > > > > > Fixes: cddb5ddf2b76 ("arm, xtensa: simplify initialization of high memory pages") > > > > > Link: https://lore.kernel.org/r/20201029110334.4118-1-ardb@kernel.org/ > > > > > Signed-off-by: Ard Biesheuvel > > > > > Co-developed-by: Mike Rapoport > > > > > Signed-off-by: Mike Rapoport > > > > > --- > > > > > > > > > > Max, Russell, > > > > > > > > > > Please let me know how do you prefer to take it upstream. > > > > > If needed this can go via memblock tree. > > > > > > > > > > v2: fix words order in the commit message > > > > > > > > I really don't understand what is going on here; there seems to be a > > > > total disconnect of communication between yourself and Ard. Ard has > > > > already submitted a different patch for this to the patch system > > > > already, sent yesterday. > > > > > > > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9021/1 > > > > > > > > Please discuss between yourselves how you want to solve the problem, > > > > and then submit an agreed and tested patch to those of us upstream; > > > > please don't make it for those upstream to pick one of your patches > > > > as you are at present. > > > > > > > > > > Apologies for creating this confusion. I posted a patch and dropped it > > > into the patch system when I found the bug. > > > > > > However, only when Florian asked about a 'fixes' tag, I went back to > > > the history, and realized that the issue was introduced by Mike during > > > the most recent merge window, and affects xtensa as well. > > > > So why does Mike's patch have: > > > > Signed-off-by: Ard Biesheuvel > > > > in it? It seems you haven't been directly involved in Mike's patch. > > > > Because I cc'ed him on the discussion following the patch that is now > in your patch system. So he took that patch and modified it, but > retained the original S-o-b and authorship. Right, that's exactly what happened. > > There's something /really/ not right with the process behind this > > patch. > > > > > I don't have a preference which patch gets applied, though, so please > > > indicate your preference, and we will adapt accordingly. > > > > I asked for you both to come to a concensus about how you want to > > proceed, and now you're throwing it back on to me to solve your(pl) > > mis-communication issue. We haven't heard from Mike yet. > > > > I am not throwing it back to you. I merely indicated that I have no > preference, and since Mike is the one who introduced this issue in the > first place, I am expecting him to drive this. And indeed, we haven't > heard from him yet. I didn't know that Ard's patch was already in the patch system. I took the patch from the list, updated it, added a fix for xtensa and resend while retaining Ard's authourship and s-o-b. > > Clearly, I wasn't blunt and stroppy enough to be properly understood. > > Sort it out between yourselves and tell me which patch you want me to > > apply. > > > > I would like you to ack this version of the patch, and disregard the > one in the patch system, so that Mike can take this one through the > memblock tree where the issue originated in the first place. Agree. -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel