Re: [PATCH v3 8/9] perf mem: Return NULL for event 'ldst' on PowerPC

Naveen N. Rao
2020-10-28T09:37:27Z

[+ Maddy]

Leo Yan wrote:
> If user specifies event type "ldst", PowerPC's perf_mem_events__name()
> will wrongly return the store event name "cpu/mem-stores/".
>
> This patch changes to return NULL for the event "ldst" on PowerPC.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/arch/powerpc/util/mem-events.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/arch/powerpc/util/mem-events.c b/tools/perf/arch/powerpc/util/mem-events.c
> index 07fb5e049488..90c5a0760685 100644
> --- a/tools/perf/arch/powerpc/util/mem-events.c
> +++ b/tools/perf/arch/powerpc/util/mem-events.c
> @@ -7,6 +7,8 @@ char *perf_mem_events__name(int i)
> {
> if (i == PERF_MEM_EVENTS__LOAD)
> return (char *) "cpu/mem-loads/";
> -
> - return (char *) "cpu/mem-stores/";
> + else if (i == PERF_MEM_EVENTS__STORE)
> + return (char *) "cpu/mem-stores/";
> + else
> + return NULL;
> }
> --
> 2.17.1
>
>