linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: peng.fan@nxp.com
Cc: aisheng.dong@nxp.com, abel.vesa@nxp.com, Anson.Huang@nxp.com,
	sboyd@kernel.org, s.hauer@pengutronix.de,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com,
	kernel@pengutronix.de, festevam@gmail.com,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 0/5] clk: imx: fix bus critical clk registration
Date: Sun, 1 Nov 2020 15:54:50 +0800	[thread overview]
Message-ID: <20201101075449.GG31601@dragon> (raw)
In-Reply-To: <1603285820-30196-1-git-send-email-peng.fan@nxp.com>

On Wed, Oct 21, 2020 at 09:10:15PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> V2:
>   Add missed Reported-by tag
>   Add R-b tag

I do not see either tag on any of the patches.

> 
> The issue is exposed by
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/
> linux.git/commit/?h=for-next&id=936c383673b9e3007432f17140ac62de53d87db9
> 
> Since the upper patch not in Linus tree, I not add Fixed tag.

It should be landed now.

Shawn

> 
> The issue is bus clk should be registered using bus composite api, not
> peripheral api. Otherwise we will met failed to assigned clock parents error log.
> Because peripheral critical clk has CLK_SET_PARENT_GATE and CLK_IS_CRITICAL,
> you will not able to set clk parents.
> 
> We need use bus critical clk api to register the clks, so introduce
> a new helper and use it.
> 
> Peng Fan (5):
>   clk: imx: add imx8m_clk_hw_composite_bus_critical
>   clk: imx8mq: fix noc and noc_io registration
>   clk: imx8mm: fix bus critical clk registration
>   clk: imx8mn: fix bus critical clk registration
>   clk: imx8mp: fix bus critical clk registration
> 
>  drivers/clk/imx/clk-imx8mm.c | 10 +++++-----
>  drivers/clk/imx/clk-imx8mn.c |  6 +++---
>  drivers/clk/imx/clk-imx8mp.c | 10 +++++-----
>  drivers/clk/imx/clk-imx8mq.c |  8 ++++----
>  drivers/clk/imx/clk.h        |  5 +++++
>  5 files changed, 22 insertions(+), 17 deletions(-)
> 
> -- 
> 2.28.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2020-11-01  7:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 13:10 [PATCH V2 0/5] clk: imx: fix bus critical clk registration peng.fan
2020-10-21 13:10 ` [PATCH V2 1/5] clk: imx: add imx8m_clk_hw_composite_bus_critical peng.fan
2020-10-21 13:10 ` [PATCH V2 2/5] clk: imx8mq: fix noc and noc_io registration peng.fan
2020-10-21 13:10 ` [PATCH V2 3/5] clk: imx8mm: fix bus critical clk registration peng.fan
2020-10-21 13:10 ` [PATCH V2 4/5] clk: imx8mn: " peng.fan
2020-10-21 13:10 ` [PATCH V2 5/5] clk: imx8mp: " peng.fan
2020-11-01  7:54 ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201101075449.GG31601@dragon \
    --to=shawnguo@kernel.org \
    --cc=Anson.Huang@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).