From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F32C00A89 for ; Mon, 2 Nov 2020 09:21:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 911A221D91 for ; Mon, 2 Nov 2020 09:21:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cXoY+UlV"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="qb9LVfNu"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="MMuWHDtj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 911A221D91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eUgneJmkqwMxR8U9Bw2jItb8tcl/6nlgosoqVRwFHlw=; b=cXoY+UlVqXIK89Mq04rSJdo7F 6H7T9BvFr6ox8s5QREiJcx4nrfRwA57GEXauGHrUHOZSiCoVGa5x0tiHGrFYn+7c5+uiPNlxPoBK2 9393ufy2Ps/q07R5hfTGy6cuUbLDHztgBFrbG23Mbz6WkvcliI2vPqzdpU+q0UaSx7LUEnoG/rpUo 2x6XC+INLcHPxhmNPCj3fqbYIcsKBpLTYeY/QZCz+EQUYiFF+imX90Skgl+9fDqX3yyWdexX296zU 5vDwNeqG+CQb/bfTA/MJmNyDCR9ZXahpVA+Dx8u+wQxCxQMdNI5GoKBTBtLxXDgRwqpScDBtOg9dl SB5lpHsqg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZW1d-0006m6-Pn; Mon, 02 Nov 2020 09:21:17 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZW1a-0006lH-PH for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 09:21:15 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 471EA580098; Mon, 2 Nov 2020 04:21:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 02 Nov 2020 04:21:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=Io+FlZjpTIADTIzIW74U/CyYabR lDgPOCEmLfu2QH3g=; b=qb9LVfNuiocCc5g3UUl8IPfkntSozd6qT7Sjrjx0tFo 4j1JdNHEYnblDITN5DgdPReu0/HzZss+XJSUrKrBVqFK0QMYJdbkeTPoebXS71Kk 8Gaex6NAxHWxCkW1Rno52RSemsIWEJ+BwxDpGvW+AiVzaBvsHHY1bHGufvupmaRx 1+3tUsW2Au1TvM5EZR8UmZzRzxXUb9tOdpr/oYKWgXDUIgiRaTsFrcw3ffK6EeAM x5o1OoT0t14L5JePEiSj7xAQQVLvmaQBaw3CJn4e4QzuOjSrBOyYCZXCkI6NWx3V EGC89ga7xIDALXACNjfvdnTdQVUAniArhP7Nc4F4KCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Io+FlZ jpTIADTIzIW74U/CyYabRlDgPOCEmLfu2QH3g=; b=MMuWHDtj84vswQqq7yMhRs I4Hi/O0pIbQAn/PwSSYTJOXHy/nJrv2FnTS5LJAIdTq3MD/mlaPzVP+gBqAIr6hJ InQAzHpAT9JojXHU5JV9oBq9kZlNGEBJzaRyc0dEl4lRwwRf63oCOprmbPo2joqx NGmp640Y3dHKQ3rHn9VxTD0lJQkt9grNvv3UZomq5znzKXdo4yXE97LfANR7Gvvb N+6n/M4GFO3wqsNzSTd5tnM4eT0hRrSIJgm1V60wwGBHQ4Uh+EnhXiT1vgawuM2d +shTWS/v6VqIaQkKdRZMfhvE3ac0s6Ru+qHfnjJCC+T7VUFS56HOaU1iMVYFOBGg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtuddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 390F83064674; Mon, 2 Nov 2020 04:21:12 -0500 (EST) Date: Mon, 2 Nov 2020 10:21:10 +0100 From: Maxime Ripard To: Helen Koike Subject: Re: [PATCH 08/14] media: sunxi: Add support for the A31 MIPI CSI-2 controller Message-ID: <20201102092110.ro6a456lvbrktwoz@gilmour.lan> References: <20201023174546.504028-1-paul.kocialkowski@bootlin.com> <20201023174546.504028-9-paul.kocialkowski@bootlin.com> <1a3a615c-a058-e282-2dbb-c99dfa98be68@collabora.com> MIME-Version: 1.0 In-Reply-To: <1a3a615c-a058-e282-2dbb-c99dfa98be68@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_042114_952764_3BE69672 X-CRM114-Status: GOOD ( 21.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Philipp Zabel , Kishon Vijay Abraham I , Thomas Petazzoni , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Paul Kocialkowski , linux-sunxi@googlegroups.com, Rob Herring , Vinod Koul , Yong Deng , Sakari Ailus , Hans Verkuil , Mauro Carvalho Chehab , Hans Verkuil , kevin.lhopital@hotmail.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============3173495826730333124==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3173495826730333124== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r6wmi6wvpuneeypr" Content-Disposition: inline --r6wmi6wvpuneeypr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 30, 2020 at 07:45:18PM -0300, Helen Koike wrote: > On 10/23/20 2:45 PM, Paul Kocialkowski wrote: > > The A31 MIPI CSI-2 controller is a dedicated MIPI CSI-2 controller > > found on Allwinner SoCs such as the A31 and V3/V3s. > >=20 > > It is a standalone block, connected to the CSI controller on one side > > and to the MIPI D-PHY block on the other. It has a dedicated address > > space, interrupt line and clock. > >=20 > > Currently, the MIPI CSI-2 controller is hard-tied to a specific CSI > > controller (CSI0) but newer SoCs (such as the V5) may allow switching > > MIPI CSI-2 controllers between CSI controllers. > >=20 > > It is represented as a V4L2 subdev to the CSI controller and takes a > > MIPI CSI-2 sensor as its own subdev, all using the fwnode graph and > > media controller API. >=20 > Maybe this is a bad idea, but I was thinking: > This driver basically just turn on/off and catch some interrupts for erro= rs, > and all the rest of v4l2 config you just forward to the next subdevice > on the pipeline. >=20 > So instead of exposing it as a subdevice, I was wondering if modeling > this driver also through the phy subsystem wouldn't be cleaner, so > you won't need all the v4l2 subdevice/topology boilerplate code that > it seems you are not using (unless you have plans to add controls or > some specific configuration on this node later). >=20 > But this would require changes on the sun6i-csi driver. >=20 > What do you think? Eventually we'll need to filter the virtual channels / datatypes I guess, so it's definitely valuable to have it in v4l2 Maxime --r6wmi6wvpuneeypr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX5/PhgAKCRDj7w1vZxhR xdTqAP9BNW3DOvNEhXCUns3+K6kcuMjRRnDvKoZkb+YtDDRnxgD/VYACQnV5UMH0 6qUJuIMi3BvClNZUn19ZMhW3WnIMkwM= =3I1e -----END PGP SIGNATURE----- --r6wmi6wvpuneeypr-- --===============3173495826730333124== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3173495826730333124==--