From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA95C00A89 for ; Mon, 2 Nov 2020 09:40:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB15E2225E for ; Mon, 2 Nov 2020 09:40:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kqNdQPhH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NftayeQf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB15E2225E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WaesQ+bvV09QZGBhPCnSLiNIwrJySMLOLuz8ctxOwDg=; b=kqNdQPhHr7AjpVmm4jyCxd0cT vIIuWxP5OLctDSFYY3RYWdzfuz2g1EOIJygdymYU7yHkpOWXW3bpS4UB2mEWpuqd34K0KZFZ52Xsx bshObl0Auy14GXTXyBTeGOpdHEAKZ3Scvc8Tm1yQSYt1UmdoUH/Y+MF2ztweG/48iVNPvx1O62s1x CEmy/YtY1l9oHx0U9RJaEGPD+DCRiPlb1GOqeUaWF1gsSRbPXH4Qni3BrwFgDPDwrwpOf1/eGsDlC B3c0R3lcQTg8kRDm0m0CE/RqpqQqiIaj1dA/KkDebg/ubjbLJNv7pt/110ZNn4csaMUtAsWioxhLd Pwv7nO0yw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZWIr-0002Er-93; Mon, 02 Nov 2020 09:39:05 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZWIo-0002CX-Fp for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 09:39:03 +0000 Received: by mail-pg1-x544.google.com with SMTP id r186so10323430pgr.0 for ; Mon, 02 Nov 2020 01:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QI/242QkjHiSRR2izSoqyexzCJoKkCdez+fwBBWlNlI=; b=NftayeQfmuCMrGAkgckhYPXyxiKWOd18y+dEMZLpHHIXLXnI7al5oFnSZiznQzqyjg CDzfkpNL8cTxvk+vUHpF/CD/Nk7ZH7lBm79YHQnkBXSIT2KyHRts9tu4giUKkGWWVgDQ T0ELpuRgAulgKahm7Ir4yD54MexXKbr1P1HbOObV+BNvphjguidtIKXAmP2jvaJEKXsU 7194fZ689f8ucGXaXmliKZgZ85Uu/A5moozq82Gj++Pg6OwXwZjzir4NPEDO4pl/YgWs rewZPutxvp5sFYHB4vikYdM3lnAI6xM5s05+yOctvCVVbXtbWH9cMCZQQVmiD5tyKKqw mxtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QI/242QkjHiSRR2izSoqyexzCJoKkCdez+fwBBWlNlI=; b=EPO9ULgeIP441y4fPV+X0G144TvCNnomSjUAT8/ii9US/3fBLiWSSVVgkYvrG1Dr0R KSktplsd8rjq2TF6lMPdHFYwbb/OS2D45Z/2RpwaRFCRXdaIAmcWolSL+n790Ikh6dTS Ma9o0Xz8ZgRVnxx7yrsOtC8Ki1ZeW0DS66BdInicvUQeD/ggUGcvTHMiziJqCoQg81oH 2T/KB3nWy4wwkECPFZrfFKHqSgAMfUp0rlxOcPG5QsvOqw+vp55/zbZrLCzFXt3raFmo y/Qjuft0WGakIcV7pp9OV0TqlzW7pd7BpEDQCNdoS37hqu2/7WFqpCTf4oEh0zOV9YNU lKQQ== X-Gm-Message-State: AOAM530XWtGTl0u4Ru20FLnZTlwAS3XLTpbybNAN42Zio/jm/W3qRUvQ rP+DaBluxT+FKOUi9vJrjYwhoQ== X-Google-Smtp-Source: ABdhPJwQvwK0ALKKA4WFTAabimtVr+1lvf4rZTcmx/mjfIdXXWulKu+ziOZp0uCM/I5y3eQ/RkRC0g== X-Received: by 2002:a63:5821:: with SMTP id m33mr12410307pgb.16.1604309938595; Mon, 02 Nov 2020 01:38:58 -0800 (PST) Received: from leoy-ThinkPad-X240s ([103.141.182.112]) by smtp.gmail.com with ESMTPSA id s9sm13347680pfh.67.2020.11.02.01.38.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Nov 2020 01:38:57 -0800 (PST) Date: Mon, 2 Nov 2020 17:38:48 +0800 From: Leo Yan To: Jiri Olsa Subject: Re: [PATCH v3 3/9] perf mem: Support new memory event PERF_MEM_EVENTS__LOAD_STORE Message-ID: <20201102093848.GA6633@leoy-ThinkPad-X240s> References: <20201028063813.8562-1-leo.yan@linaro.org> <20201028063813.8562-4-leo.yan@linaro.org> <20201031202307.GB3380099@krava> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201031202307.GB3380099@krava> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_043902_641401_E098FC1E X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ian Rogers , Al Grant , Mathieu Poirier , Kemeng Shi , Peter Zijlstra , Wei Li , John Garry , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Alexander Shishkin , Ingo Molnar , James Clark , =?iso-8859-1?Q?Andr=E9?= Przywara , Namhyung Kim , "Naveen N. Rao" , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 31, 2020 at 09:23:07PM +0100, Jiri Olsa wrote: > On Wed, Oct 28, 2020 at 02:38:07PM +0800, Leo Yan wrote: > > SNIP > > > struct stat st; > > > > + /* > > + * If the event entry isn't valid, skip initialization > > + * and "e->supported" will keep false. > > + */ > > + if (!e->tag) > > + continue; > > + > > scnprintf(path, PATH_MAX, "%s/devices/%s", > > mnt, e->sysfs_name); > > > > @@ -123,7 +134,7 @@ void perf_mem_events__list(void) > > struct perf_mem_event *e = perf_mem_events__ptr(j); > > > > fprintf(stderr, "%-13s%-*s%s\n", > > - e->tag, > > + e->tag ? e->tag : "", > > nit, could be: e->tag ?: "", Will do. Thanks, Leo > > verbose > 0 ? 25 : 0, > > verbose > 0 ? perf_mem_events__name(j) : "", > > e->supported ? ": available" : ""); > > diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h > > index 726a9c8103e4..5ef178278909 100644 > > --- a/tools/perf/util/mem-events.h > > +++ b/tools/perf/util/mem-events.h > > @@ -28,6 +28,7 @@ struct mem_info { > > enum { > > PERF_MEM_EVENTS__LOAD, > > PERF_MEM_EVENTS__STORE, > > + PERF_MEM_EVENTS__LOAD_STORE, > > PERF_MEM_EVENTS__MAX, > > }; > > > > -- > > 2.17.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel