From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C226CC00A89 for ; Mon, 2 Nov 2020 10:17:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CA3B20706 for ; Mon, 2 Nov 2020 10:17:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N+WmB8C/"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="VbCWBKo/"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ZiAICfgG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CA3B20706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PW4x7j22hcy6UZhqzyuTLLCeAZT5lrnVjx7MWkYI9fs=; b=N+WmB8C/QfUBy1rD8WRX+27A4 7VKVLQEElI2Ovt94FYUgVEAL23NMKAlJSUsQfcYzYSxgZrBS9z7JEXIvE10W48V8t5cSPkV1TLe4/ PZ64Tu9w4Lb+5wEkT5GoyJ1LSMwfyIBsF/TEtTaLIWRITQJctBFrLPCaCj/crZ23htqSAGu7+2Shf 7u7W0fRmZKUuM46zjoPkkBy00fKxOzvN3/vwHZCV0aLyjIs1kvReV8sF8gkx5J53FbO8m/JDVnLQT Q9V+iyrrH8A3xB/yy1svaiI88KJ19XtgPsDdYeTiLp0XWNB0tfdiSuh4eH/lJNR/Iroj2aPPz6dBU 5zqfYfKiw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZWtF-00012Y-5w; Mon, 02 Nov 2020 10:16:41 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZWt3-0000zF-Sm for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 10:16:33 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 533ADF40; Mon, 2 Nov 2020 05:16:28 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 02 Nov 2020 05:16:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=qg+IBDr4XlMr/uCqKeMaRSomA6I /aeqM6HF4bPsS+Z8=; b=VbCWBKo/3EekOTVOQv9W9UGuStt54qsdvlvr/F01kEf K1PVegrpfhdqKJfuhbEXeP7O0drw5/qz7gXe9OObUeJOUOmYzwFZ5u7k3oBf0Rez b0ltNICOJGZGc079xREchOj3LTXHKgKZzzqeRJiEeNppLnupyNCUgeQJan0tyfng Q6uWPXJe0qqA7A+p3fNdhN4uKpPk+X7j13U0fJkTcctIhPq+wcle4lZCvQpYvig2 BhgkWsa9PCyU2ndafayF68DeJZ/YRQyHZWfPNTK3FKRMWysDt9T7Cl/ztmW+4vN+ U0N9Ayfb2gCO/y0EgS2ru/NOLT7r4OTN8ouSaZcfg4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=qg+IBD r4XlMr/uCqKeMaRSomA6I/aeqM6HF4bPsS+Z8=; b=ZiAICfgGzu/QBLJfQWDGmX 9uN62n1VilZjvurmmBN7JGr1INuC2O8r6FFimRK+LOUK8ZdfEVadEUvdsod3b2s1 gsW0Oq7frqGZ+wHssQbAf8ukmwDjCHVU9nEAyYZ2FeF+hIr3ZuOJbz6yEZTqXkkx en/SRPngosvsO/u+xhqFu6rxcQ5RSw40wEszAHf7b2oD7pOiXV3grSEastxbFrGQ l/WNz/8QHnsCvy4+LC+9ldmBki2cE0zQryxaOYe2vfvrctBQ9RV4Y45DSe7TV2Y5 v9Boo6jF7ucOgYjawEpnOL4e9FX/F4G+mHn64fl3Vt5/BRHI7F0cwmy1inLPP6SQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtuddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 18A743064674; Mon, 2 Nov 2020 05:16:27 -0500 (EST) Date: Mon, 2 Nov 2020 11:16:26 +0100 From: Maxime Ripard To: Paul Kocialkowski Subject: Re: [PATCH 9/9] ARM: dts: sun8i-v3: Add support for the SL631 Action Camera with IMX179 Message-ID: <20201102101626.t4ox3rwbwp335i2m@gilmour.lan> References: <20201031182137.1879521-1-contact@paulk.fr> <20201031182137.1879521-10-contact@paulk.fr> MIME-Version: 1.0 In-Reply-To: <20201031182137.1879521-10-contact@paulk.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_051630_747662_1A12A4A7 X-CRM114-Status: GOOD ( 27.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matteo Scordino , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: multipart/mixed; boundary="===============8483068881240906906==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8483068881240906906== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i74lwqhb42esp3s4" Content-Disposition: inline --i74lwqhb42esp3s4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 31, 2020 at 07:21:37PM +0100, Paul Kocialkowski wrote: > The SL631 is a family of Allwinner V3 action cameras sold under > various names, such as SJCAM SJ4000 Air or F60 Action Camera. >=20 > Devices in this family share a common board design but can be found > with different image sensors, including the IMX179 and the OV4689. >=20 > This adds support for a common dtsi for the SL631 family as well as > a specific dts for the IMX179 fashion, which will later be populated > with an IMX179 node when a driver is available. >=20 > Features that were tested on the device include: > - UART debug > - MMC > - USB peripheral (e.g. g_ether) > - Buttons > - SPI NOR flash >=20 > Note that the exact designer/vendor of these boards is unknown. >=20 > Signed-off-by: Paul Kocialkowski > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/sun8i-v3-sl631-imx179.dts | 12 ++ > arch/arm/boot/dts/sun8i-v3-sl631.dtsi | 145 ++++++++++++++++++++ > 3 files changed, 158 insertions(+) > create mode 100644 arch/arm/boot/dts/sun8i-v3-sl631-imx179.dts > create mode 100644 arch/arm/boot/dts/sun8i-v3-sl631.dtsi >=20 > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 4363ba564bb4..b76bcda9a9df 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1196,6 +1196,7 @@ dtb-$(CONFIG_MACH_SUN8I) +=3D \ > sun8i-s3-lichee-zero-plus.dtb \ > sun8i-s3-pinecube.dtb \ > sun8i-t3-cqa3t-bv3.dtb \ > + sun8i-v3-sl631-imx179.dtb \ > sun8i-v3s-licheepi-zero.dtb \ > sun8i-v3s-licheepi-zero-dock.dtb \ > sun8i-v40-bananapi-m2-berry.dtb > diff --git a/arch/arm/boot/dts/sun8i-v3-sl631-imx179.dts b/arch/arm/boot/= dts/sun8i-v3-sl631-imx179.dts > new file mode 100644 > index 000000000000..9e3b78000bdb > --- /dev/null > +++ b/arch/arm/boot/dts/sun8i-v3-sl631-imx179.dts > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR X11) > +/* > + * Copyright 2020 Paul Kocialkowski > + */ > + > +#include "sun8i-v3-sl631.dtsi" > + > +/ { > + model =3D "SL631 Action Camera with IMX179"; > + compatible =3D "unknown,sl631-imx179", "unknown,sl631", > + "allwinner,sun8i-v3"; > +}; > diff --git a/arch/arm/boot/dts/sun8i-v3-sl631.dtsi b/arch/arm/boot/dts/su= n8i-v3-sl631.dtsi > new file mode 100644 > index 000000000000..9bc84d2812a6 > --- /dev/null > +++ b/arch/arm/boot/dts/sun8i-v3-sl631.dtsi > @@ -0,0 +1,145 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR X11) > +/* > + * Copyright 2020 Paul Kocialkowski > + */ > + > +/dts-v1/; > + > +#include "sun8i-v3.dtsi" > + > +#include > +#include > + > +/ { > + model =3D "SL631 Action Camera"; > + compatible =3D "unknown,sl631", "allwinner,sun8i-v3"; > + > + aliases { > + serial0 =3D &uart1; > + }; > + > + chosen { > + stdout-path =3D "serial0:115200n8"; > + }; > +}; > + > +&i2c0 { > + status =3D "okay"; > + > + axp209: pmic@34 { > + reg =3D <0x34>; > + interrupt-parent =3D <&nmi_intc>; > + interrupts =3D <0 IRQ_TYPE_LEVEL_LOW>; > + }; > +}; > + > +&i2c1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c1_pb_pins>; > + status =3D "okay"; > +}; > + > +&lradc { > + vref-supply =3D <®_ldo2>; > + status =3D "okay"; > + > + button@174 { > + label =3D "Volume Down"; > + linux,code =3D ; > + channel =3D <0>; > + voltage =3D <174603>; > + }; > + > + button@384 { > + label =3D "Volume Up"; > + linux,code =3D ; > + channel =3D <0>; > + voltage =3D <384126>; > + }; > + > + button@593 { > + label =3D "Home"; > + linux,code =3D ; > + channel =3D <0>; > + voltage =3D <593650>; > + }; > +}; The buttons are not valid node names, since you can't use a unit-address without reg. > +&mmc0 { > + cd-gpios =3D <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */ > + bus-width =3D <4>; > + vmmc-supply =3D <®_dcdc3>; > + status =3D "okay"; > +}; > + > +&pio { > + vcc-pd-supply =3D <®_dcdc3>; > + vcc-pe-supply =3D <®_dcdc3>; > +}; > + > +#include "axp209.dtsi" > + > +&ac_power_supply { > + status =3D "okay"; > +}; > + > +&battery_power_supply { > + status =3D "okay"; > +}; > + > +®_dcdc2 { > + regulator-always-on; > + regulator-min-microvolt =3D <1250000>; > + regulator-max-microvolt =3D <1250000>; > + regulator-name =3D "vdd-sys-cpu"; > +}; > + > +®_dcdc3 { > + regulator-always-on; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + regulator-name =3D "vdd-3v3"; > +}; > + > +®_ldo1 { > + regulator-name =3D "vdd-rtc"; > +}; > + > +®_ldo2 { > + regulator-always-on; > + regulator-min-microvolt =3D <3000000>; > + regulator-max-microvolt =3D <3000000>; > + regulator-name =3D "avcc"; > +}; > + > +®_ldo4 { > + regulator-always-on; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + regulator-name =3D "vcc-ep952"; > +}; AFAIK we don't have a driver for the ep952, why would we need to leave that regulator on? > + > +&spi0 { > + status =3D "okay"; > + > + spi-flash@0 { > + reg =3D <0>; > + compatible =3D "macronix,mx25l6436f", "jedec,spi-nor"; > + spi-max-frequency =3D <50000000>; > + }; > +}; > + > +&uart1 { > + pinctrl-0 =3D <&uart1_pg_pins>; > + pinctrl-names =3D "default"; > + status =3D "okay"; > +}; > + > +&usb_otg { > + dr_mode =3D "peripheral"; > + status =3D "okay"; > +}; Is it a peripheral because you didn't test the host mode, or because the hardware doesn't have it? Maxime --i74lwqhb42esp3s4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX5/ceQAKCRDj7w1vZxhR xRo/AQC3qL538wZDRER4BfR4LNPpXtG/F1qshqGgRHhAYXw1DAD+JeIG9nRQhuDU A3vBG7tVyqz9RBO3iCX9a0n3kck5iQI= =Lax1 -----END PGP SIGNATURE----- --i74lwqhb42esp3s4-- --===============8483068881240906906== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8483068881240906906==--