From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD54C00A89 for ; Mon, 2 Nov 2020 10:26:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B69532071E for ; Mon, 2 Nov 2020 10:26:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rMmgirGC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B69532071E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paulk.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Huk2BeOxLkSxMREZe1fZ2n+8NrhjuiXSKMuYKsE/7Pk=; b=rMmgirGCpRvvuffLA5Z+fEPyz nmPHLSh9vyOP5iwpIPQYdH7T9jev7Gn8+hEtEFzYJIoG3rxFW+WyDEnIcWkJ8vYuz07Ko/GbfK+Y5 007i7nBHJzpPRYa4ldIn56nDjYqJgGkhETH5rLSKGC3b1yfU7rLgLpN5MzPa9DywzGeZQiz0AXrfi ax9h+EdvHjPB8EajYoMr8jzkhnZSTd1GGv769qOiM9cz2PExcp65QXhO1HO3Q8tndZm4aSzKVbIRk KisUH2dob5qetAvdTzf9XOEOmYOJVtmaDjMInGFp0EiqXcVT9TVmQEcJ5PyKLe61WiTN1u5vq22sc NAc6oEvbQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZX1r-0003p7-Q6; Mon, 02 Nov 2020 10:25:35 +0000 Received: from vpn-0-22.aquilenet.fr ([2a0c:e300:4:22::] helo=leonov.paulk.fr) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZX1o-0003nk-G3 for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 10:25:33 +0000 Received: from gagarine.paulk.fr (gagarine [192.168.1.127]) by leonov.paulk.fr (Postfix) with ESMTPS id 44E4FC013D for ; Mon, 2 Nov 2020 11:25:30 +0100 (CET) Received: by gagarine.paulk.fr (Postfix, from userid 114) id 90569C1D6E; Mon, 2 Nov 2020 11:25:29 +0100 (CET) Received: from aptenodytes (unknown [192.168.1.1]) by gagarine.paulk.fr (Postfix) with ESMTPSA id 220ACC1D6C; Mon, 2 Nov 2020 11:25:23 +0100 (CET) Date: Mon, 2 Nov 2020 11:25:22 +0100 From: Paul Kocialkowski To: Maxime Ripard Subject: Re: [PATCH 6/9] ARM: dts: sun8i-v3s: Add the V3s NMI IRQ controller Message-ID: <20201102102522.GB11809@aptenodytes> References: <20201031182137.1879521-1-contact@paulk.fr> <20201031182137.1879521-7-contact@paulk.fr> <20201102101211.wtkmgfm2rcm5gdyp@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201102101211.wtkmgfm2rcm5gdyp@gilmour.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_052532_774798_2EECB250 X-CRM114-Status: GOOD ( 14.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matteo Scordino , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon 02 Nov 20, 11:12, Maxime Ripard wrote: > On Sat, Oct 31, 2020 at 07:21:34PM +0100, Paul Kocialkowski wrote: > > The V3s/V3 has a NMI interrupt controller, mainly used for the AXP209. > > Its address follows the sytsem controller block, which was previously > > incorrectly described as spanning over 0x1000 address bytes. > > Is it after, or right in the middle of it? That's up for interpretation actually: - The V3 datasheet mentions that System Control is 0x01C00000 --- 0x01C00FFF; - In practice, sunxi_sram.c uses a regmap with max_reg set to 0x30 for the V3s/H3 so this gives us some room. Looking at other SoCs with the same setup (take sun8i-r40 for instance), system-control is limited to 0x30 and the NMI controller follows it. In the case of R40, the SRAM controlled is also said to be 4K-long in the Allwinner docs. So all in all, this leads me to believe that the system-controller instance stops well before 0x1c000d0 on the V3s as well. Otherwise, we should also make the R40 consistent. Cheers, Paul -- Developer of free digital technology and hardware support. Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel