From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD4BC00A89 for ; Mon, 2 Nov 2020 10:32:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBA3F21D40 for ; Mon, 2 Nov 2020 10:32:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rORfmtcN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="V0s1igeC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBA3F21D40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WPtnuIeMQvwBUCpam2+Tjc/XnMFcqi0+suo8I4NwUV4=; b=rORfmtcN2Ok+bQ2bGTTNSwkm6 6BUpX0aeppTDjetvxrJ212V7jWuR3EzppmGHNSUM/2rQClQRRk/QKjDB6sroKKMkvrRYeXBWfD4fz N3wYepKPHFRBvfNOsQUn6/t98yue4Nkqu2dhVpdA0AK+ScxZMn2XIvxjeLu0oCpUuEBVuLY7IB6wb rUoI1sCQbWpY7WRp8tU3s3Z5/sniPaX9Z+Q/x7We+6WH7rHsgmLcIH4UnjynVbI9mXX8TTwZLZvex CCS7px+vPY57x1BUgI4ZFw3ACp1B1BAuKI+jPM8pWTcNeUv0yHc+fO2rYtLcvQ4Aa47GTb9w8oDGE oLYiYGssg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZX6l-0004m9-8P; Mon, 02 Nov 2020 10:30:39 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZX6h-0004lS-Rf for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 10:30:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gH6cU0WjGIcLU1WLwkM2Gr2ClysO1THsAmJqx+M+7fA=; b=V0s1igeCcWjchc3yKAAw+HG+S Y+vuhHjJul7EwUWak7bzSsvc8pQKqvZYJHEuETqek8B+nwPHsr7/b1FRqQamr2sm5A4cJnhmmW4yK vM+vZKRpyyDBqAlEEVw3CU279DQ//50Dffb/rcs4HhFApBiqNBmIlqY+esNPDHtyjannYD3Lm20a6 vBFQc0QwE4NTnyx5XxJjxdq4KJOBj4e/4c9j2pHf904vWwHrKKWuU+YPjd5oIOpwSdBMNY34K6R+G Mg6ZEesLOFvHUnHybGZuUI3QmqG2jcCFwnMcuEaI3zsR4/RFId8fQYKAHG7HH/F5ldxsb1szNI7Hy RzieoJ2zw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54096) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZX6e-0000RB-Ld; Mon, 02 Nov 2020 10:30:32 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kZX6d-0001gp-TX; Mon, 02 Nov 2020 10:30:32 +0000 Date: Mon, 2 Nov 2020 10:30:31 +0000 From: Russell King - ARM Linux admin To: Lee Jones Subject: Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier Message-ID: <20201102103031.GL1551@shell.armlinux.org.uk> References: <20201030181822.570402-1-lee.jones@linaro.org> <20201031102709.GH1551@shell.armlinux.org.uk> <20201101131122.GD4127@dell> <20201102102343.GK1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201102102343.GK1551@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_053035_957937_EABC7920 X-CRM114-Status: GOOD ( 22.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, stable@vger.kernel.org, gregkh@linuxfoundation.org, yepeilin.cs@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 02, 2020 at 10:23:43AM +0000, Russell King - ARM Linux admin wrote: > On Sun, Nov 01, 2020 at 01:11:22PM +0000, Lee Jones wrote: > > On Sat, 31 Oct 2020, Russell King - ARM Linux admin wrote: > > > > > On Fri, Oct 30, 2020 at 06:18:22PM +0000, Lee Jones wrote: > > > > Commit 09e5b3fd5672 ("Fonts: Support FONT_EXTRA_WORDS macros for > > > > > > Your commit ID does not exist in mainline kernels, which makes this > > > confusing. The commit ID you should be using is 6735b4632def. > > > > Ah yes, quite right. That is the ID from android-3.18 where this > > issue was first seen and fixed against. I will fix it up for > > Mainline. > > > > Does the fix look okay to you though Russell? > > Frankly, I don't know. Looking at the commit itself, it looks safe, > but it depends what this "extra" data is being used for. From what > I can see, the commit in question just adds the additional opaque > data as a member named "extra", and one is left to guess what it's > use as. > > I'd have thought a small structure with named members would have > been the minimum given our standards for in-kernel code. > > Why was the "const" dropped in the first place? Does this "extra" > member get written to somewhere? > > So, sorry, no idea. This looks to me like a very unsatisfactory > commit, and probably something that got a very poor review. Also, the commit description is missing a chunk: For user-provided fonts, the framebuffer layer resolves this issue by reserving four extra words at the beginning of data buffers. Later, whenever a function needs to access them, it simply uses the following macros: Recently we have gathered all the above macros to . So what were these macros that have been nicely removed from the commit description? I guess they started with a '#' character and git thought they were a comment. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel