From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78EF3C00A89 for ; Mon, 2 Nov 2020 10:35:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E160022226 for ; Mon, 2 Nov 2020 10:35:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0DWgu47z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E160022226 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paulk.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rFYhyuvUvn4HvSRkMgTB787fJmubrX8OweG0tqdRhtk=; b=0DWgu47zjvWH2/QR2FGBLucEH GqRyMMiPPp1adZJYqgm6zZ3/0GbEwQEeRzmxKJrcG/TEF8qe9Yqi8rbxEyF50i+YjeDeFdvU3vkjD fwFYMomoDZymodBgWD2mEoLNah+ORHOrW1IYQpTMRiRvwNIwMFZEqC7ARZSXYa59ZEuqVx9rYlqsX SbjhIeQTALHXgZ1OFSuS654/jbaNZwLk45+tEDDwJTo/Puj9KMdSjn4F0rPoHXTMQhD2Y1BUnNBIS GVkko0Y5t4BJ4vtFls8I6FC42cwkOj3Xjh6VMsySsfuw+iOhYdgY4yjGWKbT4k/5pWsxRSuh/5DON Wj8fkC0cw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZX9q-0005aP-Uu; Mon, 02 Nov 2020 10:33:51 +0000 Received: from leonov.paulk.fr ([185.233.101.22]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZX9o-0005Zn-No for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 10:33:49 +0000 Received: from gagarine.paulk.fr (gagarine [192.168.1.127]) by leonov.paulk.fr (Postfix) with ESMTPS id 66824C0121 for ; Mon, 2 Nov 2020 11:33:47 +0100 (CET) Received: by gagarine.paulk.fr (Postfix, from userid 114) id 70DFDC1D7D; Mon, 2 Nov 2020 11:33:46 +0100 (CET) Received: from aptenodytes (unknown [192.168.1.1]) by gagarine.paulk.fr (Postfix) with ESMTPSA id C4F8EC1D7A; Mon, 2 Nov 2020 11:33:40 +0100 (CET) Date: Mon, 2 Nov 2020 11:33:40 +0100 From: Paul Kocialkowski To: Maxime Ripard Subject: Re: [PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179 bindings Message-ID: <20201102103340.GD11809@aptenodytes> References: <20201031182137.1879521-1-contact@paulk.fr> <20201031182137.1879521-9-contact@paulk.fr> <20201102101333.4bm2lfqpqnbpyp63@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201102101333.4bm2lfqpqnbpyp63@gilmour.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_053348_906869_11515957 X-CRM114-Status: GOOD ( 19.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matteo Scordino , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon 02 Nov 20, 11:13, Maxime Ripard wrote: > On Sat, Oct 31, 2020 at 07:21:36PM +0100, Paul Kocialkowski wrote: > > Document the compatible strings for the SL631 Action Camera with IMX179. > > > > Signed-off-by: Paul Kocialkowski > > --- > > Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > > index afa00268c7db..0fa0c0b5d89f 100644 > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > > @@ -754,6 +754,12 @@ properties: > > - const: sinlinx,sina33 > > - const: allwinner,sun8i-a33 > > > > + - description: SL631 Action Camera with IMX179 > > + items: > > + - const: unknown,sl631-imx179 > > + - const: unknown,sl631 > > + - const: allwinner,sun8i-v3 > > + > > unknown is not a valid vendor (and you should explain why you picked > that vendor name in the first place). Ah right, it's not in the vendor prefixes. The rationale is that there is no indication of what the vendor might be on the PCB. Should I maybe use allwinner here? It looks derived from a V3 reference design anyway (at least the pin assignment matches e.g. Sochip's S3 EVB and other known S3 boards too apparently) so this could make sense. Cheers, Paul -- Developer of free digital technology and hardware support. Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel