From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26714C00A89 for ; Mon, 2 Nov 2020 10:37:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4811206BE for ; Mon, 2 Nov 2020 10:37:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hdiPUbk6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4811206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sCiI2wRtnTuvCukAHqm2TVFcTX+3rlgecEfGO7dF2/g=; b=hdiPUbk6LBIjq6Yb/N913F3s/ Yg7Bh/QPrKkRd+f5AgZlJAekSvmct6hShmXZbBGHvFX6LGuCtp+w2ShC025sce5jQJ6+FQ16oxdH6 lSg1GS35cwvIIIXnDQT9tBgDBuDhRWSTGZveh6rubbm35AazJdhuP0Ajul2h7SohwDUySxpQo5mpg Jnxg7nSKLsUtGecT6TJ0S6r/ImVvU5dh1TNbJMQ2PAqzp/i+x1Zm+QzzBPiSCMQwffcR1WX6m843b 48rJcd8jvAUrx2RdovHQQjGlV8f2nBGTJtIQsVAJanszAl+m76fCBvoW5vddGN4Eb6EzZlxUvd2f+ iO8JOd++g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZXBn-0005vF-DW; Mon, 02 Nov 2020 10:35:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZXBk-0005uV-0B for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 10:35:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 415E5101E; Mon, 2 Nov 2020 02:35:46 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.54.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 244283F719; Mon, 2 Nov 2020 02:35:45 -0800 (PST) Date: Mon, 2 Nov 2020 10:35:42 +0000 From: Mark Rutland To: Robin Murphy Subject: Re: [PATCHv3 13/17] arm64: uaccess cleanup macro naming Message-ID: <20201102103542.GC71783@C02TD0UTHF1T.local> References: <20201026133156.44186-1-mark.rutland@arm.com> <20201026133156.44186-14-mark.rutland@arm.com> <39f1be4b-54b6-11be-2211-18c3e90a097e@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <39f1be4b-54b6-11be-2211-18c3e90a097e@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_053548_114003_BFDCAEA1 X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, hch@lst.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 27, 2020 at 06:45:16PM +0000, Robin Murphy wrote: > On 2020-10-26 13:31, Mark Rutland wrote: > > Now the uaccess primitives use LDTR/STTR unconditionally, the the > > uao_{ldp,stp,user_alternative} asm macros are misnamed, and have a > > redunant argument. Let's remove te redundant argument and rename these > > :set spell Yikes! [...] > > diff --git a/arch/arm64/lib/mte.S b/arch/arm64/lib/mte.S > > index 03ca6d8b86706..351537c12f36e 100644 > > --- a/arch/arm64/lib/mte.S > > +++ b/arch/arm64/lib/mte.S > > @@ -4,7 +4,7 @@ > > */ > > #include > > -#include > > +#include > > Shouldn't that be in patch #8? Yup; I've just chuffled that over now. > > Otherwise, the rename looks OK to me, so with the nits picked, > > Reviewed-by: Robin Murohy Thanks! Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel