Re: [PATCHv3 13/17] arm64: uaccess cleanup macro naming

Mark Rutland
2020-11-02T10:37:12Z

On Tue, Oct 27, 2020 at 06:45:16PM +0000, Robin Murphy wrote:
> On 2020-10-26 13:31, Mark Rutland wrote:
> > Now the uaccess primitives use LDTR/STTR unconditionally, the the
> > uao_{ldp,stp,user_alternative} asm macros are misnamed, and have a
> > redunant argument. Let's remove te redundant argument and rename these
>
> :set spell

Yikes!

[...]

> > diff --git a/arch/arm64/lib/mte.S b/arch/arm64/lib/mte.S
> > index 03ca6d8b86706..351537c12f36e 100644
> > --- a/arch/arm64/lib/mte.S
> > +++ b/arch/arm64/lib/mte.S
> > @@ -4,7 +4,7 @@
> > */
> > #include <linux/linkage.h>
> > -#include <asm/alternative.h>
> > +#include <asm/asm-uaccess.h>
>
> Shouldn't that be in patch #8?

Yup; I've just chuffled that over now.

>
> Otherwise, the rename looks OK to me, so with the nits picked,
>
> Reviewed-by: Robin Murohy <robin.murphy@arm.com>

Thanks!

Mark.