From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B11C00A89 for ; Mon, 2 Nov 2020 13:44:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A0232074F for ; Mon, 2 Nov 2020 13:44:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BY9vcsVX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="cVkQJTnC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A0232074F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZcB6bDYBSW+AKynG+77FoaQuL1EamV+ow4pJp0ufvos=; b=BY9vcsVXmYIXSYs267viHBmQY KK3TueOyQXaoA+InTKU5jZr50HHDtNoRVGCd1YElLRw5j3NBfR8v1jzvpj021wwMrOw3CgjbyGFRW u9ZCRC3uEeVWqhx5qVh0Vs6o3+qTqUsQC/l+uFq6QTxUPcAKmK5Mm2yMsVGn0ABdQgcAwQx09TZ+R fZ5a8pNHQV0hjtaeblk1yRY0zNKR53hMOlKt0G7o4L/Gw13wZcWw+wVR82hw9y23Qm0MsuBp2VaOp avCSx/Jr4pwpVAWbAFFxa+/Fq8FL2Mt0bWKehl80GEWDY6MSe1bcj+1aEWGO6S5kplV+VglEeXBx0 TkSrtfV2Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZa7S-0002GQ-25; Mon, 02 Nov 2020 13:43:34 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZa7O-0002F3-A6 for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 13:43:31 +0000 Received: by mail-wm1-x344.google.com with SMTP id h62so4725520wme.3 for ; Mon, 02 Nov 2020 05:43:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mfKBeD4fiXTCoEtzR3WkNNJyJEURTLKGrVDQO6IkliM=; b=cVkQJTnCjfBar8bMUhCyQlY6NBjef7UxGui8W+iKgFzgtMfWzOKQPVzwUgSwmzU0th P9Fk9hSPwRk3llvxISfb4gdJ1oLahMM1fmJ7zNVDMNx2hFWSOKyIV77SJnCdibWP6suU JFerKCnRMv1SPia1lvVdFKHdFAbdXBe6Nt2o8w3Vvvdze7WlRSatKlm2uY1hbQ7BXT3P 5n4ZUHFTjFoA+l+/4AHonvxZjbP7xgBiMRErE2K/lPInLr6NVqyVJ38ehkyOVbbN/9we v8F/mNfoXaPnLwGVCFxjOX+yO+x75jqKUzcJ8I0wM79PZDup5JBSReJcWPZXfOle1/75 83Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mfKBeD4fiXTCoEtzR3WkNNJyJEURTLKGrVDQO6IkliM=; b=eBaTh8TQS0hxNWADtld0tLOD6LDR1eTgnqW0w8v633okVhExxSziI5x72ihTUVjO5B qHflgXKTSZwOEFj29vqGnntF+MSEyfQD4LURRPjjT2DEqvKDUutHck1CX2lnjuZvX7QH DZfSeRma2ptFsL/6yGCfy5IDQydj06dk+gAeQxfAobERU8QE2tqZLA/vRLvGKwLIZf9S 8VtCJt56gKvyXgtItaeeN22G08VgBQN+PQsRjExSUvHCDHHUxDkv8j5BcH2zZGbffChp VuYb9TXBqitjYr7Hu42m/OHpXJFdCqv7bZhUUldjVJrclv58XWUnkzcDB37NLf2kSqiM 6u7w== X-Gm-Message-State: AOAM5331ukDgExbHj989eiN/pPxFEbl2d/R6GCjbBPpb/DM9ODM5vYQY YMFPsQBw9lVpMv31GPtNmtmMJw== X-Google-Smtp-Source: ABdhPJz0K6pXqtJ2PhgnwSFED6vdeFbe2TdR5EYo4AZ7bBruyE3BYiACCQ8EYnThnBVbjiO57E5gnw== X-Received: by 2002:a1c:4b04:: with SMTP id y4mr5834274wma.93.1604324607307; Mon, 02 Nov 2020 05:43:27 -0800 (PST) Received: from google.com ([2a00:79e0:d:210:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id k84sm9970495wmf.42.2020.11.02.05.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 05:43:26 -0800 (PST) Date: Mon, 2 Nov 2020 13:43:23 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH v3 1/4] PM / EM: Add a flag indicating units of power values in Energy Model Message-ID: <20201102134323.GA2221764@google.com> References: <20201019140601.3047-1-lukasz.luba@arm.com> <20201019140601.3047-2-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201019140601.3047-2-lukasz.luba@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_084330_446058_6752515A X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dianders@chromium.org, devicetree@vger.kernel.org, nm@ti.com, amitk@kernel.org, rnayak@codeaurora.org, daniel.lezcano@linaro.org, linux-doc@vger.kernel.org, sboyd@kernel.org, viresh.kumar@linaro.org, mka@chromium.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, morten.rasmussen@arm.com, robh+dt@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, corbet@lwn.net, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday 19 Oct 2020 at 15:05:58 (+0100), Lukasz Luba wrote: > diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h > index b67a51c574b9..2c31d79bb922 100644 > --- a/include/linux/energy_model.h > +++ b/include/linux/energy_model.h > @@ -29,6 +29,8 @@ struct em_perf_state { > * em_perf_domain - Performance domain > * @table: List of performance states, in ascending order > * @nr_perf_states: Number of performance states > + * @milliwatts: Flag indicating the power values are in milli-Watts > + * or some other scale. > * @cpus: Cpumask covering the CPUs of the domain. It's here > * for performance reasons to avoid potential cache > * misses during energy calculations in the scheduler > @@ -43,6 +45,7 @@ struct em_perf_state { > struct em_perf_domain { > struct em_perf_state *table; > int nr_perf_states; > + bool milliwatts; > unsigned long cpus[]; > }; Make that an int please, sizeof(bool) is impdef. With that: Reviewed-by: Quentin Perret _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel