From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E699C00A89 for ; Mon, 2 Nov 2020 15:06:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AF592072C for ; Mon, 2 Nov 2020 15:06:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GHPEghm5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AF592072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PoiFsIftXnZIQ3FOZxU5jIFDWFUIleGXYFRwgLK6PPA=; b=GHPEghm5wqQbyD3rWzCXR2ZhG Yi5N9+6vveRhWzWIqvf+qPrJ0HPwUnN5tU9GA+3rb0QJDXrzNdYXvgdK4Wp+uCsTVZybf6yz5PyNe LvRtE9waiHmfTycVMOwD9q13riU1YM5GjkgvKmhNhJEJgyw1ry5p77wuvUoTI7kY6ylNjxjjtq+H5 OD4f6Rgjk4uB/pZlpTxrX3KxWVy78kX30fdmohUrD0x0QBF44ChF1O/7MDR+6ZvIfNoFcC7mU9K7W ri3Ci7uNBNAH+QyojW0mIqGg0/jdXWuZUQDD7bQms3MIjUJB/DTA019IMNr/7MZefUuIro11TA023 V299OXpzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZbPM-0006kq-Ir; Mon, 02 Nov 2020 15:06:08 +0000 Received: from mga07.intel.com ([134.134.136.100]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZbPK-0006kF-3G for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 15:06:07 +0000 IronPort-SDR: KTuoH35JRDDHm+6BDkB+stVV8KsBl3JbiR4dzRihyEARi7JpiQNKYO3ePS6idLU2zEgHe4ZYpY 8dQ9cPDyCrDQ== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="233065173" X-IronPort-AV: E=Sophos;i="5.77,445,1596524400"; d="scan'208";a="233065173" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 07:05:53 -0800 IronPort-SDR: Rk8KtKoJ0WVtwG02bBKp1DCA0eUAmt8IjohOY2uUVmJxltiamIaBUqjCxBJtRh0gJOGywbmexx B7HKWx+fVHeA== X-IronPort-AV: E=Sophos;i="5.77,445,1596524400"; d="scan'208";a="426011235" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 07:05:49 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 8F638208F7; Mon, 2 Nov 2020 17:05:47 +0200 (EET) Date: Mon, 2 Nov 2020 17:05:47 +0200 From: Sakari Ailus To: Krzysztof Kozlowski Subject: Re: [PATCH v5 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor Message-ID: <20201102150547.GY26150@paasikivi.fi.intel.com> References: <20201019170247.92002-1-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201019170247.92002-1-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_100606_305573_99619909 X-CRM114-Status: GOOD ( 25.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Rob Herring , Stephen Boyd , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Fabio Estevam , Michael Turquette , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krysztof, On Mon, Oct 19, 2020 at 07:02:44PM +0200, Krzysztof Kozlowski wrote: > Add bindings for the IMX258 camera sensor. The bindings, just like the > driver, are quite limited, e.g. do not support regulator supplies. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Rob Herring > > --- > > Changes since v4: > 1. Add clock-lanes, > 2. Add Rob's review, > 3. Add one more example and extend existing one, > 4. Add common clock properties (assigned-*). > > Changes since v3: > 1. Document also two lane setup. > > Changes since v2: > 1. Remove clock-frequency, add reset GPIOs, add supplies. > 2. Use additionalProperties. > > Changes since v1: > 1. None > --- > .../devicetree/bindings/media/i2c/imx258.yaml | 140 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 141 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx258.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/imx258.yaml > new file mode 100644 > index 000000000000..4a3471fb88a1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/imx258.yaml > @@ -0,0 +1,140 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/imx258.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor > + > +maintainers: > + - Krzysztof Kozlowski > + > +description: |- > + IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel > + type stacked image sensor with a square pixel array of size 4208 x 3120. It > + is programmable through I2C interface. Image data is sent through MIPI > + CSI-2. > + > +properties: > + compatible: > + const: sony,imx258 > + > + assigned-clocks: true > + assigned-clock-parents: true > + assigned-clock-rates: true I discussed the matter of using assigned clocks with Rob some time ago and the conclusion of that was that the sensor driver could use the default frequency (set using assigned-clock-rates) instead of the explicit frequency in DT. There are use cases (sharing the clock signal between two sensors, but different frequencies) that would be affected by this but I don't think we have any in mainline so I guess this approach works for now without additional changes. If someone needs those use cases, it's likely DT clock binding semantings and clock framework changes will be needed. That'll be another discussion if it ever happens. -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel