From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB5AC00A89 for ; Mon, 2 Nov 2020 15:55:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C36E22258 for ; Mon, 2 Nov 2020 15:55:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eIU8ihpv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wXlymlSt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C36E22258 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oREs5y0lahwPp78wSeuyCNba+/2YyoG3Ixon0b2lWN4=; b=eIU8ihpvZiCQ0D8+370EVoe9q Ac69GQTpHIUDVgqC9ae+OFx3Z41268BdMUaOuI7MPxfLYfn+nGDU8BDnDhLh5Jw2bGZORz0Bj0zAJ 9Aod09xLFKCtJF/BEkDK4Y7oGykQgfgNtwY3xYbZH2Ehp5PI7gt+nbzvvS+BE7NPg8IxT9JXDSSyf 4CBYLty/JUtSXWZEDPQfn0pwAHtGys0tGFNhAQRodtUEFG3nMjOJBHfGbP9oI5Y5xVFJK6wNb+sZW sXJRGXChwjFZ9e1NVpnbCYN/aJxvnTrLex4F0Pd2mSir1+WwhpLlaxDg5tWu7Mj3dEkOBJf8FdI// 16UIBigkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZcA0-0004w9-PF; Mon, 02 Nov 2020 15:54:20 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZc9w-0004ui-Ss for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 15:54:17 +0000 Received: by mail-pf1-x442.google.com with SMTP id y14so11443162pfp.13 for ; Mon, 02 Nov 2020 07:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1vrzECiaWBeiBq9l7kPvoWRn3e/pBcE0avlni3wG6D0=; b=wXlymlStqCInllzkbQGt+QGzgVJNNnFu9FyHhNSouRC0vvk8k21EPC3zMIzpjxKmVH ZmYe258u7ytwCpOwXe/O4fJBDnm0QCwiR37uDix+FDAbDMoSBD5ZpiPw5V9Io0PD8riD KVYO1JGSrJPdP2uHt03gAkCO/PK0pEDwdZ+nMRZainwMiJeUnom4HgWH6ALl5n50l34T OBAY1VNZKoHbYtXwk/kUz7aR1JhucVNJ+I2HP+iIPZzocvlAYfmpfr4IiAnjJyNSLz1h 3Fr3WDSDpPmlVSUcmDoPJLFDzWih2XnI6XyWmxxDdlH0PEMgBrfWsIs7uJmYQhYkGXKV i4Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1vrzECiaWBeiBq9l7kPvoWRn3e/pBcE0avlni3wG6D0=; b=iSxl08fAiNa5+RBq1D63xs4yOBcQYUS8KZWhrjtId1tLEjClDnggvnJw6qYKz9/nlQ j3Si+YY8PE/IIifdNlqu4cuoqwAzmpU/OsRqXah2oDubVcv5f524v4lHFZAjUB94CWd1 OrJRmGp7UnP1hztW5+mb8hdUOBjHH/N+OircsqNV3L+wTo744Ki3KTEAeqGgHevpkU/1 2MZ+Ismwv4rP+cemczioNzirC3kHNYGJ2GiksMCIUs9iHVAgA1dVHaO55SQyDWWUeIFk yuFnZ3LdbypStJSNvLX/XaZkOL4/vOKvJJLELeJ6spGxKItdfRAKHzwmpWMTGjTPSVLP 2JWg== X-Gm-Message-State: AOAM531N4133LhcpB9tjGQvnF2c9LLcyepHa/Pls9dCermfK3Mux0Bau b0v7mngc1cLHytbKO9b11eGF X-Google-Smtp-Source: ABdhPJz1NniixdppysYFa0woWutPPGbzr5naR4tv7+GicWc3IN7HyHQCL307+sfnTYuFMeeCpGSc6Q== X-Received: by 2002:a63:1d15:: with SMTP id d21mr13875401pgd.433.1604332453083; Mon, 02 Nov 2020 07:54:13 -0800 (PST) Received: from Mani-XPS-13-9360 ([2409:4072:88d:1669:71a1:e02e:eb52:9e34]) by smtp.gmail.com with ESMTPSA id j11sm13828752pfc.64.2020.11.02.07.54.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Nov 2020 07:54:12 -0800 (PST) Date: Mon, 2 Nov 2020 21:24:03 +0530 From: Manivannan Sadhasivam To: Tian Tao Subject: Re: [PATCH] mmc: owl-mmc: replace spin_lock_irqsave by spin_lock in hard IRQ Message-ID: <20201102155403.GB4009@Mani-XPS-13-9360> References: <1604278337-55624-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1604278337-55624-1-git-send-email-tiantao6@hisilicon.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_105416_950094_5ADBF3D0 X-CRM114-Status: GOOD ( 21.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, afaerber@suse.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 02, 2020 at 08:52:17AM +0800, Tian Tao wrote: > The code has been in a irq-disabled context since it is hard IRQ. There > is no necessity to do it again. > Ah, yes. This should save few cycles! > Signed-off-by: Tian Tao Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/mmc/host/owl-mmc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c > index ccf214a..82d2bad 100644 > --- a/drivers/mmc/host/owl-mmc.c > +++ b/drivers/mmc/host/owl-mmc.c > @@ -134,10 +134,9 @@ static void owl_mmc_update_reg(void __iomem *reg, unsigned int val, bool state) > static irqreturn_t owl_irq_handler(int irq, void *devid) > { > struct owl_mmc_host *owl_host = devid; > - unsigned long flags; > u32 state; > > - spin_lock_irqsave(&owl_host->lock, flags); > + spin_lock(&owl_host->lock); > > state = readl(owl_host->base + OWL_REG_SD_STATE); > if (state & OWL_SD_STATE_TEI) { > @@ -147,7 +146,7 @@ static irqreturn_t owl_irq_handler(int irq, void *devid) > complete(&owl_host->sdc_complete); > } > > - spin_unlock_irqrestore(&owl_host->lock, flags); > + spin_unlock(&owl_host->lock); > > return IRQ_HANDLED; > } > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel