From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD784C00A89 for ; Mon, 2 Nov 2020 16:27:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BDB6208B6 for ; Mon, 2 Nov 2020 16:27:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o4DYLInf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jiNIyQ/3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BDB6208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qxHqRK4TpWzX0BI5Ds6XBgdufWNyTzAoKhhEciuhk14=; b=o4DYLInf8UkGa7n5AJ3wKQAqD 2KZPw2xSDNALbdCgSxyn1N3vcmnFFbgQo0rOqUCcgnE9LcxDfQraa0QOXavrPOlxRAIdV/VCOzsax QlcNdF2LDZSPruHlcnv3IqgnLF4BbWLTc16aJCv2PzHfB9JbQJyTQigOrwA9h5nUeCzy2rf8l8J3h vsNg46zuGnBZdb+tAS0GVRStaPknNSNJj1AywoCrYnax1Hl1B3Zd98GB/fQ36NXoV3KzvxUgwiTVk 5Fk8kaAIMuQTwOC6GdktapQq7N02+TUpKCvjtU351w7G02VH4lV6Mc375IirOaZE7iqgy+UtoIb7Z aiiKeuOTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZcdm-0008KG-Cj; Mon, 02 Nov 2020 16:25:06 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZca3-0006fb-Mu for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 16:21:31 +0000 Received: by mail-qk1-x741.google.com with SMTP id s14so11920127qkg.11 for ; Mon, 02 Nov 2020 08:21:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2Lpr4CBLha20HQqxlhXNSA8BtMmymsEInJVoKBpe5r0=; b=jiNIyQ/3PFCSdLX6ugfJegoJfHHnVBTjhaw81/66xW0rZL3RjMbV7RgPF7572ECozM u2/cQEMXeCTptr+OQ+oJxCEy63cRiG3E6LfpGQ212ge6VOpQllkh28hXirv+8g34+2us bLi0V71XOcL50R2UO/mhjwp+RdwSG0LR5GoTAUdGQQNrvL1Yc/U8Y+s4UUFUD/7WdbiT pykwiXMb50V/bbCfK+oRW0FPHJRw8Mui/Iip2JfaXep/9CFqFyVDDrQs2iNJploIkFUK pX5iIJp5Kwk8Kk3nOyxVD2s+IApkGSfYp7pIDbDBqWjrM2138/jJjZLZbQTcDRU98K5L kBtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2Lpr4CBLha20HQqxlhXNSA8BtMmymsEInJVoKBpe5r0=; b=R6cuyK3PjtPCfZghcVdk2vC0gx6f+JtxiwT4nO1D6d142a0lIxk5vnF3qxE2MetYWK x9IQy+Lp4PgAfID3HnwVWgjffnaP75lMRU7ZVXm3K60wFN+jYbx7Ci5xNjy4q5CnY5D9 f0hC0iiLyTO26bgM08F7ilv1DrqlVn6gjJH5tYUrx8DAvG1s2huVSeJTauhhEMP+45Vq uC+kWA6GbO0s6aganLg0kaHSCI8Rp81+7rNERxXhrBNJaWBnn0WtvHXOqY2Jq4V3yGWw 1bHPgcevNEb6pauCp6Oj9fcq6HYakNZ3TDYa5wrBgKfiKzLdWSSIwT867pOhbrEdbUmV 1uAA== X-Gm-Message-State: AOAM533TbLxzxANMN892s6PNv+q6AQ8z6jbTokc3bffQNjdX3vAYwCO5 ZYXn5VuEjzp0/j7/CS55ng== X-Google-Smtp-Source: ABdhPJwwOFt8TQzK9DM2mazQemEZvdOg6ct13ts4qWeveZlNnq65HE/KB2TcMcsxEQCiLV9ocByz1w== X-Received: by 2002:a37:7104:: with SMTP id m4mr15673359qkc.252.1604334072928; Mon, 02 Nov 2020 08:21:12 -0800 (PST) Received: from gabell (209-6-122-159.s2973.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [209.6.122.159]) by smtp.gmail.com with ESMTPSA id t8sm8466845qtb.97.2020.11.02.08.21.11 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Nov 2020 08:21:12 -0800 (PST) Date: Mon, 2 Nov 2020 11:21:10 -0500 From: Masayoshi Mizuma To: Sumit Garg Subject: Re: [PATCH v7 5/7] arm64: ipi_nmi: Add support for NMI backtrace Message-ID: <20201102162110.vmedu2g63yvdwh7m@gabell> References: <1604317487-14543-1-git-send-email-sumit.garg@linaro.org> <1604317487-14543-6-git-send-email-sumit.garg@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1604317487-14543-6-git-send-email-sumit.garg@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_112116_365672_8648F187 X-CRM114-Status: GOOD ( 21.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, daniel.thompson@linaro.org, tsbogend@alpha.franken.de, linux-kernel@vger.kernel.org, jason@lakedaemon.net, ito-yuichi@fujitsu.com, maz@kernel.org, x86@kernel.org, linux@armlinux.org.uk, dianders@chromium.org, jason.wessel@windriver.com, mingo@redhat.com, bp@alien8.de, mpe@ellerman.id.au, catalin.marinas@arm.com, kgdb-bugreport@lists.sourceforge.net, tglx@linutronix.de, julien.thierry.kdev@gmail.com, will@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 02, 2020 at 05:14:45PM +0530, Sumit Garg wrote: > Enable NMI backtrace support on arm64 using IPI turned as an NMI > leveraging pseudo NMIs support. It is now possible for users to get a > backtrace of a CPU stuck in hard-lockup using magic SYSRQ. > > Signed-off-by: Sumit Garg > --- > arch/arm64/include/asm/irq.h | 6 ++++++ > arch/arm64/kernel/ipi_nmi.c | 18 ++++++++++++++++-- > 2 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h > index b2b0c64..ef018a8 100644 > --- a/arch/arm64/include/asm/irq.h > +++ b/arch/arm64/include/asm/irq.h > @@ -6,6 +6,12 @@ > > #include > > +#ifdef CONFIG_SMP > +extern bool arch_trigger_cpumask_backtrace(const cpumask_t *mask, > + bool exclude_self); > +#define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace > +#endif > + > struct pt_regs; > > static inline int nr_legacy_irqs(void) > diff --git a/arch/arm64/kernel/ipi_nmi.c b/arch/arm64/kernel/ipi_nmi.c > index a945dcf..597dcf7 100644 > --- a/arch/arm64/kernel/ipi_nmi.c > +++ b/arch/arm64/kernel/ipi_nmi.c > @@ -8,6 +8,7 @@ > > #include > #include > +#include > #include > > #include > @@ -31,11 +32,24 @@ void arm64_send_nmi(cpumask_t *mask) > __ipi_send_mask(ipi_nmi_desc, mask); > } > > +bool arch_trigger_cpumask_backtrace(const cpumask_t *mask, bool exclude_self) > +{ > + if (!ipi_nmi_desc) > + return false; > + > + nmi_trigger_cpumask_backtrace(mask, exclude_self, arm64_send_nmi); > + > + return true; > +} > + > static irqreturn_t ipi_nmi_handler(int irq, void *data) > { > - /* nop, NMI handlers for special features can be added here. */ > + irqreturn_t ret = IRQ_NONE; > + > + if (nmi_cpu_backtrace(get_irq_regs())) > + ret = IRQ_HANDLED; > > - return IRQ_NONE; > + return ret; > } > > void dynamic_ipi_setup(int cpu) > -- It works well with sysrq l trigger. Please feel free to add: Tested-by: Masayoshi Mizuma Thanks! Masa _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel